linux-toradex.git/drivers/net/pptp.c, branch v3.1.1

pptp: pptp_rcv_core() misses pskb_may_pull() call

2011-10-19T07:50:43+00:00

e1000e uses paged frags, so any layer incorrectly pulling bytes from skb
can trigger a BUG in skb_pull()

[951.142737]  [] skb_pull+0x15/0x17
[951.142737]  [] pptp_rcv_core+0x126/0x19a [pptp]
[951.152725]  [] sk_receive_skb+0x69/0x105
[951.163558]  [] pptp_rcv+0xc8/0xdc [pptp]
[951.165092]  [] gre_rcv+0x62/0x75 [gre]
[951.165092]  [] ip_local_deliver_finish+0x150/0x1c1
[951.177599]  [] ? ip_local_deliver_finish+0x0/0x1c1
[951.177599]  [] NF_HOOK.clone.7+0x51/0x58
[951.177599]  [] ip_local_deliver+0x51/0x55
[951.177599]  [] ip_rcv_finish+0x31a/0x33e
[951.177599]  [] ? ip_rcv_finish+0x0/0x33e
[951.204898]  [] NF_HOOK.clone.7+0x51/0x58
[951.214651]  [] ip_rcv+0x21b/0x246

pptp_rcv_core() is a nice example of a function assuming everything it
needs is available in skb head.

Reported-by: Bradley Peterson 
Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

pptp: fix skb leak in pptp_xmit()

2011-10-19T06:39:43+00:00

In case we cant transmit skb, we must free it

Signed-off-by: Eric Dumazet 
CC: Dmitry Kozlov 
Signed-off-by: David S. Miller

net: Remove unneeded version.h includes from drivers/net/

2011-06-24T09:40:08+00:00

It was pointed out by 'make versioncheck' that some includes of
linux/version.h are not needed in drivers/net/.
This patch removes them.

Signed-off-by: Jesper Juhl 
Signed-off-by: David S. Miller

pptp: Use flowi4's daddr/saddr in pptp_xmit().

2011-05-04T03:41:42+00:00

Instead of rt->rt_{src,dst}

Signed-off-by: David S. Miller

ipv4: Make caller provide on-stack flow key to ip_route_output_ports().

2011-05-04T03:25:42+00:00

Signed-off-by: David S. Miller

ipv4: Create and use route lookup helpers.

2011-03-12T23:08:42+00:00

The idea here is this minimizes the number of places one has to edit
in order to make changes to how flows are defined and used.

Signed-off-by: David S. Miller

ipv4: Make output route lookup return rtable directly.

2011-03-02T22:31:35+00:00

Instead of on the stack.

Signed-off-by: David S. Miller

ipv4: Don't pre-seed hoplimit metric.

2010-12-13T06:08:17+00:00

Always go through a new ip4_dst_hoplimit() helper, just like ipv6.

This allowed several simplifications:

1) The interim dst_metric_hoplimit() can go as it's no longer
   userd.

2) The sysctl_ip_default_ttl entry no longer needs to use
   ipv4_doint_and_flush, since the sysctl is not cached in
   routing cache metrics any longer.

3) ipv4_doint_and_flush no longer needs to be exported and
   therefore can be marked static.

When ipv4_doint_and_flush_strategy was removed some time ago,
the external declaration in ip.h was mistakenly left around
so kill that off too.

We have to move the sysctl_ip_default_ttl declaration into
ipv4's route cache definition header net/route.h, because
currently net/ip.h (where the declaration lives now) has
a back dependency on net/route.h

Signed-off-by: David S. Miller

net: Abstract RTAX_HOPLIMIT metric accesses behind helper.

2010-12-13T05:35:57+00:00

Signed-off-by: David S. Miller

drivers/net: use vzalloc()

2010-11-28T06:53:38+00:00

Use vzalloc() and vzalloc_node() in net drivers

Signed-off-by: Eric Dumazet 
Acked-by: Jon Mason 
Signed-off-by: David S. Miller