linux-toradex.git/drivers/net/rionet.c, branch v4.4.144

rapidio/rionet: fix deadlock on SMP

2016-04-12T16:08:58+00:00

commit 36915976eca58f2eefa040ba8f9939672564df61 upstream.

Fix deadlocking during concurrent receive and transmit operations on SMP
platforms caused by the use of incorrect lock: on transmit 'tx_lock'
spinlock should be used instead of 'lock' which is used for receive
operation.

This fix is applicable to kernel versions starting from v2.15.

Signed-off-by: Aurelien Jacquiot 
Signed-off-by: Alexandre Bounine 
Cc: Matt Porter 
Cc: Andre van Herk 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

bus: subsys: update return type of ->remove_dev() to void

2015-08-06T00:08:14+00:00

Its return value is not used by the subsys core and nothing meaningful
can be done with it, even if we want to use it. The subsys device is
anyway getting removed.

Update prototype of ->remove_dev() to make its return type as void. Fix
all usage sites as well.

Signed-off-by: Viresh Kumar 
Signed-off-by: Greg Kroah-Hartman

net: get rid of SET_ETHTOOL_OPS

2014-05-13T21:43:20+00:00

net: get rid of SET_ETHTOOL_OPS

Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone.
This does that.

Mostly done via coccinelle script:
@@
struct ethtool_ops *ops;
struct net_device *dev;
@@
-       SET_ETHTOOL_OPS(dev, ops);
+       dev->ethtool_ops = ops;

Compile tested only, but I'd seriously wonder if this broke anything.

Suggested-by: Dave Miller 
Signed-off-by: Wilfried Klaebe 
Acked-by: Felipe Balbi 
Signed-off-by: David S. Miller

rapidio: rework device hierarchy and introduce mport class of devices

2014-04-07T23:36:07+00:00

This patch removes an artificial RapidIO bus root device and establishes
actual device hierarchy by providing reference to real parent devices.
It also introduces device class for RapidIO controller devices (on-chip
or an eternal bridge, known as "mport").

Existing implementation was sufficient for SoC-based platforms that have
a single RapidIO controller.  With introduction of devices using
multiple RapidIO controllers and PCIe-to-RapidIO bridges the old scheme
is very limiting or does not work at all.  The implemented changes allow
to properly reference platform's local RapidIO mport devices and provide
device details needed for upper layers.

This change to RapidIO device hierarchy does not break any known
existing kernel or user space interfaces.

Signed-off-by: Alexandre Bounine 
Cc: Matt Porter 
Cc: Li Yang 
Cc: Kumar Gala 
Cc: Andre van Herk 
Cc: Stef van Os 
Cc: Jerry Jacobs 
Cc: Arno Tiemersma 
Cc: Rob Landley 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rapidio/rionet: rework driver initialization and removal

2013-07-03T23:08:04+00:00

Rework probe/remove routines to prevent rionet driver from monopolizing
target RapidIO devices.  Fix conflict with modular RapidIO switch drivers.

Using one of RapidIO messaging channels rionet driver provides a service
layer common to all endpoint devices in a system's RapidIO network.  These
devices may also require their own specific device driver which will be
blocked from attaching to the target device by rionet (or block rionet if
loaded earlier).  To avoid conflict with device-specific drivers, the
rionet driver is reworked to be registered as a subsystem interface on the
RapidIO bus.

The reworked rio_remove_dev() and rionet_exit() routines also include
handling of individual rionet peer device removal which was not supported
before.

Signed-off-by: Alexandre Bounine 
Cc: Matt Porter 
Cc: Li Yang 
Cc: Kumar Gala 
Cc: "David S. Miller" 
Cc: Andre van Herk 
Cc: Micha Nelissen 
Cc: Stef van Os 
Cc: Jean Delvare 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ethtool: fix drvinfo strings set in drivers

2013-01-07T05:06:31+00:00

Use strlcpy where possible to ensure the string is \0 terminated.
Use always sizeof(string) instead of 32, ETHTOOL_BUSINFO_LEN
and custom defines.
Use snprintf instead of sprint.
Remove unnecessary inits of ->fw_version
Remove unnecessary inits of drvinfo struct.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

rapidio/rionet: rework to support multiple RIO master ports

2012-10-05T18:05:23+00:00

Make RIONET driver multi-net safe/capable by introducing per-net lists of
RapidIO network peers.  Rework registration of network adapters to support
all available RIO master port devices.

Signed-off-by: Alexandre Bounine 
Cc: Matt Porter 
Cc: Li Yang 
Cc: David S. Miller 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rapidio/rionet: fix multicast packet transmit logic

2012-10-05T18:05:19+00:00

Fix multicast packet transmit logic to account for repetitive transmission
of single skb:
- correct check for available buffers (this bug may produce NULL pointer
  crash dump in case of heavy traffic);
- update skb user count (incorrect user counter causes a warning dump from
  net_tx_action routine during multicast transfers in systems with three or
  more rionet participants).

Signed-off-by: Alexandre Bounine 
Cc: Matt Porter 
Cc: David S. Miller 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rionet: fix page allocation order of rionet_active

2012-04-02T03:17:16+00:00

rionet_active is allocated from the page allocator and the allocation
order is calculated on the assumption that the page size is 4KB, so it
wastes memory on more than 4K page systems.

Signed-off-by: Akinobu Mita 
Cc: Matt Porter 
Cc: Alexandre Bounine 
Cc: netdev@vger.kernel.org
Signed-off-by: David S. Miller

drivers/net: Remove alloc_etherdev error messages

2012-01-31T21:20:48+00:00

alloc_etherdev has a generic OOM/unable to alloc message.
Remove the duplicative messages after alloc_etherdev calls.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller