linux-toradex.git/drivers/net/sc92031.c, branch v2.6.27.17

sc92031: remove bogus unlikely()

2008-05-31T02:07:17+00:00

Commit 5a0a92e67b5009a71e011658da04fb92dad8961f mentions len < ETH_ZLEN
is true for ARP packets. This obviously is not unlikely.

Signed-off-by: Cesar Eduardo Barros 
Signed-off-by: Jeff Garzik

[SC92031] Using padto turned driver into an IPv6-only interface

2008-05-22T10:19:18+00:00

IPv4 would work with this driver only with static arp table entries,
the patch  reverts a padto introduced in

 commit 26a17b7bbb36a8552d531bc1ad08472fb5aa3007
 sc92031: start transmit return value bugfix

The padto does not work because the driver code evaluates `len' later on and
there are cases where skb->len is not updated accordingly.

This was observed with ARP frames (skb->len = 42 bytes, !skb_cloned(),
skb_tailroom = 84 bytes). Then in skb_pad(), the first condition is true, where
skb->len is not updated. As a consequence, the driver uses 42 bytes instead of
the 60 bytes, and the ARP frame never makes it onto the wire.

Signed-off-by: Gerrit Renker 
Signed-off-by: Jeff Garzik

sc92031: use netdev_alloc_skb

2008-04-17T00:41:35+00:00

Use netdev_alloc_skb since it handles any NUMA node memory localtion issues
and sets skb->dev. Since device driver was not setting skb->dev, I bet
filter rules based on device would not work.

Signed-off-by: Stephen Hemminger 
Signed-off-by: Jeff Garzik

sc92031: start transmit return value bugfix

2008-04-17T00:41:35+00:00

Any negative return value from start_xmit is interpreted as NETDEV_TX_LOCK
which is not what this driver wants. It should return 0 (NETDEV_TX_OK)
when it consumes a packet.

Also, use skb_padto() as the generic way to pad small frames.

Signed-off-by: Stephen Hemminger 
Signed-off-by: Jeff Garzik

sc92031: use net_device stats

2008-04-17T00:41:34+00:00

Statistics structure is available for use in net_device structure.
Compile tested only.

Signed-off-by: Stephen Hemminger 
Signed-off-by: Jeff Garzik

sc92031: sysfs link missing

2008-04-12T08:39:20+00:00

Add missing sysfs device association. Compile tested only -ENOHW.

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=10380

Signed-off-by: Stephen Hemminger 
Cc: Cesar Eduardo Barros 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Jeff Garzik

[netdrvr] Stop using legacy hooks ->self_test_count, ->get_stats_count

2007-10-10T23:51:45+00:00

These have been superceded by the new ->get_sset_count() hook.

Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller

[ETHTOOL] Provide default behaviors for a few ethtool sub-ioctls

2007-10-10T23:51:17+00:00

For the operations
	get-tx-csum
	get-sg
	get-tso
	get-ufo
the default ethtool_op_xxx behavior is fine for all drivers, so we
permit op==NULL to imply the default behavior.

This provides a more uniform behavior across all drivers, eliminating
ethtool(8) "ioctl not supported" errors on older drivers that had
not been updated for the latest sub-ioctls.

The ethtool_op_xxx() functions are left exported, in case anyone
wishes to call them directly from a driver-private implementation --
a not-uncommon case.  Should an ethtool_op_xxx() helper remain unused
for a while, except by net/core/ethtool.c, we can un-export it at a
later date.

[ Resolved conflicts with set/get value ethtool patch... -DaveM ]

Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller

[NET]: ethtool_perm_addr only has one implementation

2007-07-31T21:00:29+00:00

All drivers implement ethtool get_perm_addr the same way -- by calling
the generic function.  So we can inline the generic function into the
caller and avoid going through the drivers.

Signed-off-by: Matthew Wilcox 
Signed-off-by: David S. Miller

[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans

2007-04-26T05:24:30+00:00

One less thing for drivers writers to worry about.

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller