linux-toradex.git/drivers/net/sis900.c, branch v2.6.27.48

[netdrvr] Trim trailing whitespace for several drivers

2008-05-13T05:41:58+00:00

Signed-off-by: Jeff Garzik

drivers/net: Add missing "space"

2008-01-28T23:03:59+00:00

Signed-off-by: Joe Perches 
Signed-off-by: Jeff Garzik

[NET]: Introduce and use print_mac() and DECLARE_MAC_BUF()

2007-10-10T23:51:42+00:00

This is nicer than the MAC_FMT stuff.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

[NET] drivers/net: statistics cleanup #1 -- save memory and shrink code

2007-10-10T23:51:16+00:00

We now have struct net_device_stats embedded in struct net_device,
and the default ->get_stats() hook does the obvious thing for us.

Run through drivers/net/* and remove the driver-local storage of
statistics, and driver-local ->get_stats() hook where applicable.

This was just the low-hanging fruit in drivers/net; plenty more drivers
remain to be updated.

[ Resolved conflicts with napi_struct changes and fix sunqe build
  regression... -DaveM ]

Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller

[NET]: Nuke SET_MODULE_OWNER macro.

2007-10-10T23:51:13+00:00

It's been a useless no-op for long enough in 2.6 so I figured it's time to
remove it.  The number of people that could object because they're
maintaining unified 2.4 and 2.6 drivers is probably rather small.

[ Handled drivers added by netdev tree and some missed IRDA cases... -DaveM ]

Signed-off-by: Ralf Baechle 
Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller

sis900_mii_probe() must be __devinit

2007-07-10T16:24:42+00:00

This patch fixes the following section mismatch:

<--  snip  -->

...
  MODPOST vmlinux
WARNING: drivers/built-in.o(.text+0x298170): Section mismatch: reference to .init.text:sis900_mii_probe (between 'sis900_probe' and 'sis900_default_phy')
...

<--  snip  -->

Signed-off-by: Adrian Bunk 
Signed-off-by: Jeff Garzik

sis900: Allocate rx replacement buffer before rx operation

2007-04-28T00:16:41+00:00

Just found a hole in my last patch.  It was reported to me that shortly after we
integrated this patch.  The report was of an oops that took place inside of
netif_rx when using the sis900 driver.  Looking at my origional patch I noted
that there was a spot between the new skb_alloc and the refill_rx_ring label
where skb got reassigned to the pointer currently held in the rx_ring for the
purposes of receiveing the frame.  The result of this is however that the buffer
that gets passed to netif_rx (if it is called), then gets placed right back into
the rx_ring.  So if you receive frames fast enough the skb being processed by
the network stack can get corrupted.  The reporter is testing out the fix I've
written for this below (I'm not near my hardware at the moment to test myself),
but I wanted to post it for review ASAP.  I'll post test results when I hear
them, but I think this is a pretty straightforward fix.  It just uses a separate
pointer to do the rx operation, so that we don't improperly reassign the pointer
that we use to refill the rx ring.

Signed-off-by: Neil Horman 
Signed-off-by: Jeff Garzik

[ETH]: Make eth_type_trans set skb->dev like the other *_type_trans

2007-04-26T05:24:30+00:00

One less thing for drivers writers to worry about.

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

sis900: Allocate rx replacement buffer before rx operation

2007-04-24T16:43:07+00:00

	The sis900 driver appears to have a bug in which the receive routine
passes the skbuff holding the received frame to the network stack before
refilling the buffer in the rx ring.  If a new skbuff cannot be allocated, the
driver simply leaves a hole in the rx ring, which causes the driver to stop
receiving frames and become non-recoverable without an rmmod/insmod according to
reporters.  This patch reverses that order, attempting to allocate a replacement
buffer first, and receiving the new frame only if one can be allocated.  If no
skbuff can be allocated, the current skbuf in the rx ring is recycled, dropping
the current frame, but keeping the NIC operational.

Signed-off-by: Neil Horman 
Signed-off-by: Jeff Garzik

sis900 warning fixes

2007-03-06T11:14:54+00:00

drivers/net/sis900.c: In function 'sis900_reset_phy':
drivers/net/sis900.c:972: warning: 'status' may be used uninitialized in this function
drivers/net/sis900.c: In function 'sis900_check_mode':
drivers/net/sis900.c:1431: warning: 'status' may be used uninitialized in this function
drivers/net/sis900.c: In function 'sis900_timer':
drivers/net/sis900.c:1467: warning: 'status' may be used uninitialized in this function

Signed-off-by: Andrew Morton 
Signed-off-by: Jeff Garzik