linux-toradex.git/drivers/net/skge.c, branch v2.6.32-rc3

skge: use unique IRQ name

2009-10-01T22:14:54+00:00

Most network drivers request their IRQ when the interface is activated.
skge does it in ->probe() instead, because it can work with two-port
cards where the two net_devices use the same IRQ. This works fine most
of the time, except in some situations when the interface gets renamed.
Consider this example:

1. modprobe skge
   The card is detected as eth0 and requests IRQ 17. Directory
   /proc/irq/17/eth0 is created.
2. There is an udev rule which says this interface should be called
   eth1, so udev renames eth0 -> eth1.
3. modprobe 8139too
   The Realtek card is detected as eth0. It will be using IRQ 17 too.
4. ip link set eth0 up
   Now 8139too requests IRQ 17.

The result is:
WARNING: at fs/proc/generic.c:590 proc_register ...
proc_dir_entry '17/eth0' already registered
...
And "ls /proc/irq/17" shows two subdirectories, both called eth0.

Fix it by using a unique name for skge's IRQ, based on the PCI address.
The naming from the example then looks like this:
$ grep skge /proc/interrupts
 17:        169   IO-APIC-fasteoi   skge@pci:0000:00:0a.0, eth0

irqbalance daemon will have to be taught to recognize "skge@" as an
Ethernet interrupt. This will be a one-liner addition in classify.c. I
will send a patch to irqbalance if this change is accepted.

Signed-off-by: Michal Schmidt 
Acked-by: Stephen Hemminger 
Signed-off-by: David S. Miller

skge: Make sure both ports initialize correctly

2009-10-01T03:03:18+00:00

If allocation of the second ports fails, make sure that hw->ports
 is not 2 otherwise we'll crash trying to access the second port.

This fix is copied from a similar fix in the sky2 driver (ca519274...),
but is untested, as I don't have a skge card.

Signed-off-by: Mike McCormack 
Acked-by: Stephen Hemminger 
Signed-off-by: David S. Miller

trivial: remove unnecessary semicolons

2009-09-21T13:14:58+00:00

Signed-off-by: Joe Perches 
Signed-off-by: Jiri Kosina

netdev: Remove redundant checks for CAP_NET_ADMIN in MDIO implementations

2009-09-04T03:02:11+00:00

dev_ioctl() already checks capable(CAP_NET_ADMIN) before calling the
driver's implementation of MDIO ioctls.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

netdev: convert bulk of drivers to netdev_tx_t

2009-09-01T08:14:07+00:00

In a couple of cases collapse some extra code like:
   int retval = NETDEV_TX_OK;
   ...
   return retval;
into
   return NETDEV_TX_OK;

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

skge: Enable WoL by default if supported

2009-07-22T18:24:26+00:00

If skge hardware is capable of waking up the system from sleep,
enable magic packet WoL during driver initialisation.

This makes WoL work without calling 'ethtool -s ethX wol g'
for each adapter.

Signed-off-by: Rafael J. Wysocki 
Tested-by: Michael Guntsche 
Acked-by: Stephen Hemminger 
Signed-off-by: David S. Miller

net: dont update dev->trans_start

2009-05-29T08:46:27+00:00

Second round of drivers for Gb cards (and NIU one I forgot in the 10GB round)

Now that core network takes care of trans_start updates, dont do it
in drivers themselves, if possible. Drivers can avoid one cache miss
(on dev->trans_start) in their start_xmit() handler.

Exceptions are NETIF_F_LLTX drivers

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

skge: fix occasional BUG during MTU change

2009-04-14T22:16:55+00:00

The BUG_ON(skge->tx_ring.to_use != skge->tx_ring.to_clean) in skge_up()
was sometimes observed when setting MTU.

skge_down() disables the TX queue, but then reenables it by mistake via
skge_tx_clean().
Fix it by moving the waking of the queue from skge_tx_clean() to the
other caller. And to make sure start_xmit is not in progress on another
CPU, skge_down() should call netif_tx_disable().

The bug was reported to me by Jiri Jilek whose Debian system sometimes
failed to boot. He tested the patch and the bug did not happen anymore.

Signed-off-by: Michal Schmidt 
Acked-by: Stephen Hemminger 
Signed-off-by: David S. Miller

dma-mapping: replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)

2009-04-07T15:31:11+00:00

Replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)

Signed-off-by: Yang Hongyang
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

dma-mapping: replace all DMA_64BIT_MASK macro with DMA_BIT_MASK(64)

2009-04-07T15:31:10+00:00

Replace all DMA_64BIT_MASK macro with DMA_BIT_MASK(64)

Signed-off-by: Yang Hongyang
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds