linux-toradex.git/drivers/net/smc911x.c, branch tegra-9.12.13 Linux kernel for Apalis and Colibri modules net: variables reach -1, but 0 tested 2009-02-03T05:39:02+00:00 Roel Kluin roel.kluin@gmail.com 2009-02-03T05:39:02+00:00 46578a6913e6f5e69229561736b94c18c2e88ae4 while (timeout--) { ... } timeout becomes -1 if the loop isn't ended otherwise, not 0. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
while (timeout--) { ... }

timeout becomes -1 if the loop isn't ended otherwise, not 0.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/smc911x.c: smc911x_drv_probe() cleanup 2008-12-04T05:05:49+00:00 Andrew Morton akpm@linux-foundation.org 2008-12-01T12:24:46+00:00 a316084c2f18fd5371f81cfcfc8348a71c4a6fe8 Save an ugly ifdef. Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net> 
Save an ugly ifdef.

Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6 2008-12-03T03:50:27+00:00 David S. Miller davem@davemloft.net 2008-12-03T03:50:27+00:00 aa2ba5f1082dc705745899584aac8416d710c056 Conflicts: drivers/net/ixgbe/ixgbe_main.c drivers/net/smc91x.c 
Conflicts:

	drivers/net/ixgbe/ixgbe_main.c
	drivers/net/smc91x.c
section errors in smc911x/smc91x 2008-11-30T18:03:37+00:00 Al Viro viro@ftp.linux.org.uk 2008-11-22T17:36:14+00:00 f57628d76bd201a444ca822f3622522a44acbf60 a) ->probe() can be __devinit; no need to put it into .text b) calling __init stuff from it, OTOH, is wrong c) ->remove() is __devexit fodder Acked-by: rmk+kernel@arm.linux.org.uk Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
a) ->probe() can be __devinit; no need to put it into .text
 b) calling __init stuff from it, OTOH, is wrong
 c) ->remove() is __devexit fodder

Acked-by: rmk+kernel@arm.linux.org.uk
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6 2008-11-21T00:44:00+00:00 David S. Miller davem@davemloft.net 2008-11-21T00:44:00+00:00 6ab33d51713d6d60c7677c0d020910a8cb37e513 Conflicts: drivers/net/ixgbe/ixgbe_main.c include/net/mac80211.h net/phonet/af_phonet.c 
Conflicts:

	drivers/net/ixgbe/ixgbe_main.c
	include/net/mac80211.h
	net/phonet/af_phonet.c
smc911x: Fix printf format typo in smc911x driver. 2008-11-20T09:56:08+00:00 Vernon Sauder VernonInHand@gmail.com 2008-11-20T09:56:08+00:00 eafdcb433f854c8cb06747a80fa3df7c72147be6 Signed-off-by: Vernon Sauder <VernonInHand@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Vernon Sauder <VernonInHand@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6 2008-11-19T07:38:23+00:00 David S. Miller davem@davemloft.net 2008-11-19T07:38:23+00:00 198d6ba4d7f48c94f990f4604f0b3d73925e0ded Conflicts: drivers/isdn/i4l/isdn_net.c fs/cifs/connect.c 
Conflicts:

	drivers/isdn/i4l/isdn_net.c
	fs/cifs/connect.c
[netdrvr] smc911x: fix for driver resume (and compilation warning) 2008-11-11T08:53:15+00:00 Dasgupta, Romit romit@ti.com 2008-11-06T10:16:18+00:00 347c8d83cd9f546a8357e1ab12fa6867707975d8 I am trying out suspend, resume on an OMAP3 based board. What I see during resume is that the SMC911x driver resume routing gets stuck after trying to transmit the packet out of the controller. Some debug messages below: --> smc911x_drv_resume eth0: --> smc911x_reset eth0: smc911x_reset timeout waiting for PM restore eth0: --> smc911x_enable eth0: --> smc911x_phy_configure() eth0: --> smc911x_phy_reset() eth0: phy caps=0x782d eth0: phy advertised caps=0x0de1 eth0: --> smc911x_phy_check_media smc911x_phy_read: phyaddr=0x1, phyreg=0x01, phydata=0x7809 smc911x_phy_read: phyaddr=0x1, phyreg=0x01, phydata=0x7809 eth0: link down Restarting tasks ... eth0: --> smc911x_hard_start_xmit eth0: --> smc911x_hardware_send_pkt eth0: --> smc911x_hard_start_xmit eth0: --> smc911x_hardware_send_pkt eth0: --> smc911x_hard_start_xmit eth0: --> smc911x_hardware_send_pkt nfs: server 172.24.190.217 not responding, still trying nfs: server 172.24.190.217 not responding, still trying The following change makes it work fine: (The change within smc911x_drv_probe function was to get rid of a compilation warning). Signed-off-by: Romit Dasgupta <romit@ti.com> Signed-off-by: Jeff Garzik <jgarzik@redhat.com> 
I am trying out suspend, resume on an OMAP3 based board. What I see
during resume is that the SMC911x driver resume routing gets stuck
after trying to transmit the packet out of the controller. Some debug
messages below:

--> smc911x_drv_resume
eth0: --> smc911x_reset
eth0: smc911x_reset timeout waiting for PM restore
eth0: --> smc911x_enable
eth0: --> smc911x_phy_configure()
eth0: --> smc911x_phy_reset()
eth0: phy caps=0x782d
eth0: phy advertised caps=0x0de1
eth0: --> smc911x_phy_check_media
smc911x_phy_read: phyaddr=0x1, phyreg=0x01, phydata=0x7809
smc911x_phy_read: phyaddr=0x1, phyreg=0x01, phydata=0x7809
eth0: link down
Restarting tasks ... eth0: --> smc911x_hard_start_xmit
eth0: --> smc911x_hardware_send_pkt
eth0: --> smc911x_hard_start_xmit
eth0: --> smc911x_hardware_send_pkt
eth0: --> smc911x_hard_start_xmit
eth0: --> smc911x_hardware_send_pkt
nfs: server 172.24.190.217 not responding, still trying
nfs: server 172.24.190.217 not responding, still trying

The following change makes it work fine: (The change within
smc911x_drv_probe function was to get rid of a compilation warning).

Signed-off-by: Romit Dasgupta <romit@ti.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6 2008-11-07T06:43:03+00:00 David S. Miller davem@davemloft.net 2008-11-07T06:43:03+00:00 9eeda9abd1faf489f3df9a1f557975f4c8650363 Conflicts: drivers/net/wireless/ath5k/base.c net/8021q/vlan_core.c 
Conflicts:

	drivers/net/wireless/ath5k/base.c
	net/8021q/vlan_core.c
drivers/net: Kill now superfluous ->last_rx stores. 2008-11-04T05:11:17+00:00 David S. Miller davem@davemloft.net 2008-11-04T05:11:17+00:00 babcda74e9d96bb58fd9c6c5112dbdbff169e695 The generic packet receive code takes care of setting netdev->last_rx when necessary, for the sake of the bonding ARP monitor. Drivers need not do it any more. Some cases had to be skipped over because the drivers were making use of the ->last_rx value themselves. Signed-off-by: David S. Miller <davem@davemloft.net> 
The generic packet receive code takes care of setting
netdev->last_rx when necessary, for the sake of the
bonding ARP monitor.

Drivers need not do it any more.

Some cases had to be skipped over because the drivers
were making use of the ->last_rx value themselves.

Signed-off-by: David S. Miller <davem@davemloft.net>