linux-toradex.git/drivers/net/smsc9420.c, branch v2.6.32.45 Linux kernel for Apalis and Colibri modules smsc9420: prevent BUG() if ethtool is called with interface down 2009-11-30T07:14:45+00:00 Steve Glendinning steve.glendinning@smsc.com 2009-11-30T07:14:45+00:00 6c53b1b15e222244358d3cbbefd2a13920faa352 This patch fixes a null pointer dereference BUG() if ethtool is used on an smsc9420 interface while it is down, because the phy_dev is only allocated while the interface is up. Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
This patch fixes a null pointer dereference BUG() if ethtool is used on
an smsc9420 interface while it is down, because the phy_dev is only
allocated while the interface is up.

Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers: Kill now superfluous ->last_rx stores 2009-09-03T06:07:36+00:00 Eric Dumazet eric.dumazet@gmail.com 2009-08-31T06:34:50+00:00 451f14439847db302e5104c44458b2dbb4b1829d The generic packet receive code takes care of setting netdev->last_rx when necessary, for the sake of the bonding ARP monitor. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Acked-by: Neil Horman <nhorman@txudriver.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
The generic packet receive code takes care of setting
netdev->last_rx when necessary, for the sake of the
bonding ARP monitor.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Neil Horman <nhorman@txudriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
netdev: convert bulk of drivers to netdev_tx_t 2009-09-01T08:14:07+00:00 Stephen Hemminger shemminger@vyatta.com 2009-08-31T19:50:58+00:00 61357325f377889a1daffa14962d705dc814dd0e In a couple of cases collapse some extra code like: int retval = NETDEV_TX_OK; ... return retval; into return NETDEV_TX_OK; Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
In a couple of cases collapse some extra code like:
   int retval = NETDEV_TX_OK;
   ...
   return retval;
into
   return NETDEV_TX_OK;

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
dma-mapping: replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32) 2009-04-07T15:31:11+00:00 Yang Hongyang yanghy@cn.fujitsu.com 2009-04-07T02:01:15+00:00 284901a90a9e0b812ca3f5f852cbbfb60d10249d Replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32) Signed-off-by: Yang Hongyang<yanghy@cn.fujitsu.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
Replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)

Signed-off-by: Yang Hongyang<yanghy@cn.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
smsc9420: fix big endian rx checksum offload 2009-03-20T08:14:53+00:00 Steve Glendinning steve.glendinning@smsc.com 2009-03-20T08:14:53+00:00 cd7a3b75ba7af7d14a264fe3d414fcc74307f748 The cpu_to_le16 here looks suspicious to me, I don't think we need it because put_unaligned_le16 also does this. I don't currently have any big endian hardware with a PCI bus available to test on, so I haven't been able to verify this. Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
The cpu_to_le16 here looks suspicious to me, I don't think we need it
because put_unaligned_le16 also does this.

I don't currently have any big endian hardware with a PCI bus available
to test on, so I haven't been able to verify this.

Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Merge branch 'master' of /home/davem/src/GIT/linux-2.6/ 2009-02-24T11:50:29+00:00 David S. Miller davem@davemloft.net 2009-02-24T11:50:29+00:00 e70049b9e74267dd47e1ffa62302073487afcb48 






smsc9420: handle magic field of ethtool_eeprom
2009-02-20T08:38:51+00:00

Steve Glendinning
steve.glendinning@smsc.com

2009-02-15T22:55:01+00:00

196b7e1b9cca9e187bb61fa7d60f04f4ab2c0592

ethtool.h says the driver should set the magic field in get_eeprom and
verify it in set_eeprom.  This patch adds this functionality using an
arbitary driver-specific magic value constant (0x9420).

Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>





ethtool.h says the driver should set the magic field in get_eeprom and
verify it in set_eeprom.  This patch adds this functionality using an
arbitary driver-specific magic value constant (0x9420).

Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>







smsc9420: fix another postfixed timeout
2009-02-20T08:35:08+00:00

Steve Glendinning
steve.glendinning@smsc.com

2009-02-16T07:46:06+00:00

9df8f4e3ee760c14211a5f484e9ee4f0bc0c566b

Roel Kluin recently fixed several instances where variables reach -1,
but 0 is tested afterwards.  This patch fixes another, so the timeout
will be correctly detected and a warning printed.

Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>





Roel Kluin recently fixed several instances where variables reach -1,
but 0 is tested afterwards.  This patch fixes another, so the timeout
will be correctly detected and a warning printed.

Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>







Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2009-02-03T08:15:35+00:00

David S. Miller
davem@davemloft.net

2009-02-03T08:15:35+00:00

b3ff29d2ccfe3af065a9b393699a8fbf2abd1b15

Conflicts:
	drivers/net/Kconfig





Conflicts:
	drivers/net/Kconfig







net: variables reach -1, but 0 tested
2009-02-03T05:39:02+00:00

Roel Kluin
roel.kluin@gmail.com

2009-02-03T05:39:02+00:00

46578a6913e6f5e69229561736b94c18c2e88ae4

while (timeout--) { ... }

timeout becomes -1 if the loop isn't ended otherwise, not 0.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>





while (timeout--) { ... }

timeout becomes -1 if the loop isn't ended otherwise, not 0.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>