linux-toradex.git/drivers/net/tun.c, branch v2.6.25.12

net: check for underlength tap writes

2008-04-13T01:49:30+00:00

If the user gives a packet under 14 bytes, we'll end up reading off the end
of the skb (not oopsing, just reading off the end).

Signed-off-by: Rusty Russell 
Acked-by: Max Krasnyanskiy 
Signed-off-by: David S. Miller

net: make struct tun_struct private to tun.c

2008-04-13T01:48:58+00:00

There's no reason for this to be in the header, and it just hurts
recompile time.

Signed-off-by: Rusty Russell 
Acked-by: Max Krasnyanskiy 
Signed-off-by: David S. Miller

[TUN]: Fix RTNL-locking in tun/tap driver

2008-02-29T20:26:21+00:00

Current tun/tap driver sets also net device's hw address when asked to
change character device's hw address. This is a good idea, but it
misses RTLN-locking, resulting following error message in 2.6.25-rc3's
inetdev_event() function:

RTNL: assertion failed at net/ipv4/devinet.c (1050)

Attached patch fixes this problem.

Signed-off-by: Kim B. Heino 
Signed-off-by: David S. Miller

tun: impossible to deassert IFF_ONE_QUEUE or IFF_NO_PI

2008-02-05T11:05:07+00:00

From: "Nathaniel Filardo" 

Taken from http://bugzilla.kernel.org/show_bug.cgi?id=9806

The TUN/TAP driver only permits one-way transitions of IFF_NO_PI or
IFF_ONE_QUEUE during the lifetime of a tap/tun interface.  Note that
tun_set_iff contains

 541         if (ifr->ifr_flags & IFF_NO_PI)
 542                 tun->flags |= TUN_NO_PI;
 543 
 544         if (ifr->ifr_flags & IFF_ONE_QUEUE)
 545                 tun->flags |= TUN_ONE_QUEUE;

This is easily fixed by adding else branches which clear these bits.

Steps to reproduce:

This is easily reproduced by setting an interface persistant using tunctl then
attempting to open it as IFF_TAP or IFF_TUN, without asserting the IFF_NO_PI
flag.  The ioctl() will succeed and the ifr.flags word is not modified, but the
interface remains in IFF_NO_PI mode (as it was set by tunctl).

Acked-by: Maxim Krasnyansky 
Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller

annotate tun

2008-01-28T23:07:57+00:00

Signed-off-by: Al Viro 
Signed-off-by: Jeff Garzik

[TUN]: Use iov_length()

2008-01-28T22:54:34+00:00

Use iov_length() instead of tun's homemade iov_total().

Signed-off-by: Akinobu Mita 
Signed-off-by: David S. Miller

[TUNTAP]: Fix wrong debug message.

2007-12-27T03:36:34+00:00

This is a trivial fix of debug message.
When a persist flag is set, the message should say "enabled".

Signed-off-by: Toyo Abe 
Signed-off-by: David S. Miller

[NET]: Introduce and use print_mac() and DECLARE_MAC_BUF()

2007-10-10T23:51:42+00:00

This is nicer than the MAC_FMT stuff.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

[TAP]: Configurable interface MTU.

2007-10-10T23:51:19+00:00

Signed-off-by: David S. Miller

[NET] drivers/net: statistics cleanup #1 -- save memory and shrink code

2007-10-10T23:51:16+00:00

We now have struct net_device_stats embedded in struct net_device,
and the default ->get_stats() hook does the obvious thing for us.

Run through drivers/net/* and remove the driver-local storage of
statistics, and driver-local ->get_stats() hook where applicable.

This was just the low-hanging fruit in drivers/net; plenty more drivers
remain to be updated.

[ Resolved conflicts with napi_struct changes and fix sunqe build
  regression... -DaveM ]

Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller