linux-toradex.git/drivers/net/ucc_geth_ethtool.c, branch tegra-9.12.13

net/ucc_geth: Fix oops in uec_get_ethtool_stats()

2008-11-14T23:18:17+00:00

p_{tx,rx}_fw_statistics_pram are special: they're available only when
a device is open. If the device is closed, we should just fill the data
with zeroes.

Fixes the following oops:

root@b1:~# ifconfig eth1 down
root@b1:~# ethtool -S eth1
Unable to handle kernel paging request for data at address 0x00000000
Faulting instruction address: 0xc01e1dcc
Oops: Kernel access of bad area, sig: 11 [#1]
[...]
NIP [c01e1dcc] uec_get_ethtool_stats+0x98/0x124
LR [c0287cc8] ethtool_get_stats+0xfc/0x23c
Call Trace:
[cfaadde0] [c0287ca8] ethtool_get_stats+0xdc/0x23c (unreliable)
[cfaade20] [c0288340] dev_ethtool+0x2fc/0x588
[cfaade50] [c0285648] dev_ioctl+0x290/0x33c
[cfaadea0] [c0272238] sock_ioctl+0x80/0x2ec
[cfaadec0] [c00b5ae4] vfs_ioctl+0x40/0xc0
[cfaadee0] [c00b5fa8] do_vfs_ioctl+0x78/0x20c
[cfaadf10] [c00b617c] sys_ioctl+0x40/0x74
[cfaadf40] [c00142d8] ret_from_syscall+0x0/0x38
[...]
---[ end trace b941007b2dfb9759 ]---
Segmentation fault

p.s. While at it, also remove u64 casts, they aren't needed.

Signed-off-by: Anton Vorontsov 
Signed-off-by: Jeff Garzik

drivers: remove duplicated #include

2008-11-04T16:18:19+00:00

Signed-off-by: Jianjun Kong 
Signed-off-by: Linus Torvalds

Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6

2008-06-10T09:22:26+00:00

Conflicts:

	drivers/net/tg3.c
	drivers/net/wireless/rt2x00/rt2x00dev.c
	net/mac80211/ieee80211_i.h

ucc_geth_ethtool: Add a missing HW stats counter

2008-05-31T02:07:24+00:00

Signed-off-by: Joakim Tjernlund 
Signed-off-by: Li Yang 
Signed-off-by: Jeff Garzik

ucc_geth_ethtool: Fix typo

2008-05-31T02:07:23+00:00

Signed-off-by: Joakim Tjernlund 
Signed-off-by: Li Yang 
Signed-off-by: Jeff Garzik

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6

2008-05-15T07:34:44+00:00

Conflicts:

	drivers/net/wireless/iwlwifi/iwl-4965-rs.c
	drivers/net/wireless/rt2x00/rt61pci.c

[netdrvr] Trim trailing whitespace for several drivers

2008-05-13T05:41:58+00:00

Signed-off-by: Jeff Garzik

ucc_geth: Fix a bunch of sparse warnings

2008-05-06T16:02:08+00:00

ucc_geth didn't have anything marked as __iomem.  It was also inconsistent
with its use of in/out accessors (using them sometimes, not using them other
times).  Cleaning this up cuts the warnings down from hundreds to just over a
dozen.

Signed-off-by: Andy Fleming 
Signed-off-by: Jeff Garzik

[netdrvr] Stop using legacy hooks ->self_test_count, ->get_stats_count

2007-10-10T23:51:45+00:00

These have been superceded by the new ->get_sset_count() hook.

Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller

[ETHTOOL] Provide default behaviors for a few ethtool sub-ioctls

2007-10-10T23:51:17+00:00

For the operations
	get-tx-csum
	get-sg
	get-tso
	get-ufo
the default ethtool_op_xxx behavior is fine for all drivers, so we
permit op==NULL to imply the default behavior.

This provides a more uniform behavior across all drivers, eliminating
ethtool(8) "ioctl not supported" errors on older drivers that had
not been updated for the latest sub-ioctls.

The ethtool_op_xxx() functions are left exported, in case anyone
wishes to call them directly from a driver-private implementation --
a not-uncommon case.  Should an ethtool_op_xxx() helper remain unused
for a while, except by net/core/ethtool.c, we can un-export it at a
later date.

[ Resolved conflicts with set/get value ethtool patch... -DaveM ]

Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller