linux-toradex.git/drivers/net/usb/asix_common.c, branch v3.18.13

usbnet: Fix tx_bytes statistic running backward in cdc_ncm

2015-04-27T21:13:42+00:00

[ Upstream commit 7a1e890e2168e33fb62d84528e996b8b4b478fea ]

cdc_ncm disagrees with usbnet about how much framing overhead should
be counted in the tx_bytes statistics, and tries 'fix' this by
decrementing tx_bytes on the transmit path.  But statistics must never
be decremented except due to roll-over; this will thoroughly confuse
user-space.  Also, tx_bytes is only incremented by usbnet in the
completion path.

Fix this by requiring drivers that set FLAG_MULTI_FRAME to set a
tx_bytes delta along with the tx_packets count.

Fixes: beeecd42c3b4 ("net: cdc_ncm/cdc_mbim: adding NCM protocol statistics")
Signed-off-by: Ben Hutchings 
Signed-off-by: Bjørn Mork 
Signed-off-by: Sasha Levin

usbnet: Fix tx_packets stat for FLAG_MULTI_FRAME drivers

2015-04-27T21:13:41+00:00

[ Upstream commit 1e9e39f4a29857a396ac7b669d109f697f66695e ]

Currently the usbnet core does not update the tx_packets statistic for
drivers with FLAG_MULTI_PACKET and there is no hook in the TX
completion path where they could do this.

cdc_ncm and dependent drivers are bumping tx_packets stat on the
transmit path while asix and sr9800 aren't updating it at all.

Add a packet count in struct skb_data so these drivers can fill it
in, initialise it to 1 for other drivers, and add the packet count
to the tx_packets statistic on completion.

Signed-off-by: Ben Hutchings 
Tested-by: Bjørn Mork 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

usb: Fix FSF address in file headers

2013-12-06T17:37:55+00:00

Several files refer to an old address for the Free Software Foundation
in the file header comment.  Resolve by replacing the address with
the URL  so that we do not have to keep
updating the header comments anytime the address changes.

CC: Oliver Neukum 
CC: Steve Glendinning 
CC: Oliver Neukum 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

asix: fix BUG in receive path when lowering MTU

2013-05-03T20:10:33+00:00

There is bug in the receive path of the asix driver at the time a
packet is received larger than MTU size and DF bit set:

 BUG: unable to handle kernel paging request at 0000004000000001
 IP: [] skb_release_head_state+0x2d/0xd2
 ...
 Call Trace:
  
  [] ? skb_release_all+0x9/0x1e
  [] ? __kfree_skb+0x9/0x6f
  [] ? asix_rx_fixup_internal+0xff/0x1ae [asix]
  [] ? usbnet_bh+0x4f/0x226 [usbnet]
  ...

It is easily reproducable by setting an MTU of 512 e. g. and sending
something like

  ping -s 1472 -c 1 -M do $SELF

from another box.

And this is because the rx->ax_skb is freed on error, but rx->ax_skb
is not reset, and the size is not reset to zero in this case.

And since the skb is added again to the usbnet->done skb queue it is
accessing already freed memory, resulting in the BUG when freeing a
2nd time.  I therefore think the value 0x0000004000000001 show in the
trace is more or less random data.

Signed-off-by: Holger Eitzenberger 
Signed-off-by: David S. Miller

net: asix: handle packets crossing URB boundaries

2013-01-18T19:13:29+00:00

ASIX AX88772B started to pack data even more tightly. Packets and the ASIX packet
header may now cross URB boundaries. To handle this we have to introduce
some state between individual calls to asix_rx_fixup().

Signed-off-by: Lucas Stach 
Signed-off-by: David S. Miller

ethtool: fix drvinfo strings set in drivers

2013-01-07T05:06:31+00:00

Use strlcpy where possible to ensure the string is \0 terminated.
Use always sizeof(string) instead of 32, ETHTOOL_BUSINFO_LEN
and custom defines.
Use snprintf instead of sprint.
Remove unnecessary inits of ->fw_version
Remove unnecessary inits of drvinfo struct.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

usbnet: asix: apply introduced usb command APIs

2012-10-26T07:36:50+00:00

Acked-by: Oliver Neukum 
Signed-off-by: Ming Lei 
Signed-off-by: David S. Miller

asix: Add support for programming the EEPROM

2012-07-19T17:48:07+00:00

This patch adds the asix_set_eeprom() function to provide support for
programming the configuration EEPROM via ethtool.

Signed-off-by: Christian Riesch 
Signed-off-by: David S. Miller

asix: Rework reading from EEPROM

2012-07-19T17:48:07+00:00

The current code for reading the EEPROM via ethtool in the asix
driver has a few issues. It cannot handle odd length values
(accesses must be aligned at 16 bit boundaries) and interprets the
offset provided by ethtool as 16 bit word offset instead as byte offset.

The new code for asix_get_eeprom() introduced by this patch is
modeled after the code in
drivers/net/ethernet/atheros/atl1e/atl1e_ethtool.c
and provides read access to the entire EEPROM with arbitrary
offsets and lengths.

Signed-off-by: Christian Riesch 
Signed-off-by: David S. Miller

asix: Add a new driver for the AX88172A

2012-07-17T06:26:23+00:00

The Asix AX88172A is a USB 2.0 Ethernet interface that supports both an
internal PHY as well as an external PHY (connected via MII).

This patch adds a driver for the AX88172A and provides support for
both modes and the phylib.

Signed-off-by: Christian Riesch 
Signed-off-by: David S. Miller