linux-toradex.git/drivers/net/usb/sr9700.c, branch v6.0-rc7

sr9700: sanity check for packet length

2022-02-18T11:05:08+00:00

A malicious device can leak heap data to user space
providing bogus frame lengths. Introduce a sanity check.

Signed-off-by: Oliver Neukum 
Reviewed-by: Grant Grundler 
Signed-off-by: David S. Miller

net: usb: don't write directly to netdev->dev_addr

2021-10-22T17:16:01+00:00

Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it got through appropriate helpers.

Manually fix all net/usb drivers without separate maintainers.

v2: catc does DMA to the buffer, leave the conversion to Oliver

Signed-off-by: Jakub Kicinski

ethernet: constify references to netdev->dev_addr in drivers

2021-10-14T16:22:11+00:00

This big patch sprinkles const on local variables and
function arguments which may refer to netdev->dev_addr.

Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it got through appropriate helpers.

Some of the changes here are not strictly required - const
is sometimes cast off but pointer is not used for writing.
It seems like it's still better to add the const in case
the code changes later or relevant -W flags get enabled
for the build.

No functional changes.

Link: https://lore.kernel.org/r/20211014142432.449314-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski

net: usb: use eth_hw_addr_set() for dev->addr_len cases

2021-10-05T12:16:48+00:00

Convert usb drivers from memcpy(... dev->addr_len)
to eth_hw_addr_set():

  @@
  expression dev, np;
  @@
  - memcpy(dev->dev_addr, np, dev->addr_len)
  + eth_hw_addr_set(dev, np)

Manually checked these are either usbnet or pure etherdevs.

Signed-off-by: Jakub Kicinski 
Signed-off-by: David S. Miller

dev_ioctl: split out ndo_eth_ioctl

2021-07-27T19:11:45+00:00

Most users of ndo_do_ioctl are ethernet drivers that implement
the MII commands SIOCGMIIPHY/SIOCGMIIREG/SIOCSMIIREG, or hardware
timestamping with SIOCSHWTSTAMP/SIOCGHWTSTAMP.

Separate these from the few drivers that use ndo_do_ioctl to
implement SIOCBOND, SIOCBR and SIOCWANDEV commands.

This is a purely cosmetic change intended to help readers find
their way through the implementation.

Cc: Doug Ledford 
Cc: Jason Gunthorpe 
Cc: Jay Vosburgh 
Cc: Veaceslav Falico 
Cc: Andy Gospodarek 
Cc: Andrew Lunn 
Cc: Vivien Didelot 
Cc: Florian Fainelli 
Cc: Vladimir Oltean 
Cc: Leon Romanovsky 
Cc: linux-rdma@vger.kernel.org
Signed-off-by: Arnd Bergmann 
Acked-by: Jason Gunthorpe 
Signed-off-by: David S. Miller

usbnet: add _mii suffix to usbnet_set/get_link_ksettings

2021-04-06T23:22:36+00:00

The generic functions assumed devices provided an MDIO interface (accessed
via older mii code, not phylib). This is true only for genuine ethernet.

Devices with a higher level of abstraction or based on different
technologies do not have MDIO. To support this case, first rename
the existing functions with _mii suffix.

v2: rebased on changed upstream
v3: changed names to clearly say that this does NOT use phylib
v4: moved hunks to correct patch; reworded commmit messages

Signed-off-by : Oliver Neukum 
Tested-by: Roland Dreier 
Reviewed-by: Grant Grundler 
Tested-by: Grant Grundler 
Reviewed-by: Andrew Lunn 
Signed-off-by: David S. Miller

net: usb: switch to dev_get_tstats64 and remove usbnet_get_stats64 alias

2020-11-12T22:58:27+00:00

Replace usbnet_get_stats64() with new identical core function
dev_get_tstats64() in all users and remove usbnet_get_stats64().

Signed-off-by: Heiner Kallweit 
Acked-by: Bjørn Mork 
Signed-off-by: Jakub Kicinski

drivers: net: Remove unnecessary semicolon

2019-03-02T07:13:49+00:00

drivers/net/dsa/mt7530.c:649:3-4: Unneeded semicolon
drivers/net/ethernet/cisco/enic/enic_clsf.c:35:2-3: Unneeded semicolon
drivers/net/ethernet/faraday/ftgmac100.c:1640:2-3: Unneeded semicolon
drivers/net/ethernet/mediatek/mtk_eth_soc.c:229:2-3: Unneeded semicolon
drivers/net/usb/sr9700.c:437:2-3: Unneeded semicolon

Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Signed-off-by: YueHaibing 
Acked-by: Sean Wang  for mt7530 and mtk_eth_soc
Signed-off-by: David S. Miller

net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind()

2018-07-27T20:45:15+00:00

sr9700_bind() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai 
Signed-off-by: Jia-Ju Bai 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2017-04-22T03:23:53+00:00

Both conflict were simple overlapping changes.

In the kaweth case, Eric Dumazet's skb_cow() bug fix overlapped the
conversion of the driver in net-next to use in-netdev stats.

Signed-off-by: David S. Miller