linux-toradex.git/drivers/net/virtio_net.c, branch v4.10

virtio_net: reject XDP programs using header adjustment

2017-01-26T03:48:40+00:00

commit 17bedab27231 ("bpf: xdp: Allow head adjustment in XDP prog")
added a new XDP helper to prepend and remove data from a frame.
Make virtio_net reject programs making use of this helper until
proper support is added.

Signed-off-by: Jakub Kicinski 
Acked-by: John Fastabend 
Acked-by: Jason Wang 
Acked-by: Michael S. Tsirkin 
Signed-off-by: David S. Miller

virtio_net: use dev_kfree_skb for small buffer XDP receive

2017-01-26T03:48:17+00:00

In the small buffer case during driver unload we currently use
put_page instead of dev_kfree_skb. Resolve this by adding a check
for virtnet mode when checking XDP queue type. Also name the
function so that the code reads correctly to match the additional
check.

Fixes: bb91accf2733 ("virtio-net: XDP support for small buffers")
Signed-off-by: John Fastabend 
Acked-by: Jason Wang 
Acked-by: Michael S. Tsirkin 
Signed-off-by: David S. Miller

virtio_net: fix PAGE_SIZE > 64k

2017-01-24T19:41:06+00:00

I don't have any guests with PAGE_SIZE > 64k but the
code seems to be clearly broken in that case
as PAGE_SIZE / MERGEABLE_BUFFER_ALIGN will need
more than 8 bit and so the code in mergeable_ctx_to_buf_address
does not give us the actual true size.

Cc: John Fastabend 
Signed-off-by: Michael S. Tsirkin 
Signed-off-by: David S. Miller

virtio-net: restore VIRTIO_HDR_F_DATA_VALID on receiving

2017-01-20T16:01:17+00:00

Commit 501db511397f ("virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on
xmit") in fact disables VIRTIO_HDR_F_DATA_VALID on receiving path too,
fixing this by adding a hint (has_data_valid) and set it only on the
receiving path.

Cc: Rolf Neugebauer 
Signed-off-by: Jason Wang 
Acked-by: Rolf Neugebauer 
Signed-off-by: David S. Miller

cpu/hotplug: Cleanup state names

2016-12-25T09:47:44+00:00

When the state names got added a script was used to add the extra argument
to the calls. The script basically converted the state constant to a
string, but the cleanup to convert these strings into meaningful ones did
not happen.

Replace all the useless strings with 'subsys/xxx/yyy:state' strings which
are used in all the other places already.

Signed-off-by: Thomas Gleixner 
Cc: Peter Zijlstra 
Cc: Sebastian Siewior 
Link: http://lkml.kernel.org/r/20161221192112.085444152@linutronix.de
Signed-off-by: Thomas Gleixner

virtio-net: XDP support for small buffers

2016-12-23T18:48:56+00:00

Commit f600b6905015 ("virtio_net: Add XDP support") leaves the case of
small receive buffer untouched. This will confuse the user who want to
set XDP but use small buffers. Other than forbid XDP in small buffer
mode, let's make it work. XDP then can only work at skb->data since
virtio-net create skbs during refill, this is sub optimal which could
be optimized in the future.

Cc: John Fastabend 
Signed-off-by: Jason Wang 
Acked-by: John Fastabend 
Signed-off-by: David S. Miller

virtio-net: remove big packet XDP codes

2016-12-23T18:48:55+00:00

Now we in fact don't allow XDP for big packets, remove its codes.

Cc: John Fastabend 
Signed-off-by: Jason Wang 
Signed-off-by: David S. Miller

virtio-net: forbid XDP when VIRTIO_NET_F_GUEST_UFO is support

2016-12-23T18:48:55+00:00

When VIRTIO_NET_F_GUEST_UFO is negotiated, host could still send UFO
packet that exceeds a single page which could not be handled
correctly by XDP. So this patch forbids setting XDP when GUEST_UFO is
supported. While at it, forbid XDP for ECN (which comes only from GRO)
too to prevent user from misconfiguration.

Cc: John Fastabend 
Signed-off-by: Jason Wang 
Acked-by: John Fastabend 
Signed-off-by: David S. Miller

virtio-net: make rx buf size estimation works for XDP

2016-12-23T18:48:55+00:00

We don't update ewma rx buf size in the case of XDP. This will lead
underestimation of rx buf size which causes host to produce more than
one buffers. This will greatly increase the possibility of XDP page
linearization.

Cc: John Fastabend 
Signed-off-by: Jason Wang 
Acked-by: John Fastabend 
Signed-off-by: David S. Miller

virtio-net: unbreak csumed packets for XDP_PASS

2016-12-23T18:48:54+00:00

We drop csumed packet when do XDP for packets. This breaks
XDP_PASS when GUEST_CSUM is supported. Fix this by allowing csum flag
to be set. With this patch, simple TCP works for XDP_PASS.

Cc: John Fastabend 
Signed-off-by: Jason Wang 
Acked-by: John Fastabend 
Signed-off-by: David S. Miller