linux-toradex.git/drivers/net/wireless/brcm80211, branch v3.4.65

brcmsmac: Fix WARNING caused by lack of calls to dma_mapping_error()

2013-09-27T00:15:33+00:00

commit 67d0cf50bd32b66eab709871714e55725ee30ce4 upstream.

The driver fails to check the results of DMA mapping in twp places,
which results in the following warning:

[   28.078515] ------------[ cut here ]------------
[   28.078529] WARNING: at lib/dma-debug.c:937 check_unmap+0x47e/0x930()
[   28.078533] bcma-pci-bridge 0000:0e:00.0: DMA-API: device driver failed to check map error[device address=0x00000000b5d60d6c] [size=1876 bytes] [mapped as
 single]
[   28.078536] Modules linked in: bnep bluetooth vboxpci(O) vboxnetadp(O) vboxnetflt(O) vboxdrv(O) ipv6 b43 brcmsmac rtl8192cu rtl8192c_common rtlwifi mac802
11 brcmutil cfg80211 snd_hda_codec_conexant rng_core snd_hda_intel kvm_amd snd_hda_codec ssb kvm mmc_core snd_pcm snd_seq snd_timer snd_seq_device snd k8temp
 cordic joydev serio_raw hwmon sr_mod sg pcmcia pcmcia_core soundcore cdrom i2c_nforce2 i2c_core forcedeth bcma snd_page_alloc autofs4 ext4 jbd2 mbcache crc1
6 scsi_dh_alua scsi_dh_hp_sw scsi_dh_rdac scsi_dh_emc scsi_dh ata_generic pata_amd
[   28.078602] CPU: 1 PID: 2570 Comm: NetworkManager Tainted: G           O 3.10.0-rc7-wl+ #42
[   28.078605] Hardware name: Hewlett-Packard HP Pavilion dv2700 Notebook PC/30D6, BIOS F.27 11/27/2008
[   28.078607]  0000000000000009 ffff8800bbb03ad8 ffffffff8144f898 ffff8800bbb03b18
[   28.078612]  ffffffff8103e1eb 0000000000000002 ffff8800b719f480 ffff8800b7b9c010
[   28.078617]  ffffffff824204c0 ffffffff81754d57 0000000000000754 ffff8800bbb03b78
[   28.078622] Call Trace:
[   28.078624]    [] dump_stack+0x19/0x1b
[   28.078634]  [] warn_slowpath_common+0x6b/0xa0
[   28.078638]  [] warn_slowpath_fmt+0x41/0x50
[   28.078650]  [] check_unmap+0x47e/0x930
[   28.078655]  [] debug_dma_unmap_page+0x5c/0x70
[   28.078679]  [] dma64_getnextrxp+0x10c/0x190 [brcmsmac]
[   28.078691]  [] dma_rx+0x62/0x240 [brcmsmac]
[   28.078707]  [] brcms_c_dpc+0x211/0x9d0 [brcmsmac]
[   28.078717]  [] ? brcms_dpc+0x27/0xf0 [brcmsmac]
[   28.078731]  [] brcms_dpc+0x47/0xf0 [brcmsmac]
[   28.078736]  [] tasklet_action+0x6c/0xf0
--snip--
[   28.078974]  [] SyS_sendmsg+0xd/0x20
[   28.078979]  [] tracesys+0xdd/0xe2
[   28.078982] ---[ end trace 6164d1a08148e9c8 ]---
[   28.078984] Mapped at:
[   28.078985]  [] debug_dma_map_page+0x9d/0x150
[   28.078989]  [] dma_rxfill+0x102/0x3d0 [brcmsmac]
[   28.079001]  [] brcms_c_init+0x87d/0x1100 [brcmsmac]
[   28.079010]  [] brcms_init+0x21/0x30 [brcmsmac]
[   28.079018]  [] brcms_c_up+0x150/0x430 [brcmsmac]

As the patch adds a new failure mechanism to dma_rxfill(). When I changed the
comment at the start of the routine to add that information, I also polished
the wording.

Signed-off-by: Larry Finger 
Cc: Brett Rudley 
Cc: Franky (Zhenhui) Lin 
Cc: Hante Meuleman 
Cc: brcm80211-dev-list@broadcom.com
Acked-by: Arend van Spriel 
Signed-off-by: John W. Linville 
Signed-off-by: Greg Kroah-Hartman

brcmsmac: increase timer reference count for new timers only

2013-02-04T00:24:41+00:00

commit a1fe52801a992e590cdaee2fb47a94bac9b5da90 upstream.

On hardware reintialization reference count of
already existing timers would be increased again.
This leads to problems on module unloading.

Reviewed-by: Pieter-Paul Giesberts 
Reviewed-by: Hante Meuleman 
Reviewed-by: Arend van Spriel 
Signed-off-by: Piotr Haber 
Signed-off-by: Arend van Spriel 
Signed-off-by: John W. Linville 
Signed-off-by: Greg Kroah-Hartman

brcmfmac: Fix big endian host configuration data.

2012-10-02T17:30:07+00:00

commit e020a83d0942a5aceac35986500c9834efc8707d upstream.

Fixes big endian host configuration parameters.

Reviewed-by: Arend Van Spriel 
Signed-off-by: Hante Meuleman 
Signed-off-by: Arend van Spriel 
Signed-off-by: John W. Linville 
Signed-off-by: Greg Kroah-Hartman

brcmfmac: fix big endian bug in i-scan.

2012-10-02T17:30:07+00:00

commit ed205b361956c96e0d8c09a8c9135a6a79cd9541 upstream.

ssid len is 32 bit and needs endian conversion for big endian systems.

Signed-off-by: Hante Meuleman 
Signed-off-by: Arend van Spriel 
Signed-off-by: John W. Linville 
Signed-off-by: Greg Kroah-Hartman

brcmfmac: fix a double spin_unlock_irqrestore issue in dpc

2012-05-02T18:02:03+00:00

dpc_tl_lock is not acquired in the error handle code for bus down.
But it's unlocked using spin_unlock_irqrestore after finishing task
list walk down. Grab the lock before breaking the loop to avoid a
double unlock.

Reported-by: Dan Carpenter 
Signed-off-by: Franky Lin 
Signed-off-by: John W. Linville

brcm80211: fmac: fix missing completion events issue

2012-04-27T19:20:39+00:00

dpc takes care of all data packets transmissions for sdio function
2. It is possible that it misses some completion events when the
traffic is heavy or it's running on a slow cpu. A linked list is
introduced to make sure dpc is invoked whenever needed.

Reviewed-by: Pieter-Paul Giesberts 
Reviewed-by: Arend van Spriel 
Signed-off-by: Franky Lin 
Signed-off-by: John W. Linville

brcm80211: fmac: fix SDIO function 0 register r/w issue

2012-04-27T19:20:39+00:00

SDIO stack doesn't have a structure for function 0. The structure
pointer stored in card->sdio_func[0] is actually for function 1.
With current implementation the register read/write is applied to
function 1. This pathch fixes the issue.

Reviewed-by: Pieter-Paul Giesberts 
Reviewed-by: Arend van Spriel 
Reviewed-by: Florian Fainelli 
Reviewed-by: Johannes Berg 
Signed-off-by: Franky Lin 
Signed-off-by: John W. Linville

brcmsmac: "INTERMEDIATE but not AMPDU" only when tracing

2012-04-23T18:57:53+00:00

I keep getting the following messages on the log buffer:
[ 2167.097507] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2281.331305] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2281.332539] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2329.876605] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2329.877354] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2462.280756] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU
[ 2615.651689] ieee80211 phy0: brcms_c_dotxstatus: INTERMEDIATE but not AMPDU

From the code comment I understand that this something that can -
and does, quite frequently - happen.

Signed-off-by: Eldad Zack 
Acked-by: Franky Lin
Signed-off-by: John W. Linville

brcm80211: smac: resume transmit fifo upon receiving frames

2012-04-13T18:05:35+00:00

There have been reports about not being able to use access-points
on channel 12 and 13 or having connectivity issues when these channels
were part of the selected regulatory domain. Upon switching to these
channels the brcmsmac driver suspends the transmit dma fifos. This
patch resumes them upon handing over the first received beacon to
mac80211.

This patch is to be applied to the stable tree for kernel versions
3.2 and 3.3.

Cc: stable@vger.kernel.org
Tested-by: Francesco Saverio Schiavarelli 
Reviewed-by: Pieter-Paul Giesberts 
Reviewed-by: Brett Rudley 
Signed-off-by: Arend van Spriel 
Signed-off-by: John W. Linville

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next into for-davem

2012-03-16T17:45:25+00:00

Conflicts:
	drivers/net/wireless/ath/ath9k/hw.c