linux-toradex.git/drivers/net/wireless/ipw2x00, branch v3.5.1

net/wireless: ipw2100: Fix WARN_ON occurring in wiphy_register called by ipw2100_pci_init_one

2012-06-08T17:43:57+00:00

The problem was found by Larry Finger:
http://marc.info/?l=linux-wireless&m=133702401700614&w=2

The problem is identical to the one for ipw2200 which is already fixed:
http://marc.info/?l=linux-wireless&m=133457257407196&w=2

[   17.766431] ------------[ cut here ]------------
[   17.766467] WARNING: at net/wireless/core.c:562 wiphy_register+0x34c/0x3c0 [cfg80211]()
[   17.766471] Hardware name: Latitude D600
[   17.766474] Modules linked in: ipw2100(+) libipw pcmcia cfg80211 ppdev parport_pc yenta_socket sr_mod pcmcia_rsrc parport iTCO_wdt cdrom sg rfkill pcmcia_
core lib80211 tg3 video button battery ac iTCO_vendor_support joydev shpchp pcspkr pciehp pci_hotplug autofs4 radeon ttm drm_kms_helper uhci_hcd ehci_hcd rtc
_cmos thermal drm hwmon i2c_algo_bit i2c_core processor usbcore usb_common ata_generic ata_piix ahci libahci libata
[   17.766525] Pid: 474, comm: modprobe Not tainted 3.4.0-rc7-wl+ #6
[   17.766528] Call Trace:
[   17.766541]  [] ? printk+0x28/0x2a
[   17.766552]  [] warn_slowpath_common+0x6d/0xa0
[   17.766563]  [] ? wiphy_register+0x34c/0x3c0 [cfg80211]
[   17.766573]  [] ? wiphy_register+0x34c/0x3c0 [cfg80211]
[   17.766578]  [] warn_slowpath_null+0x1d/0x20
[   17.766588]  [] wiphy_register+0x34c/0x3c0 [cfg80211]
[   17.766605]  [] ipw2100_wdev_init+0x196/0x1c0 [ipw2100]
[   17.766616]  [] ipw2100_pci_init_one+0x2b2/0x694 [ipw2100]
[   17.766632]  [] local_pci_probe+0x42/0xb0
[   17.766637]  [] pci_device_probe+0x60/0x90
[   17.766645]  [] ? sysfs_create_link+0x12/0x20
[   17.766654]  [] really_probe+0x56/0x2e0
[   17.766659]  [] ? create_dir+0x5d/0xa0
[   17.766667]  [] ? pm_runtime_barrier+0x3b/0xa0
[   17.766672]  [] driver_probe_device+0x44/0xa0
[   17.766677]  [] ? pci_match_device+0x97/0xa0
[   17.766681]  [] __driver_attach+0x89/0x90
[   17.766686]  [] ? driver_probe_device+0xa0/0xa0
[   17.766691]  [] bus_for_each_dev+0x3a/0x70
[   17.766695]  [] driver_attach+0x1c/0x30
[   17.766699]  [] ? driver_probe_device+0xa0/0xa0
[   17.766704]  [] bus_add_driver+0x187/0x280
[   17.766710]  [] ? kset_find_obj+0x2d/0x60
[   17.766715]  [] ? pci_device_probe+0x90/0x90
[   17.766719]  [] ? pci_device_probe+0x90/0x90
[   17.766724]  [] driver_register+0x65/0x110
[   17.766729]  [] __pci_register_driver+0x3d/0xa0
[   17.766738]  [] ipw2100_init+0x5c/0x1000 [ipw2100]
[   17.766743]  [] do_one_initcall+0x2f/0x170
[   17.766749]  [] ? 0xe09f6fff
[   17.766757]  [] sys_init_module+0xa8/0x210
[   17.766766]  [] syscall_call+0x7/0xb
[   17.766769] ---[ end trace 559898c6bb0d1c75 ]---
[   17.767093] ipw2100: probe of 0000:02:03.0 failed with error -5

This warning appears only if we apply Ben Hutchings' fix
http://marc.info/?l=linux-wireless&m=132720204412667&w=2
for the bug reported by Cesare Leonardi
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=656813
with cfg80211 warning during device registration
("cfg80211: failed to add phy80211 symlink to netdev!").

We separate device bring up and registration with network stack
to avoid the problem.

Signed-off-by: Stanislav Yakovlev 
Tested-by: Larry Finger 
Signed-off-by: John W. Linville

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next

2012-05-14T22:00:48+00:00

drivers/net: Convert compare_ether_addr to ether_addr_equal

2012-05-11T03:33:01+00:00

Use the new bool function ether_addr_equal to add
some clarity and reduce the likelihood for misuse
of compare_ether_addr for sorting.

Done via cocci script:

$ cat compare_ether_addr.cocci
@@
expression a,b;
@@
-	!compare_ether_addr(a, b)
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	compare_ether_addr(a, b)
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!ether_addr_equal(a, b) == 0
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!ether_addr_equal(a, b) != 0
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	ether_addr_equal(a, b) == 0
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	ether_addr_equal(a, b) != 0
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!!ether_addr_equal(a, b)
+	ether_addr_equal(a, b)

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

ipw2100: Fix order of device registration

2012-05-09T01:53:47+00:00

Currently cfg80211 fails to create a "phy80211" symlink in sysfs from
the net device to the wiphy device.  The latter needs to be registered
first.

Compile-tested only.

Signed-off-by: Ben Hutchings 
Signed-off-by: John W. Linville

ipw2200: Fix order of device registration

2012-05-09T01:53:47+00:00

Currently cfg80211 fails to create a "phy80211" symlink in sysfs from
the net device to the wiphy device.  The latter needs to be registered
first.

Compile-tested only.

Reported-by: Cesare Leonardi 
Signed-off-by: Ben Hutchings 
Signed-off-by: John W. Linville

net/wireless: ipw2200: Fix WARN_ON occurring in wiphy_register called by ipw_pci_probe

2012-05-09T01:53:44+00:00

The problem was found by Stefan Lippers-Hollmann
http://marc.info/?l=linux-wireless&m=132720334512946&w=2

WARNING: at /tmp/buildd/linux-aptosid-3.2/debian/build/source_i386_none/net/wireless/core.c:562 wiphy_register+0x45/0x38d [cfg80211]()
Hardware name: TravelMate 290 \xffffffff\xffffffff\xffffffff\xffffffff\xffffffff\xffffffff\xffffffff\xffffffff\xffffffff\xffffffff\xffffffff\xffffffff\xffffffff\xffffffff\xffffffff\xffffffff\xffffffff
Modules linked in: ipw2200(+) iTCO_wdt libipw joydev drm snd_seq snd_timer snd_seq_device iTCO_vendor_support yenta_socket snd intel_agp i2c_i801 pcmcia_rsrc cfg80211 soundcore parport_pc psmouse parport rng_core snd_page_alloc serio_raw pcspkr i2c_algo_bit intel_gtt pcmcia_core evdev irda crc_ccitt rfkill lib80211 processor container ac battery shpchp pci_hotplug button ext4 mbcache jbd2 crc16 dm_mod sd_mod sr_mod crc_t10dif cdrom ata_generic pata_acpi ata_piix libata scsi_mod firewire_ohci firewire_core crc_itu_t 8139too 8139cp mii uhci_hcd ehci_hcd usbcore usb_common [last unloaded: scsi_wait_scan]
Pid: 328, comm: modprobe Not tainted 3.2-1.slh.4-aptosid-686 #1
Call Trace:
[] ? warn_slowpath_common+0x7c/0x8f
[] ? wiphy_register+0x45/0x38d [cfg80211]
[] ? wiphy_register+0x45/0x38d [cfg80211]
[] ? warn_slowpath_null+0x1b/0x1f
[] ? wiphy_register+0x45/0x38d [cfg80211]
[] ? internal_create_group+0xf5/0xff
[] ? ipw_pci_probe+0xa9a/0xbd0 [ipw2200]
[] ? arch_local_irq_save+0xf/0x14
[] ? pci_device_probe+0x53/0x9a
[] ? driver_probe_device+0x94/0x124
[] ? pci_match_id+0x15/0x34
[] ? __driver_attach+0x40/0x5b
[] ? bus_for_each_dev+0x37/0x60
[] ? driver_attach+0x17/0x1a
[] ? driver_probe_device+0x124/0x124
[] ? bus_add_driver+0x92/0x1d1
[] ? 0xe099cfff
[] ? driver_register+0x7d/0xd4
[] ? jump_label_module_notify+0xec/0x167
[] ? 0xe099cfff
[] ? __pci_register_driver+0x32/0x87
[] ? 0xe099cfff
[] ? ipw_init+0x2e/0x72 [ipw2200]
[] ? do_one_initcall+0x7d/0x132
[] ? __blocking_notifier_call_chain+0x47/0x4f
[] ? sys_init_module+0x13a4/0x159c
[] ? sysenter_do_call+0x12/0x28

This warning appears only if we apply Ben Hutchings' fix
http://marc.info/?l=linux-wireless&m=132720195012653&w=2
for the bug reported by Cesare Leonardi
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=656813
with cfg80211 warning during device registration
("cfg80211: failed to add phy80211 symlink to netdev!").

We separate device bring up and registration with network stack
to avoid the problem.

After that Ben Hutchings' fix can be applied to fix the bug.

Cc: stable@kernel.org
Signed-off-by: Stanislav Yakovlev 
Tested-by: Stefan Lippers-Hollmann 
Signed-off-by: John W. Linville

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2012-05-08T03:35:40+00:00

Conflicts:
	drivers/net/ethernet/intel/e1000e/param.c
	drivers/net/wireless/iwlwifi/iwl-agn-rx.c
	drivers/net/wireless/iwlwifi/iwl-trans-pcie-rx.c
	drivers/net/wireless/iwlwifi/iwl-trans.h

Resolved the iwlwifi conflict with mainline using 3-way diff posted
by John Linville and Stephen Rothwell.  In 'net' we added a bug
fix to make iwlwifi report a more accurate skb->truesize but this
conflicted with RX path changes that happened meanwhile in net-next.

In e1000e a conflict arose in the validation code for settings of
adapter->itr.  'net-next' had more sophisticated logic so that
logic was used.

Signed-off-by: David S. Miller

ipw2200: Fix race condition in the command completion acknowledge

2012-04-23T18:57:49+00:00

Driver incorrectly validates command completion: instead of waiting
for a command to be acknowledged it continues execution.  Most of the
time driver gets acknowledge of the command completion in a tasklet
before it executes the next one. But sometimes it sends the next
command before it gets acknowledge for the previous one. In such a
case one of the following error messages appear in the log:

Failed to send SYSTEM_CONFIG: Already sending a command.
Failed to send ASSOCIATE: Already sending a command.
Failed to send TX_POWER: Already sending a command.

After that you need to reload the driver to get it working again.

This bug occurs during roaming (reported by Sam Varshavchik)
https://bugzilla.redhat.com/show_bug.cgi?id=738508
and machine booting (reported by Tom Gundersen and Mads Kiilerich)
https://bugs.archlinux.org/task/28097
https://bugzilla.redhat.com/show_bug.cgi?id=802106

This patch doesn't fix the delay issue during firmware load.
But at least device now works as usual after boot.

Cc: stable@kernel.org
Signed-off-by: Stanislav Yakovlev 
Signed-off-by: John W. Linville

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next into for-davem

2012-04-18T18:27:48+00:00

Conflicts:
	drivers/net/wireless/iwlwifi/iwl-testmode.c
	include/net/nfc/nfc.h
	net/nfc/netlink.c
	net/wireless/nl80211.c

net: Fix spelling typo in net

2012-04-14T19:29:02+00:00

Correct spelling typo within drivers/net.

Signed-off-by: Masanari Iida 
Signed-off-by: David S. Miller