linux-toradex.git/drivers/net/wireless/realtek/rtlwifi/rtl8192ce, branch master

wifi: rtlwifi: Use min()/max() to improve code

2025-07-18T06:41:06+00:00

Use min()/max() to reduce the code and improve its readability.

Acked-by: Ping-Ke Shih 
Signed-off-by: Qianfeng Rong 
Signed-off-by: Ping-Ke Shih 
Link: https://patch.msgid.link/20250715121721.266713-8-rongqianfeng@vivo.com

wifi: rtlwifi: avoid stack size warning for _read_eeprom_info

2025-06-16T03:45:49+00:00

txpower_info_{2g,5g} are too big to fit on the stack, but in most of the
rtlwifi variants this stays below the warning limit for stack frames.
In rtl8192ee and a few others, I see a case where clang decides to fully
inline this into rtl92ee_read_eeprom_info, triggering this warning:

drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c:2178:6: error: stack frame size (1312) exceeds limit (1280) in 'rtl92ee_read_eeprom_info' [-Werror,-Wframe-larger-than]

Mark _rtl92ee_read_txpower_info_from_hwpg() as noinline_for_stack to
and mark _rtl92ee_get_chnl_group() as __always_inline to make clang
behave the same way as gcc. Inlining _rtl92ee_get_chnl_group helps
let the compiler see that the index is always in range. The same
change appears to be necessary in all rtlwifi variants.

A more thorough approach would be to avoid the use of the two structures
on the stack entirely and combine them with the struct rtl_efuse
data that is dynamically allocated and holds the same information.

Signed-off-by: Arnd Bergmann 
Signed-off-by: Ping-Ke Shih 
Link: https://patch.msgid.link/20250610092240.2639751-1-arnd@kernel.org

wifi: rtlwifi: Constify struct rtl_hal_ops and rtl_hal_cfg

2025-06-10T01:12:16+00:00

'struct rtl_hal_ops' and 'struct rtl_hal_cfg' are not modified in these
drivers.

Constifying this structure moves some data to a read-only section, so
increase overall security, especially when the structure holds some
function pointers.

Constification of rtl_hal_cfg is only needed in rtl8192cu/sw.c

On a x86_64, with allmodconfig, as an example:
Before:
======
   text	   data	    bss	    dec	    hex	filename
  10167	   5512	    128	  15807	   3dbf	drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
  10743	   4936	    128	  15807	   3dbf	drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.o

Signed-off-by: Christophe JAILLET 
Signed-off-by: Ping-Ke Shih 
Link: https://patch.msgid.link/2c3f3d8d8b2f7dcb8cc64cebe89e55720d1d733d.1747500351.git.christophe.jaillet@wanadoo.fr

wifi: rtlwifi: fix default typo

2024-07-05T01:59:46+00:00

Change 'defult' to 'default' in comments in several rtlwifi drivers.

Signed-off-by: Fredrik Lönnegren 
Acked-by: Ping-Ke Shih 
Signed-off-by: Ping-Ke Shih 
Link: https://patch.msgid.link/20240703070627.135328-1-fredrik@frelon.se

wifi: rtlwifi: cleanup few rtlxxx_tx_fill_desc() routines

2024-01-12T17:11:41+00:00

Remove unreachable branches in 'rtl92ce_tx_fill_desc()',
'rtl92cu_tx_fill_desc()' and 'rtl8723e_tx_fill_desc()'.
Compile tested only.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Dmitry Antipov 
Signed-off-by: Kalle Valo 
Link: https://msgid.link/20240109104735.140550-1-dmantipov@yandex.ru

wifi: rtlwifi: rtl8192ce: using calculate_bit_shift()

2023-12-21T14:40:17+00:00

Using calculate_bit_shift() to replace _rtl92c_phy_calculate_bit_shift().
And fix the undefined bitwise shift behavior problem.

Fixes: 0c8173385e54 ("rtl8192ce: Add new driver")
Signed-off-by: Su Hui 
Signed-off-by: Kalle Valo 
Link: https://msgid.link/20231219065739.1895666-7-suhui@nfschina.com

wifi: rtlwifi: drop unused const_amdpci_aspm

2023-11-22T15:50:36+00:00

Remove the unused "const_amdpci_aspm" member of struct rtl_pci and
struct rtl_ps_ctl.

Signed-off-by: Bjorn Helgaas 
Acked-by: Ping-Ke Shih 
Reviewed-by: Ilpo Järvinen 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20231116180529.52752-1-helgaas@kernel.org

wifi: rtlwifi: simplify TX command fill callbacks

2023-10-14T06:42:24+00:00

Since 'rtlpriv->cfg->ops->fill_tx_cmddesc()' is always called
with 'firstseg' and 'lastseg' set to 1 (and the latter is
never actually used), all of the relevant chip-specific
routines may be simplified. Compile tested only.

Signed-off-by: Dmitry Antipov 
Acked-by: Ping-Ke Shih 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20231011154442.52457-2-dmantipov@yandex.ru

wifi: rtlwifi: cleanup few rtlxxxx_set_hw_reg() routines

2023-09-28T16:25:36+00:00

Since 'u8' comparison against zero is always false, drop the
corresponding branches of AMPDU_MIN_SPACE adjustment within
'rtlxxxx_set_hw_reg()' for rtl8188ee, rtl8192ce, rtl8192de,
rtl8723ae, rtl8723be, and rtl8821ae. Compile tested only.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Dmitry Antipov 
Acked-by: Ping-Ke Shih 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20230925090452.25633-1-dmantipov@yandex.ru

wifi: rtlwifi: simplify LED management

2023-06-21T18:31:10+00:00

Introduce 'rtl_init_sw_leds()' to replace per-chip LED
initialization code (and so drop 'struct rtl_led' as no
longer used), drop 'init_sw_leds' and 'deinit_sw_leds'
fields from 'struct rtl_hal_ops', adjust related code.

Signed-off-by: Dmitry Antipov 
Acked-by: Ping-Ke Shih 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20230614061832.40882-1-dmantipov@yandex.ru