linux-toradex.git/drivers/net/wireless/realtek/rtlwifi/rtl8192ee, branch master

wifi: rtlwifi: Use min()/max() to improve code

2025-07-18T06:41:06+00:00

Use min()/max() to reduce the code and improve its readability.

Acked-by: Ping-Ke Shih 
Signed-off-by: Qianfeng Rong 
Signed-off-by: Ping-Ke Shih 
Link: https://patch.msgid.link/20250715121721.266713-8-rongqianfeng@vivo.com

wifi: rtlwifi: avoid stack size warning for _read_eeprom_info

2025-06-16T03:45:49+00:00

txpower_info_{2g,5g} are too big to fit on the stack, but in most of the
rtlwifi variants this stays below the warning limit for stack frames.
In rtl8192ee and a few others, I see a case where clang decides to fully
inline this into rtl92ee_read_eeprom_info, triggering this warning:

drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c:2178:6: error: stack frame size (1312) exceeds limit (1280) in 'rtl92ee_read_eeprom_info' [-Werror,-Wframe-larger-than]

Mark _rtl92ee_read_txpower_info_from_hwpg() as noinline_for_stack to
and mark _rtl92ee_get_chnl_group() as __always_inline to make clang
behave the same way as gcc. Inlining _rtl92ee_get_chnl_group helps
let the compiler see that the index is always in range. The same
change appears to be necessary in all rtlwifi variants.

A more thorough approach would be to avoid the use of the two structures
on the stack entirely and combine them with the struct rtl_efuse
data that is dynamically allocated and holds the same information.

Signed-off-by: Arnd Bergmann 
Signed-off-by: Ping-Ke Shih 
Link: https://patch.msgid.link/20250610092240.2639751-1-arnd@kernel.org

wifi: rtlwifi: Constify struct rtl_hal_ops and rtl_hal_cfg

2025-06-10T01:12:16+00:00

'struct rtl_hal_ops' and 'struct rtl_hal_cfg' are not modified in these
drivers.

Constifying this structure moves some data to a read-only section, so
increase overall security, especially when the structure holds some
function pointers.

Constification of rtl_hal_cfg is only needed in rtl8192cu/sw.c

On a x86_64, with allmodconfig, as an example:
Before:
======
   text	   data	    bss	    dec	    hex	filename
  10167	   5512	    128	  15807	   3dbf	drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
  10743	   4936	    128	  15807	   3dbf	drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.o

Signed-off-by: Christophe JAILLET 
Signed-off-by: Ping-Ke Shih 
Link: https://patch.msgid.link/2c3f3d8d8b2f7dcb8cc64cebe89e55720d1d733d.1747500351.git.christophe.jaillet@wanadoo.fr

wifi: rtlwifi: Remove uncalled stub rtl*_phy_ap_calibrate

2025-05-05T01:20:00+00:00

  rtl92d_phy_ap_calibrate(),
  rtl92du_phy_ap_calibrate(),
  rtl92ee_phy_ap_calibrate(), and
  rtl8821ae_phy_ap_calibrate()

are all empty function stubs that are never called anywhere.

Remove them.

Signed-off-by: Dr. David Alan Gilbert 
Signed-off-by: Ping-Ke Shih 
Link: https://patch.msgid.link/20250425235340.288340-3-linux@treblig.org

wifi: rtlwifi: fix default typo

2024-07-05T01:59:46+00:00

Change 'defult' to 'default' in comments in several rtlwifi drivers.

Signed-off-by: Fredrik Lönnegren 
Acked-by: Ping-Ke Shih 
Signed-off-by: Ping-Ke Shih 
Link: https://patch.msgid.link/20240703070627.135328-1-fredrik@frelon.se

wifi: rtlwifi: rtl8192ee: using calculate_bit_shift()

2023-12-21T14:40:17+00:00

Using calculate_bit_shift() to replace _rtl92ee_phy_calculate_bit_shift().
And fix the undefined bitwise shift behavior problem.

Fixes: b1a3bfc97cd9 ("rtlwifi: rtl8192ee: Move driver from staging to the regular tree")
Signed-off-by: Su Hui 
Signed-off-by: Kalle Valo 
Link: https://msgid.link/20231219065739.1895666-9-suhui@nfschina.com

wifi: rtlwifi: drop unused const_amdpci_aspm

2023-11-22T15:50:36+00:00

Remove the unused "const_amdpci_aspm" member of struct rtl_pci and
struct rtl_ps_ctl.

Signed-off-by: Bjorn Helgaas 
Acked-by: Ping-Ke Shih 
Reviewed-by: Ilpo Järvinen 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20231116180529.52752-1-helgaas@kernel.org

wifi: rtlwifi: rtl92ee_dm_dynamic_primary_cca_check(): fix typo in function name

2023-10-30T17:21:22+00:00

For rtl8192ee, change 'rtl92ee_dm_dynamic_primary_cca_ckeck()'
to 'rtl92ee_dm_dynamic_primary_cca_check()' and so adjust
'rtl92ee_dm_watchdog()' as well. Compile tested only.

Signed-off-by: Dmitry Antipov 
Acked-by: Ping-Ke Shih 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20231023091722.52509-3-dmantipov@yandex.ru

wifi: rtlwifi: cleanup struct rtl_hal

2023-10-30T17:21:22+00:00

Remove unused and set but otherwise unused 'bbrf_ready', 'external_pa',
'pa_mode', 'rx_tag', 'rts_en', 'wow_enable' and 'wow_enabled' fields
of 'struct rtl_hal', adjust related code. Compile tested only.

Signed-off-by: Dmitry Antipov 
Acked-by: Ping-Ke Shih 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20231023091722.52509-1-dmantipov@yandex.ru

wifi: rtlwifi: drop pre_fill_tx_bd_desc() from HAL interface

2023-10-19T07:29:44+00:00

Since 'pre_fill_tx_bd_desc()' is actually used for rtl8192ee only,
there is no need to maintain function pointer in 'struct rtl_hal_ops',
and 'rtl92ee_pre_fill_tx_bd_desc()' may be converted to static.
Compile tested only.

Signed-off-by: Dmitry Antipov 
Acked-by: Ping-Ke Shih 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20231016135925.129223-1-dmantipov@yandex.ru