linux-toradex.git/drivers/net/wireless/realtek, branch v5.5

rtl8xxxu: Remove set but not used variable 'vif','dev','len'

2019-11-20T07:47:19+00:00

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5396:24: warning: variable vif set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5397:17: warning: variable dev set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5400:6: warning: variable len set but not used [-Wunused-but-set-variable]

They are introduced by commit e542e66b7c2e ("rtl8xxxu:
add bluetooth co-existence support for single antenna"), but never used,
so remove them.

Reported-by: Hulk Robot 
Signed-off-by: zhengbin 
Reviewed-by: Chris Chiu 
Signed-off-by: Kalle Valo

rtw88: allows to enable/disable HCI link PS mechanism

2019-11-20T07:44:51+00:00

Different interfaces have its own link-related power save mechanism.
Such as PCI can enter L1 state based on the traffic on the link, and
sometimes driver needs to enable/disable it to avoid some issues, like
throughput degrade when PCI trying to enter L1 state even if driver is
having heavy traffic.

For now, rtw88 only supports PCIE chips, and they just need to disable
ASPM L1 when driver is not in power save mode, such as IPS and LPS.

Signed-off-by: Yan-Hsuan Chuang 
Signed-off-by: Kalle Valo

rtw88: pci: enable CLKREQ function if host supports it

2019-11-20T07:44:50+00:00

By Realtek's design, there are two HW modules associated for CLKREQ,
one is responsible to follow the PCIE host settings, and another
is to actually working on it. But the module that is actually working
on it is default disabled, and driver should enable that module if
host and device have successfully sync'ed with each other.

The module is default disabled because sometimes the host does not
support it, and if there is any incorrect settings (ex. CLKREQ# is
not Bi-Direction), device can be lost and disconnected to the host.

So driver should first check after host and device are sync'ed, and
the host does support the function and set it in configuration
space, then driver can turn on the HW module to working on it.

Signed-off-by: Yan-Hsuan Chuang 
Reviewed-by: Chris Chiu 
Signed-off-by: Kalle Valo

rtw88: pci: use for loop instead of while loop for DBI/MDIO

2019-11-20T07:44:49+00:00

Use a for loop to polling DBI/MDIO read/write flags to avoid
infinite loop happens

Signed-off-by: Yan-Hsuan Chuang 
Reviewed-by: Chris Chiu 
Signed-off-by: Kalle Valo

rtw88: pci: use macros to access PCI DBI/MDIO registers

2019-11-20T07:44:48+00:00

Add some register and bit macros to access DBI/MDIO register. This
should not change the logic.

Signed-off-by: Yan-Hsuan Chuang 
Signed-off-by: Kalle Valo

rtlwifi: set proper udelay within rf_serial_read

2019-11-20T07:41:30+00:00

Since read RF register is an indirect access that hardware needs time to
accomplish read action, but there's no ready bit, so delay is required to
guarantee the read value is correct. After investigating internal documents,
these delays are reduced as proper values.

Reported-by: Lucas Stach 
Signed-off-by: Ping-Ke Shih 
Signed-off-by: Kalle Valo

rtlwifi: rf_lock use non-irqsave spin_lock

2019-11-20T07:41:29+00:00

rf_lock is used to protect RF register access, but they will not called
from interrupt context, so *_irqsave version isn't necessary. Then, these
delays don't affect IRQ services.

The old code holds spin_lock_irqsave() that will be detected a long delay
as below:

  kworker/-276     4d...    0us : _raw_spin_lock_irqsave
  kworker/-276     4d...    0us : rtl8723_phy_rf_serial_read <-rtl8723de_phy_set_rf_reg
  kworker/-276     4d...    1us : rtl8723_phy_query_bb_reg <-rtl8723_phy_rf_serial_read
  kworker/-276     4d...    3us : rtl8723_phy_set_bb_reg <-rtl8723_phy_rf_serial_read
  kworker/-276     4d...    4us : __const_udelay <-rtl8723_phy_rf_serial_read
  kworker/-276     4d...    4us!: delay_mwaitx <-rtl8723_phy_rf_serial_read
  kworker/-276     4d... 1004us : rtl8723_phy_set_bb_reg <-rtl8723_phy_rf_serial_read
  [...]

Reported-by: Lucas Stach 
Signed-off-by: Ping-Ke Shih 
Signed-off-by: Kalle Valo

rtw88: remove duplicated include from ps.c

2019-11-15T12:24:38+00:00

Remove duplicated include.

Signed-off-by: YueHaibing 
Reviewed-by: Simon Horman 
Signed-off-by: Kalle Valo

rtl8xxxu: Remove set but not used variable 'rsr'

2019-11-15T12:24:06+00:00

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_gen2_config_channel:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:1266:13: warning: variable rsr set but not used [-Wunused-but-set-variable]

rsr is never used, so remove it.

Reported-by: Hulk Robot 
Signed-off-by: Zheng Yongjun 
Reviewed-by: Chris Chiu 
Signed-off-by: Kalle Valo

rtl8xxxu: Add support for Edimax EW-7611ULB

2019-11-14T15:25:59+00:00

A number of people have reported the Edimax EW-7611ULB works fine.

Signed-off-by: Jes Sorensen 
Signed-off-by: Kalle Valo