linux-toradex.git/drivers/net/wireless/rt2x00, branch v3.2.7

rt2800pci: fix spurious interrupts generation

2012-01-26T00:13:55+00:00

commit dfd00c4c8f3dfa1fd7cec45f83d98b2a49743dcd upstream.

Same devices can generate interrupt without properly setting bit in
INT_SOURCE_CSR register (spurious interrupt), what will cause IRQ line
will be disabled by interrupts controller driver.

We discovered that clearing INT_MASK_CSR stops such behaviour. We
previously first read that register, and then clear all know interrupt
sources bits and do not touch reserved bits. After this patch, we write
to all register content (I believe writing to reserved bits on that
register will not cause any problems, I tested that on my rt2800pci
device).

This fix very bad performance problem, practically making device
unusable (since worked without interrupts), reported in:
https://bugzilla.redhat.com/show_bug.cgi?id=658451

We previously tried to workaround that issue in commit
4ba7d9997869d25bd223dea7536fc1ce9fab3b3b "rt2800pci: handle spurious
interrupts", but it was reverted in commit
82e5fc2a34fa9ffea38f00c4066b7e600a0ca5e6
as thing, that will prevent to detect real spurious interrupts.

Reported-and-tested-by: Amir Hedayaty 
Signed-off-by: Stanislaw Gruszka 
Acked-by: Gertjan van Wingerde 
Signed-off-by: John W. Linville 
Signed-off-by: Greg Kroah-Hartman

rt2800usb: Move ID out of unknown

2012-01-12T19:29:18+00:00

commit 3f81f8f1524ccca24df1029b0cf825ecef5e5cdc upstream.

Testing on the openSUSE wireless forum has shown that a Linksys
WUSB54GC v3 with USB ID 1737:0077 works with rt2800usb when the ID is
written to /sys/.../new_id. This ID can therefore be moved out of UNKNOWN.

Signed-off-by: Larry Finger 
Acked-by: Gertjan van Wingerde 
Acked-by: Ivo van Doorn 
Signed-off-by: John W. Linville 
Signed-off-by: Greg Kroah-Hartman

Revert "rt2800pci: handle spurious interrupts"

2011-11-22T21:38:19+00:00

This reverts commit 4ba7d9997869d25bd223dea7536fc1ce9fab3b3b.

The original patch was a misguided attempt to improve performance on
some hardware that is apparently prone to spurious interrupt generation.

Signed-off-by: John W. Linville

Revert "rt2x00: handle spurious pci interrupts"

2011-11-22T21:36:35+00:00

This reverts commit 23085d5796561625db4143a671f1de081f66ef08.

The original patch was a misguided attempt to improve performance on
some hardware that is apparently prone to spurious interrupt generation.

Signed-off-by: John W. Linville

rt2x00: Fix efuse EEPROM reading on PPC32.

2011-11-17T19:39:31+00:00

Fix __le32 to __le16 conversion of the first word of an 8-word block
of EEPROM read via the efuse method.

Reported-and-tested-by: Ingvar Hagelund 
Signed-off-by: Gertjan van Wingerde 
CC: 
Acked-by: Helmut Schaa 
Acked-by: Ivo van Doorn 
Signed-off-by: John W. Linville

rt2x00: handle spurious pci interrupts

2011-11-17T19:39:30+00:00

We have documented case of very bad performance issue on rt2800pci
device, because it generate spurious interrupt, what cause irq line
is disabled: https://bugzilla.redhat.com/show_bug.cgi?id=658451

We already address that problem in separate patch by returning
IRQ_HANDLED from interrupt handler. We think similar fix is needed for
other rt2x00 PCI devices, because users report performance problems on
these devices too.

Cc: stable@vger.kernel.org
Signed-off-by: Stanislaw Gruszka 
Acked-by: Ivo van Doorn 
Signed-off-by: John W. Linville

rt2800pci: handle spurious interrupts

2011-11-17T19:39:30+00:00

Some devices may generate spurious interrupts, we have to handle them
otherwise interrupt line will be disabled with below message and driver
will not work:

[ 2052.114334] irq 17: nobody cared (try booting with the "irqpoll" option)
[ 2052.114339] Pid: 0, comm: swapper Tainted: P           2.6.35.6-48.fc14.x86_64 #1
[ 2052.114341] Call Trace:
[ 2052.114342]    [] __report_bad_irq.clone.1+0x3d/0x8b
[ 2052.114349]  [] note_interrupt+0x11a/0x17f
[ 2052.114352]  [] handle_fasteoi_irq+0xa8/0xce
[ 2052.114355]  [] handle_irq+0x88/0x90
[ 2052.114357]  [] do_IRQ+0x5c/0xb4
[ 2052.114360]  [] ret_from_intr+0x0/0x11
[ 2052.114361]    [] ? native_safe_halt+0xb/0xd
[ 2052.114366]  [] ? need_resched+0x23/0x2d
[ 2052.114367]  [] default_idle+0x34/0x4f
[ 2052.114370]  [] cpu_idle+0xaa/0xcc
[ 2052.114373]  [] start_secondary+0x24d/0x28e
[ 2052.114374] handlers:
[ 2052.114375] [] (usb_hcd_irq+0x0/0x7c)
[ 2052.114378] [] (rt2800pci_interrupt+0x0/0x18d [rt2800pci])
[ 2052.114384] Disabling IRQ #17

Resolve:
https://bugzilla.redhat.com/show_bug.cgi?id=658451

Reported-and-tested-by: Amir Hedayaty 
Cc: stable@vger.kernel.org
Signed-off-by: Stanislaw Gruszka 
Acked-by: Ivo van Doorn 
Signed-off-by: John W. Linville

rt2x00: Fix sleep-while-atomic bug in powersaving code.

2011-11-15T15:02:56+00:00

The generic powersaving code that determines after reception of a frame
whether the device should go back to sleep or whether is could stay
awake was calling rt2x00lib_config directly from RX tasklet context.
On a number of the devices this call can actually sleep, due to having
to confirm that the sleeping commands have been executed successfully.

Fix this by moving the call to rt2x00lib_config to a workqueue call.

This fixes bug https://bugzilla.redhat.com/show_bug.cgi?id=731672

Tested-by: Tomas Trnka 
Signed-off-by: Gertjan van Wingerde 
Cc: 
Acked-by: Ivo van Doorn 
Signed-off-by: John W. Linville

rt2x00: Add USB device ID of Buffalo WLI-UC-GNHP.

2011-11-15T15:02:56+00:00

This is reported to be an RT3070 based device.

Reported-by: Teika Kazura 
Signed-off-by: Gertjan van Wingerde 
Acked-by: Ivo van Doorn 
Signed-off-by: John W. Linville

mac80211: pass vif param to conf_tx() callback

2011-10-03T19:22:41+00:00

tx params should be configured per interface.
add ieee80211_vif param to the conf_tx callback,
and change all the drivers that use this callback.

The following spatch was used:
@rule1@
struct ieee80211_ops ops;
identifier conf_tx_op;
@@
	ops.conf_tx = conf_tx_op;

@rule2@
identifier rule1.conf_tx_op;
identifier hw, queue, params;
@@
	conf_tx_op (
-		struct ieee80211_hw *hw,
+		struct ieee80211_hw *hw, struct ieee80211_vif *vif,
		u16 queue,
		const struct ieee80211_tx_queue_params *params) {...}

Signed-off-by: Eliad Peller 
Signed-off-by: John W. Linville