linux-toradex.git/drivers/net/wireless/rtl818x, branch v3.14.4

rtl8187: fix regression on MIPS without coherent DMA

2014-02-13T19:58:12+00:00

This patch fixes regression caused by commit a16dad77634 "MIPS: Fix
potencial corruption". That commit fixes one corruption scenario in
cost of adding another one, which actually start to cause crashes
on Yeeloong laptop when rtl8187 driver is used.

For correct DMA read operation on machines without DMA coherence, kernel
have to invalidate cache, such it will refill later with new data that
device wrote to memory, when that data is needed to process. We can only
invalidate full cache line. Hence when cache line includes both dma
buffer and some other data (written in cache, but not yet in main
memory), the other data can not hit memory due to invalidation. That
happen on rtl8187 where struct rtl8187_priv fields are located just
before and after small buffers that are passed to USB layer and DMA
is performed on them.

To fix the problem we align buffers and reserve space after them to make
them match cache line.

This patch does not resolve all possible MIPS problems entirely, for
that we have to assure that we always map cache aligned buffers for DMA,
what can be complex or even not possible. But patch fixes visible and
reproducible regression and seems other possible corruptions do not
happen in practice, since Yeeloong laptop works stable without rtl8187
driver.

Bug report:
https://bugzilla.kernel.org/show_bug.cgi?id=54391

Reported-by: Petr Pisar 
Bisected-by: Tom Li 
Reported-and-tested-by: Tom Li 
Cc: stable@vger.kernel.org
Signed-off-by: Stanislaw Gruszka 
Acked-by: Larry Finger 
Acked-by: Hin-Tak Leung 
Signed-off-by: John W. Linville

rtl8180: Add error check for pci_map_single return value in TX path

2014-02-06T19:35:53+00:00

Orignal code will not detect a DMA mapping failure, causing the HW
to attempt a DMA from an invalid address.

This patch add the error check and eventually simply drops the TX
packet if we can't map it for DMA.

Signed-off-by: andrea merello 
Signed-off-by: John W. Linville

rtl8180: Add error check for pci_map_single return value in RX path

2014-02-06T19:35:45+00:00

In original code the old RX DMA buffer is unmapped and processed and at the end
of the isr a new buffer is mapped with pci_map_single and attached to the RX
descriptor.

If pci_map_single fails then the RX descriptor remains with no valid DMA buffer
attached.
In this condition the DMA will target where it shouldn't with obvious evil
consequences.

Simply avoiding re-arming the descriptor will prevent buggy DMA but it will
result soon in RX stuck.

This patch move the DMA mapping of the new buffer at the beginning of the ISR
(and it adds error check for pci_map_single success/fail).

If the DMA mapping fails then we do not unmap the old buffer and we re-arm the
descriptor without processing it, with the old DMA buffer still attached.

In this way we lose the currently RX-ed packet, but whenever next calls to
pci_map_single will succeed again,then the RX process will go on without stuck.

Signed-off-by: andrea merello 
Signed-off-by: John W. Linville

wireless: delete non-required instances of include

2014-01-03T20:37:01+00:00

None of these files are actually using any __init type directives
and hence don't need to include .  Most are just a
left over from __devinit and __cpuinit removal, or simply due to
code getting copied from one driver to the next.

Signed-off-by: Paul Gortmaker 
Acked-by: Larry Finger 
Acked-by: Christian Lamparter 
Acked-by: Gertjan van Wingerde 
Signed-off-by: John W. Linville

rtl8187: Increase RX queue depth

2013-12-05T19:54:53+00:00

Under heavy load, the relatively small number of RX queue entries are
completely filled. With an increase from 16 to 32 entries, this condition
rarely happens.

Signed-off-by: Larry Finger 
Signed-off-by: John W. Linville

wireless: rtl818x: remove unnecessary pci_set_drvdata()

2013-09-26T19:13:45+00:00

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han 
Signed-off-by: John W. Linville

rtl8187: fix use after free on failure path in rtl8187_init_urbs()

2013-09-09T18:42:00+00:00

In case of __dev_alloc_skb() failure rtl8187_init_urbs()
calls usb_free_urb(entry) where 'entry' can points to urb
allocated at the previous iteration. That means refcnt will be
decremented incorrectly and the urb can be used after memory
deallocation.

The patch fixes the issue and implements error handling of init_urbs
in rtl8187_start().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Signed-off-by: John W. Linville

Update e-mail address for Andrea Merello (resubmit)

2013-08-26T18:10:40+00:00

A lot of files contain reference to my old e-mail address.
Now I'm going not to read mail from it anymore, so update it
with my current address everywhere.

Signed-off-by: Andrea Merello 
Signed-off-by: John W. Linville

mac80211: Use a cfg80211_chan_def in ieee80211_hw_conf_chan

2013-03-25T18:19:35+00:00

Drivers that don't use chanctxes cannot perform VHT association because
they still use a "backward compatibility" pair of {ieee80211_channel,
nl80211_channel_type} in ieee80211_conf and ieee80211_local.

Signed-off-by: Karl Beldan 
[fix kernel-doc]
Signed-off-by: Johannes Berg

drivers/net/wireless/rtl818x: remove depends on CONFIG_EXPERIMENTAL

2013-01-22T20:01:35+00:00

The CONFIG_EXPERIMENTAL config item has not carried much meaning for a
while now and is almost always enabled by default. As agreed during the
Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

Acked-by: John W. Linville 
Acked-by: David S. Miller 
Signed-off-by: Kees Cook 
Signed-off-by: Greg Kroah-Hartman