linux-toradex.git/drivers/net, branch v2.6.27.38

net: Fix wrong sizeof

2009-10-12T18:32:48+00:00

commit b607bd900051efc3308c4edc65dd98b34b230021 upstream.

Which is why I have always preferred sizeof(struct foo) over
sizeof(var).

Signed-off-by: Jean Delvare 
Acked-by: Randy Dunlap 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

pcnet_cs: Fix misuse of the equality operator.

2009-10-05T15:11:44+00:00

commit a9d3a146923d374b945aa388dc884df69564a818 upstream.

Signed-off-by: Cord Walter 
Signed-off-by: Komuro 
Signed-off-by: David S. Miller 
Cc: Christoph Biedl 
Signed-off-by: Greg Kroah-Hartman

enc28j60: fix RX buffer overflow

2009-10-05T15:11:43+00:00

commit 22692018b93f0782cda5a843cecfffda1854eb8d upstream.

The enc28j60 driver doesn't check whether the length of the packet as reported
by the hardware fits into the preallocated buffer. When stressed, the hardware
may report insanely large packets even tough the "Receive OK" bit is set. Fix
this.

Signed-off-by: Baruch Siach 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

p54usb: add Zcomax XG-705A usbid

2009-10-05T15:11:41+00:00

commit f7f71173ea69d4dabf166533beffa9294090b7ef upstream.

This patch adds a new usbid for Zcomax XG-705A to the device table.

Reported-by: Jari Jaakola 
Signed-off-by: Christian Lamparter 
Signed-off-by: John W. Linville 
Signed-off-by: Greg Kroah-Hartman

E100: fix interaction with swiotlb on X86.

2009-09-15T17:37:19+00:00

[ Upstream commit 6ff9c2e7fa8ca63a575792534b63c5092099c286 ]

E100 places it's RX packet descriptors inside skb->data and uses them
with bidirectional streaming DMA mapping. Data in descriptors is
accessed simultaneously by the chip (writing status and size when
a packet is received) and CPU (reading to check if the packet was
received). This isn't a valid usage of PCI DMA API, which requires use
of the coherent (consistent) memory for such purpose. Unfortunately e100
chips working in "simplified" RX mode have to store received data
directly after the descriptor. Fixing the driver to conform to the API
would require using unsupported "flexible" RX mode or receiving data
into a coherent memory and using CPU to copy it to network buffers.

This patch, while not yet making the driver conform to the PCI DMA API,
allows it to work correctly on X86 with swiotlb (while not breaking
other architectures).

Signed-off-by: Krzysztof Hałasa 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

ehea: Fix napi list corruption on ifconfig down

2009-09-09T03:16:54+00:00

commit 357eb46d8f275b4e8484541234ea3ba06065e258 upstream.

This patch fixes the napi list handling when an ehea interface is shut
down to avoid corruption of the napi list.

Signed-off-by: Hannes Hering 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

asix: new device ids

2009-08-16T21:27:08+00:00

commit fef7cc0893146550b286b13c0e6e914556142730 upstream.

This patch adds two new device ids to the asix driver.

One comes directly from the asix driver on their web site, the other was
reported by Armani Liao as needed for the MSI X320 to get the driver to
work properly for it.

Reported-by: Armani Liao 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: David S. Miller

NET: Fix locking issues in PPP, 6pack, mkiss and strip line disciplines.

2009-07-30T23:06:15+00:00

[ Upstream commit adeab1afb7de89555c69aab5ca21300c14af6369 ]

Guido Trentalancia reports:

I am trying to use the kiss driver in the Linux kernel that is being
shipped with Fedora 10 but unfortunately I get the following oops:

mkiss: AX.25 Multikiss, Hans Albas PE1AYX
mkiss: ax0: crc mode is auto.
ADDRCONF(NETDEV_CHANGE): ax0: link becomes ready
------------[ cut here ]------------
WARNING: at kernel/softirq.c:77 __local_bh_disable+0x2f/0x83() (Not
tainted)
[...]
unloaded: microcode]
Pid: 0, comm: swapper Not tainted 2.6.27.25-170.2.72.fc10.i686 #1
 [] warn_on_slowpath+0x65/0x8b
 [] ? _spin_unlock_irqrestore+0x22/0x38
 [] ? __enqueue_entity+0xe3/0xeb
 [] ? enqueue_entity+0x203/0x20b
 [] ? enqueue_task_fair+0x3b/0x3f
 [] ? resched_task+0x3a/0x6e
 [] ? _spin_unlock_irqrestore+0x22/0x38
 [] ? _spin_lock_bh+0xb/0x16
 [] __local_bh_disable+0x2f/0x83
 [] local_bh_disable+0xb/0xd
 [] _spin_lock_bh+0xb/0x16
 [] mkiss_receive_buf+0x2fb/0x3a6 [mkiss]
 [] flush_to_ldisc+0xf7/0x198
 [] tty_flip_buffer_push+0x41/0x51
 [] ftdi_process_read+0x375/0x4ad [ftdi_sio]
 [] ftdi_read_bulk_callback+0x130/0x138 [ftdi_sio]
 [] usb_hcd_giveback_urb+0x63/0x93
 [] uhci_giveback_urb+0xe5/0x15f
 [] uhci_scan_schedule+0x52e/0x767
 [] ? psmouse_handle_byte+0xc/0xe5
 [] ? acpi_ev_gpe_detect+0xd6/0xe1
 [] uhci_irq+0x110/0x125
 [] usb_hcd_irq+0x40/0xa3
 [] handle_IRQ_event+0x2f/0x64
 [] handle_level_irq+0x74/0xbe
 [] ? handle_level_irq+0x0/0xbe
 [] do_IRQ+0xc7/0xfe
 [] common_interrupt+0x28/0x30
 [] ? acpi_idle_enter_simple+0x162/0x19d
 [] cpuidle_idle_call+0x60/0x92
 [] cpu_idle+0x101/0x134
 [] rest_init+0x4e/0x50
 =======================
---[ end trace b7cc8076093467ad ]---
------------[ cut here ]------------
WARNING: at kernel/softirq.c:136 _local_bh_enable_ip+0x3d/0xc4()
[...]
Pid: 0, comm: swapper Tainted: G        W 2.6.27.25-170.2.72.fc10.i686
 [] warn_on_slowpath+0x65/0x8b
 [] ? _spin_unlock_irqrestore+0x22/0x38
 [] ? __enqueue_entity+0xe3/0xeb
 [] ? enqueue_entity+0x203/0x20b
 [] ? enqueue_task_fair+0x3b/0x3f
 [] ? resched_task+0x3a/0x6e
 [] ? _spin_unlock_irqrestore+0x22/0x38
 [] ? _spin_lock_bh+0xb/0x16
 [] ? mkiss_receive_buf+0x33d/0x3a6 [mkiss]
 [] _local_bh_enable_ip+0x3d/0xc4
 [] local_bh_enable_ip+0x8/0xa
 [] _spin_unlock_bh+0x11/0x13
 [] mkiss_receive_buf+0x33d/0x3a6 [mkiss]
 [] flush_to_ldisc+0xf7/0x198
 [] tty_flip_buffer_push+0x41/0x51
 [] ftdi_process_read+0x375/0x4ad [ftdi_sio]
 [] ftdi_read_bulk_callback+0x130/0x138 [ftdi_sio]
 [] usb_hcd_giveback_urb+0x63/0x93
 [] uhci_giveback_urb+0xe5/0x15f
 [] uhci_scan_schedule+0x52e/0x767
 [] ? psmouse_handle_byte+0xc/0xe5
 [] ? acpi_ev_gpe_detect+0xd6/0xe1
 [] uhci_irq+0x110/0x125
 [] usb_hcd_irq+0x40/0xa3
 [] handle_IRQ_event+0x2f/0x64
 [] handle_level_irq+0x74/0xbe
 [] ? handle_level_irq+0x0/0xbe
 [] do_IRQ+0xc7/0xfe
 [] common_interrupt+0x28/0x30
 [] ? acpi_idle_enter_simple+0x162/0x19d
 [] cpuidle_idle_call+0x60/0x92
 [] cpu_idle+0x101/0x134
 [] rest_init+0x4e/0x50
 =======================
---[ end trace b7cc8076093467ad ]---
mkiss: ax0: Trying crc-smack
mkiss: ax0: Trying crc-flexnet

The issue was, that the locking code in mkiss was assuming it was only
ever being called in process or bh context.  Fixed by converting the
involved locking code to use irq-safe locks.

Review of other networking line disciplines shows that 6pack, both sync
and async PPP and STRIP have similar issues.  The ppp_async one is the
most interesting one as it sorts out half of the issue as far back as
2004 in commit http://git.kernel.org/?p=linux/kernel/git/tglx/history.git;a=commitdiff;h=2996d8deaeddd01820691a872550dc0cfba0c37d

Signed-off-by: Ralf Baechle 
Reported-by: Guido Trentalancia 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

E100: work around the driver using streaming DMA mapping for RX descriptors.

2009-07-30T23:06:14+00:00

[ Upstream commit 303d67c288319768b19ed8dbed429fef7eb7c275 ]

E100 places it's RX packet descriptors inside skb->data and uses them
with bidirectional streaming DMA mapping. Unfortunately it fails to
transfer skb->data ownership to the device after it reads the
descriptor's status, breaking on non-coherent (e.g., ARM) platforms.

This have to be converted to use coherent memory for the descriptors.

Signed-off-by: Krzysztof Halasa 
Acked-by: Jeff Kirsher 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

r8169: avoid losing MSI interrupts

2009-07-30T23:06:14+00:00

[ Upstream commit f11a377b3f4e897d11f0e8d1fc688667e2f19708 ]

The 8169 chip only generates MSI interrupts when all enabled event
sources are quiescent and one or more sources transition to active. If
not all of the active events are acknowledged, or a new event becomes
active while the existing ones are cleared in the handler, we will not
see a new interrupt.

The current interrupt handler masks off the Rx and Tx events once the
NAPI handler has been scheduled, which opens a race window in which we
can get another Rx or Tx event and never ACK'ing it, stopping all
activity until the link is reset (ifconfig down/up). Fix this by always
ACK'ing all event sources, and loop in the handler until we have all
sources quiescent.

Signed-off-by: David Dillow 
Tested-by: Michael Buesch 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman