linux-toradex.git/drivers/net, branch v4.6-rc7

net: macb: Probe MDIO bus before registering netdev

2016-05-03T20:06:05+00:00

The current sequence makes us register for a network device prior to
registering and probing the MDIO bus which could lead to some unwanted
consequences, like a thread of execution calling into ndo_open before
register_netdev() returns, while the MDIO bus is not ready yet.

Rework the sequence to register for the MDIO bus, and therefore attach
to a PHY prior to calling register_netdev(), which implies reworking the
error path a bit.

Signed-off-by: Florian Fainelli 
Acked-by: Nicolas Ferre 
Signed-off-by: David S. Miller

net: mvneta: Remove superfluous SMP function call

2016-05-03T19:27:18+00:00

Since commit 3b9d6da67e11 ("cpu/hotplug: Fix rollback during error-out
in __cpu_disable()") it is ensured that callbacks of CPU_ONLINE and
CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP
function calls are no longer required.

Replace smp_call_function_single() with a direct call to
mvneta_percpu_enable() or mvneta_percpu_disable(). The functions do
not require to be called with interrupts disabled, therefore the
smp_call_function_single() calling convention is not preserved.

Cc: Thomas Petazzoni 
Cc: netdev@vger.kernel.org
Signed-off-by: Anna-Maria Gleixner 
Signed-off-by: David S. Miller

macb: fix mdiobus_scan() error check

2016-05-03T19:03:09+00:00

Now mdiobus_scan() returns ERR_PTR(-ENODEV) instead of NULL if the PHY
device ID was read as all ones. As this was not  an error before, this
value  should be filtered out now in this driver.

Fixes: b74766a0a0fe ("phylib: don't return NULL from get_phy_device()")
Signed-off-by: Sergei Shtylyov 
Reviewed-by: Florian Fainelli 
Acked-by: Nicolas Ferre 
Signed-off-by: David S. Miller

pxa168_eth: fix mdiobus_scan() error check

2016-05-03T19:03:08+00:00

Since mdiobus_scan() returns either an error code or NULL on error, the
driver should check  for both,  not only for NULL, otherwise a crash is
imminent...

Reported-by: Arnd Bergmann 
Signed-off-by: Sergei Shtylyov 
Signed-off-by: David S. Miller

net/mlx5e: Use workqueue for vxlan ops

2016-05-03T17:37:26+00:00

The vxlan add/delete port NDOs are called under rcu lock.
The current mlx5e implementation can potentially block in these
calls, which is not allowed.  Move to using the mlx5e workqueue
to handle these NDOs.

Fixes: b3f63c3d5e2c ('net/mlx5e: Add netdev support for VXLAN tunneling')
Signed-off-by: Matthew Finlay 
Signed-off-by: Saeed Mahameed 
Signed-off-by: David S. Miller

net/mlx5e: Implement a mlx5e workqueue

2016-05-03T17:37:26+00:00

Implement a mlx5e workqueue to handle all mlx5e specific tasks.  Move
all tasks currently using the system workqueue to the new workqueue.
This is in preparation for vxlan using the mlx5e workqueue in order to
schedule port add/remove operations.

Signed-off-by: Matthew Finlay 
Signed-off-by: Saeed Mahameed 
Signed-off-by: David S. Miller

net/mlx5: Kconfig: Fix MLX5_EN/VXLAN build issue

2016-05-03T17:37:26+00:00

When MLX5_EN=y MLX5_CORE=y and VXLAN=m there is a linker error for
vxlan_get_rx_port() due to the fact that VXLAN is a module. Change Kconfig
to select VXLAN when MLX5_CORE=y. When MLX5_CORE=m there is no dependency
on the value of VXLAN.

Fixes: b3f63c3d5e2c ('net/mlx5e: Add netdev support for VXLAN tunneling')
Signed-off-by: Matthew Finlay 
Reported-by: Arnd Bergmann 
Signed-off-by: Saeed Mahameed 
Signed-off-by: David S. Miller

net/mlx5: Unmap only the relevant IO memory mapping

2016-05-03T17:37:25+00:00

When freeing UAR the driver tries to unmap uar->map and uar->bf_map
which are mutually exclusive thus always unmapping a NULL pointer.
Make sure we only call iounmap() once, for the actual mapping.

Fixes: 0ba422410bbf ('net/mlx5: Fix global UAR mapping')
Signed-off-by: Gal Pressman 
Reported-by: Doron Tsur 
Signed-off-by: Saeed Mahameed 
Signed-off-by: David S. Miller

cxgb3: fix out of bounds read

2016-05-02T00:59:43+00:00

An out of bounds read of 2 bytes was discovered in cxgb3 with KASAN.

t3_config_rss() expects both arrays it gets as parameters to have
terminators. setup_rss(), the caller, forgets to add a terminator to
one of the arrays. Thankfully the iteration in t3_config_rss() stops
anyway, but in the last iteration the check for the terminator
is an out of bounds read.

Add the missing terminator to rspq_map[].

Reported-by: Jan Stancek 
Signed-off-by: Michal Schmidt 
Signed-off-by: David S. Miller

net/smscx5xx: use the device tree for mac address

2016-05-02T00:57:45+00:00

This takes the MAC address for smsc75xx/smsc95xx USB network devices
from a the device tree. This is required to get a usable persistent
address on the popular beagleboard, whose hardware designers
accidentally forgot that an ethernet device really requires an a
MAC address to be functional.

The Raspberry Pi also ships smsc9514 without a serial EEPROM, stores
the MAC address in ROM accessible via VC4 firmware.

The smsc75xx and smsc95xx drivers are just two copies of the
same code, so better fix both.

[lkundrak@v3.sk: updated to use of_get_property() as per suggestion from
Arnd, reworded the message and comments a bit]

Tested-by: Lubomir Rintel 
Signed-off-by: Arnd Bergmann 
Signed-off-by: Lubomir Rintel 
Signed-off-by: David S. Miller