linux-toradex.git/drivers/nfc/pn533, branch v5.17

nfc: pn533: Fix double free when pn533_fill_fragment_skbs() fails

2021-11-07T19:37:04+00:00

skb is already freed by dev_kfree_skb in pn533_fill_fragment_skbs,
but follow error handler branch when pn533_fill_fragment_skbs()
fails, skb is freed again, results in double free issue. Fix this
by not free skb in error path of pn533_fill_fragment_skbs.

Fixes: 963a82e07d4e ("NFC: pn533: Split large Tx frames in chunks")
Fixes: 93ad42020c2d ("NFC: pn533: Target mode Tx fragmentation support")
Signed-off-by: Chengfeng Ye 
Reviewed-by: Dan Carpenter 
Reviewed-by: Krzysztof Kozlowski 
Signed-off-by: David S. Miller

nfc: pn533: Constify pn533_phy_ops

2021-10-07T12:35:10+00:00

Neither the driver or the core modifies the pn533_phy_ops struct, so
make them const to allow the compiler to put the static structs in
read-only memory.

Signed-off-by: Rikard Falkeborn 
Signed-off-by: David S. Miller

nfc: pn533: Constify serdev_device_ops

2021-10-07T12:35:10+00:00

The only usage of pn532_serdev_ops is to pass its address to
serdev_device_set_client_ops(), which takes a pointer to const
serdev_device_ops as argument. Make it const to allow the compiler to
put it in read-only memory.

Signed-off-by: Rikard Falkeborn 
Signed-off-by: David S. Miller

nfc: pn533: use dev_err() instead of pr_err()

2021-09-13T13:38:00+00:00

Print error message with reference to a device.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: David S. Miller

nfc: pn533: drop unneeded debug prints

2021-09-13T13:38:00+00:00

ftrace is a preferred and standard way to debug entering and exiting
functions so drop useless debug prints.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: David S. Miller

nfc: constify nfc_ops

2021-07-25T08:21:21+00:00

Neither the core nor the drivers modify the passed pointer to struct
nfc_ops, so make it a pointer to const for correctness and safety.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: David S. Miller

nfc: pn533: drop unneeded braces {} in if

2021-06-01T04:32:37+00:00

{} braces are not needed over single if-statement.

Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20210531073902.7111-3-krzysztof.kozlowski@canonical.com
Signed-off-by: Jakub Kicinski

nfc: pn533: drop ftrace-like debugging messages

2021-06-01T04:32:37+00:00

Now that the kernel has ftrace, any debugging calls that just do "made
it to this function!" and "leaving this function!" can be removed.
Better to use standard debugging tools.

Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20210531073902.7111-2-krzysztof.kozlowski@canonical.com
Signed-off-by: Jakub Kicinski

nfc: pn533: mark OF device ID tables as maybe unused

2021-05-28T22:05:55+00:00

The driver can match either via OF or I2C ID tables.  If OF is disabled,
the table will be unused:

    drivers/nfc/pn533/i2c.c:252:34: warning:
        ‘of_pn533_i2c_match’ defined but not used [-Wunused-const-variable=]

Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20210528124200.79655-7-krzysztof.kozlowski@canonical.com
Signed-off-by: Jakub Kicinski

nfc: pn533: drop of_match_ptr from device ID table

2021-05-28T22:05:55+00:00

The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it might be not relevant here).  This
fixes compile warning (!CONFIG_OF):

    drivers/nfc/pn533/i2c.c:252:34: warning:
      ‘of_pn533_i2c_match’ defined but not used [-Wunused-const-variable=]

Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20210528124200.79655-4-krzysztof.kozlowski@canonical.com
Signed-off-by: Jakub Kicinski