linux-toradex.git/drivers/nfc/pn544, branch v5.17-rc4

nfc: pn544: make array rset_cmd static const

2022-01-12T05:09:03+00:00

Don't populate the read-only array rset_cmd on the stack but
instead it static const. Also makes the object code a little smaller.

Signed-off-by: Colin Ian King 
Reviewed-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20220109202418.50641-1-colin.i.king@gmail.com
Signed-off-by: Jakub Kicinski

nfc: pn544: drop unneeded memory allocation fail messages

2021-09-13T13:38:01+00:00

nfc_mei_phy_alloc() already prints an error message on memory allocation
failure.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: David S. Miller

nfc: pn544: drop unneeded debug prints

2021-09-13T13:38:00+00:00

ftrace is a preferred and standard way to debug entering and exiting
functions so drop useless debug prints.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: David S. Miller

nfc: pn544: remove unused header includes

2021-08-26T08:13:36+00:00

Do not include unnecessary headers.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: David S. Miller

nfc: constify local pointer variables

2021-07-30T15:22:52+00:00

Few pointers to struct nfc_target and struct nfc_se can be made const.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Jakub Kicinski

nfc: constify nfc_hci_ops

2021-07-25T08:21:21+00:00

Neither the core nor the drivers modify the passed pointer to struct
nfc_hci_ops, so make it a pointer to const for correctness and safety.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: David S. Miller

nfc: constify nfc_hci_gate

2021-07-25T08:21:21+00:00

Neither the core nor the drivers modify the passed pointer to struct
nfc_hci_gate, so make it a pointer to const for correctness and safety.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: David S. Miller

nfc: constify nfc_phy_ops

2021-07-25T08:21:21+00:00

Neither the core nor the drivers modify the passed pointer to struct
nfc_phy_ops (consisting of function pointers), so make it a pointer
to const for correctness and safety.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: David S. Miller

nfc: pn544: drop ftrace-like debugging messages

2021-06-01T04:32:37+00:00

Now that the kernel has ftrace, any debugging calls that just do "made
it to this function!" and "leaving this function!" can be removed.
Better to use standard debugging tools.

Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20210531073902.7111-4-krzysztof.kozlowski@canonical.com
Signed-off-by: Jakub Kicinski

nfc: pn544: mark ACPI and OF device ID tables as maybe unused

2021-05-28T22:05:56+00:00

The driver can match either via OF or ACPI ID tables.  If one
configuration is disabled, the table will be unused:

    drivers/nfc/pn544/i2c.c:53:36: warning:
        ‘pn544_hci_i2c_acpi_match’ defined but not used [-Wunused-const-variable=]

Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20210528124200.79655-9-krzysztof.kozlowski@canonical.com
Signed-off-by: Jakub Kicinski