linux-toradex.git/drivers/nfc/port100.c, branch v4.9.123

nfc: Fix hangup of RC-S380* in port100_send_ack()

2017-08-07T01:59:41+00:00

commit 2497128133f8169b24b928852ba6eae34fc495e5 upstream.

If port100_send_ack() was called twice or more, it has race to hangup.

  port100_send_ack()          port100_send_ack()
    init_completion()
    [...]
    dev->cmd_cancel = true
                                /* this removes previous from completion */
                                init_completion()
				[...]
                                dev->cmd_cancel = true
                                wait_for_completion()
    /* never be waked up */
    wait_for_completion()

Like above race, this code is not assuming port100_send_ack() is
called twice or more.

To fix, this checks dev->cmd_cancel to know if prior cancel is
in-flight or not. And never be remove prior task from completion by
using reinit_completion(), so this guarantees to be waked up properly
soon or later.

Signed-off-by: OGAWA Hirofumi 
Signed-off-by: Samuel Ortiz 
Signed-off-by: Amit Pundir 
Signed-off-by: Greg Kroah-Hartman

NFC: port100: Abort current command before switching RF off

2016-07-06T08:02:08+00:00

If a command is still being processed by the device, the switch RF off
command will be rejected. With this patch, the port100 driver calls
port100_abort_cmd() before sending the switch RF off command.

Signed-off-by: Thierry Escande 
Signed-off-by: Samuel Ortiz

NFC: port100: Make port100_abort_cmd() synchronous

2016-07-06T08:02:08+00:00

This patch makes the abort_cmd function synchronous. This allows the
caller to immediately send a new command after abort_cmd() returns.

Signed-off-by: Thierry Escande 
Signed-off-by: Samuel Ortiz

NFC: port100: Fix the command cancellation process

2016-07-06T08:02:07+00:00

The USB out_urb used to send commands to the device can be submitted
through the standard command processing queue coming from the Digital
Protocol layer but it can also be submitted from port100_abort_cmd().

To not submit the URB while already active, a mutex is now used to
protect it and a cmd_cancel flag is used to not send command while
canceling the previous one.

Signed-off-by: Thierry Escande 
Signed-off-by: Samuel Ortiz

NFC: port100: Don't send a new command if one is still pending

2016-07-06T08:02:07+00:00

This patch ensures that a command is not still in process before sending
a new one to the device. This can happen when neard is in constant
polling mode: the configure_hw command can be sent when neard restarts
polling after a LLCP SYMM timeout but before the device has returned in
timeout from the last DEP frame sent.

Signed-off-by: Thierry Escande 
Signed-off-by: Samuel Ortiz

NFC: port100: Explicitly set NFC-F framing for NFC-DEP

2016-07-04T10:26:27+00:00

When setting the driver framing as NFC_DIGITAL_FRAMING_NFCF_NFC_DEP it
used to be already configured as NFC_DIGITAL_FRAMING_NFCF which is the
same. So this entry was empty in the in_protocols table.
Now that the digital stack can handle PLS requests, it can be changed
on the fly from NFC_DIGITAL_FRAMING_NFCA_NFC_DEP.
This patch explicitly defines the framing configuration values for
NFC_DIGITAL_FRAMING_NFCF_NFC_DEP.

Signed-off-by: Thierry Escande 
Signed-off-by: Samuel Ortiz

NFC: logging neatening

2015-04-07T10:05:12+00:00

Add missing terminating newlines to nfc_info and nfc_err
to avoid possible interleaving from other messages.

Miscellanea:

o typo fix of "unknonwn" in message
o remove unnecessary OOM messages as there's a generic dump_stack()
o realign arguments

Signed-off-by: Joe Perches 
Signed-off-by: Samuel Ortiz

NFC: port100: Add support for type 4B tag

2014-05-25T22:42:02+00:00

This patch adds support for ISO-DEP protocol over NFC-B rf technology
by adding NFC_PROTO_ISO14443_B to the supported protocols and an entry
for framing configuration.

Signed-off-by: Thierry Escande 
Signed-off-by: Samuel Ortiz

NFC: port100: Convert to use USB_DEVICE macro

2014-02-23T22:32:18+00:00

Signed-off-by: Axel Lin 
Signed-off-by: Samuel Ortiz

NFC: port100: Add support for type 4A tag platform

2014-02-16T22:49:54+00:00

This adds support for ISO-DEP protocol over NFC-A rf technology. The
port100 already supports NFC-A and ATS request and response for type 4A
tags are handled at digital level. This patch adds NFC_PROTO_ISO14443
to the supported protocols and an entry for framing configuration which
is the same as NFC-A standard frame with CRC handling.

Signed-off-by: Thierry Escande 
Signed-off-by: Samuel Ortiz