linux-toradex.git/drivers/nfc, branch v3.7 Linux kernel for Apalis and Colibri modules NFC: Fix pn533 target mode memory leak 2012-11-19T23:09:26+00:00 Thierry Escande thierry.escande@linux.intel.com 2012-11-15T17:24:28+00:00 5b412fd11c918171c98a253d8a3484afa9f69ca5 In target mode, sent sk_buff were not freed in pn533_tm_send_complete Signed-off-by: Thierry Escande <thierry.escande@linux.intel.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> 
In target mode, sent sk_buff were not freed in pn533_tm_send_complete

Signed-off-by: Thierry Escande <thierry.escande@linux.intel.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
NFC: pn533: Fix mem leak in pn533_in_dep_link_up 2012-11-19T23:09:26+00:00 Waldemar Rymarkiewicz waldemar.rymarkiewicz@tieto.com 2012-10-11T12:04:00+00:00 70418e6efcf4f8652cc08e3f2ab8ae35f0948fd9 cmd is allocated in pn533_dep_link_up and passed as an arg to pn533_send_cmd_frame_async together with a complete cb. arg is passed to the cb and must be kfreed there. Signed-off-by: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> 
cmd is allocated in pn533_dep_link_up and passed as an arg to
pn533_send_cmd_frame_async together with a complete cb.

arg is passed to the cb and must be kfreed there.

Signed-off-by: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
NFC: pn533: Fix use after free 2012-11-19T23:09:26+00:00 Szymon Janc szymon.janc@tieto.com 2012-10-29T13:04:43+00:00 770f750bc2b8312489c8e45306f551d08a319d3c cmd was freed in pn533_dep_link_up regardless of pn533_send_cmd_frame_async return code. Cmd is passed as argument to pn533_in_dep_link_up_complete callback and should be freed there. Signed-off-by: Szymon Janc <szymon.janc@tieto.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> 
cmd was freed in pn533_dep_link_up regardless of
pn533_send_cmd_frame_async return code. Cmd is passed as argument to
pn533_in_dep_link_up_complete callback and should be freed there.

Signed-off-by: Szymon Janc <szymon.janc@tieto.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
NFC: pn533: Fix missing lock while operating on commands list 2012-11-19T23:09:25+00:00 Szymon Janc szymon.janc@tieto.com 2012-10-25T15:29:45+00:00 60ad07ab6bc86f48b6ebda1788d79ca5f88d824c In pn533_wq_cmd command was removed from list without cmd_lock held (race with pn533_send_cmd_frame_async) which could lead to list corruption. Delete command from list before releasing lock. Signed-off-by: Szymon Janc <szymon.janc@tieto.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> 
In pn533_wq_cmd command was removed from list without cmd_lock held
(race with pn533_send_cmd_frame_async) which could lead to list
corruption. Delete command from list before releasing lock.

Signed-off-by: Szymon Janc <szymon.janc@tieto.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
NFC: Fix missing mutex unlock in pn533_send_cmd_frame_async 2012-09-27T08:47:48+00:00 Szymon Janc szymon.janc@tieto.com 2012-09-27T07:16:54+00:00 ee5e8d812ca25bf95a97b4368aec4e680678e75e If command allocation failed cmd_lock was not released and deadlock would occur. Signed-off-by: Szymon Janc <szymon.janc@tieto.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> 
If command allocation failed cmd_lock was not released and deadlock
would occur.

Signed-off-by: Szymon Janc <szymon.janc@tieto.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
NFC: xmit from hci ops must return 0 or negative 2012-09-24T22:17:27+00:00 Waldemar Rymarkiewicz waldemar.rymarkiewicz@tieto.com 2012-09-20T06:59:10+00:00 96e324024b421b3753eb142d5d92fbe4ac5e7519 xmit callback provided by a driver encapsulates upper layers data and sends it to the hardware. So, HCI does not know the exact amount of data being sent and thus can't handle partially sent frames properly. Therefore, the driver must return 0 for completely sent frame or negative for failure. Signed-off-by: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com> Acked-by: Eric Lapuyade <eric.lapuyade@intel.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> 
xmit callback provided by a driver encapsulates upper layers
data and sends it to the hardware. So, HCI does not know the
exact amount of data being sent and thus can't handle partially
sent frames properly.

Therefore, the driver must return 0 for completely sent frame or
negative for failure.

Signed-off-by: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com>
Acked-by: Eric Lapuyade <eric.lapuyade@intel.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
NFC: Remove the pn544 raw driver 2012-09-24T22:17:27+00:00 Cong Wang xiyou.wangcong@gmail.com 2012-09-18T17:31:58+00:00 7b55279f6a454771d06e8ddf4a7114d17ae9a741 This was scheduled for 3.6, we're late. Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Acked-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> 
This was scheduled for 3.6, we're late.

Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
NFC: Move the pn544_hci dereference below the NULL test 2012-09-24T22:17:26+00:00 Wei Yongjun yongjun_wei@trendmicro.com.cn 2012-09-08T13:19:44+00:00 c51ad34e542606854d0545533329e916689599ba The dereference should be moved below the NULL test. spatch with a semantic match is used to found this. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> 
The dereference should be moved below the NULL test.

spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
NFC: Move the nfcwilink dereference below the NULL test 2012-09-24T22:17:26+00:00 Wei Yongjun yongjun_wei@trendmicro.com.cn 2012-09-08T01:53:22+00:00 d6650a2ccfdcf536841c2f880a1a6f19fce2e3a1 spatch with a semantic match is used to found this. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> 
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
NFC: Changed HCI and PN544 HCI driver to use the new HCI LLC Core 2012-09-24T22:17:26+00:00 Eric Lapuyade eric.lapuyade@linux.intel.com 2012-09-18T17:45:48+00:00 412fda538f4b1317ecd0fbe6e5bc9124792bea88 The previous shdlc HCI driver and its header are removed from the tree. PN544 now registers directly with HCI and passes the name of the llc it requires (shdlc). HCI instantiation now allocates the required llc instance. The llc is started when the HCI device is brought up. Signed-off-by: Eric Lapuyade <eric.lapuyade@intel.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> 
The previous shdlc HCI driver and its header are removed from the tree.
PN544 now registers directly with HCI and passes the name of the llc it
requires (shdlc).
HCI instantiation now allocates the required llc instance. The llc is
started when the HCI device is brought up.

Signed-off-by: Eric Lapuyade <eric.lapuyade@intel.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>