linux-toradex.git/drivers/ntb/test, branch v4.9.16

ntb: ntb_perf missing dmaengine_unmap_put

2017-02-23T16:44:36+00:00

commit 9644347c5240d0ee3ba7472ef332aaa4ff4db398 upstream.

In the normal I/O execution path, ntb_perf is missing a call to
dmaengine_unmap_put() after submission. That causes us to leak
unmap objects.

Signed-off-by: Dave Jiang 
Fixes: 8a7b6a77 ("ntb: ntb perf tool")
Signed-off-by: Jon Mason 
Signed-off-by: Greg Kroah-Hartman

ntb_perf: potential info leak in debugfs

2016-11-13T21:48:30+00:00

This is a static checker warning, not something I'm desperately
concerned about.  But snprintf() returns the number of bytes that
would have been copied if there were space.  We really care about the
number of bytes that actually were copied so we should use scnprintf()
instead.

It probably won't overrun, and in that case we may as well just use
sprintf() but these sorts of things make static checkers and code
reviewers happier.

Signed-off-by: Dan Carpenter 
Acked-by: Dave Jiang 
Signed-off-by: Jon Mason

ntb: make DMA_OUT_RESOURCE_TO HZ independent

2016-11-13T21:48:29+00:00

schedule_timeout_* takes a timeout in jiffies but the code currently is
passing in a constant which makes this timeout HZ dependent, so pass it
through msecs_to_jiffies() to fix this up.

Signed-off-by: Nicholas Mc Guire 
Acked-by: Dave Jiang 
Signed-off-by: Jon Mason

ntb_pingpong: Fix db_init parameter description

2016-11-13T21:48:29+00:00

Fix 'db_init' parameter description.

Signed-off-by: Wei Yongjun 
Acked-by: Allen Hubbe 
Signed-off-by: Jon Mason

ntb_perf: clear link_is_up flag when the link goes down.

2016-08-05T14:21:08+00:00

When the link goes down, the link_is_up flag did not return to
false. This could have caused some subtle corner case bugs
when the link goes up and down quickly.

Once that was fixed, there was found to be a race if the link was
brought down then immediately up. The link_cleanup work would
occasionally be scheduled after the next link up event. This would
cancel the link_work that was supposed to occur and leave ntb_perf
in an unusable state.

To fix this we get rid of the link_cleanup work and put the actions
directly in the link_down event.

Signed-off-by: Logan Gunthorpe 
Acked-by: Dave Jiang 
Signed-off-by: Jon Mason

ntb_pingpong: Add a debugfs file to get the ping count

2016-08-05T14:21:07+00:00

This commit adds a debugfs 'count' file to ntb_pingpong. This is so
testing with ntb_pingpong can be automated beyond just checking the
logs for pong messages.

The count file returns a number which increments every pong. The
counter can be cleared by writing a zero.

Signed-off-by: Logan Gunthorpe 
Acked-by: Allen Hubbe 
Signed-off-by: Jon Mason

ntb_tool: Add link status and files to debugfs

2016-08-05T14:21:07+00:00

In order to more successfully script with ntb_tool it's useful to
have a link file to check the link status so that the script
doesn't use the other files until the link is up.

This commit adds a 'link' file to the debugfs directory which reads
boolean (Y or N) depending on the link status. Writing to the file
change the link state using ntb_link_enable or ntb_link_disable.

A 'link_event' file is also provided so an application can block until
the link changes to the desired state. If the user writes a 1, it will
block until the link is up. If the user writes a 0, it will block until
the link is down.

Signed-off-by: Logan Gunthorpe 
Acked-by: Allen Hubbe 
Signed-off-by: Jon Mason

ntb_tool: Postpone memory window initialization for the user

2016-08-05T14:21:07+00:00

In order to make the interface closer to the raw NTB API, this commit
changes memory windows so they are not initialized on link up.
Instead, the 'peer_trans*' debugfs files are introduced. When read,
they return information provided by ntb_mw_get_range. When written,
they create a buffer and initialize the memory window. The
value written is taken as the requested size of the buffer (which
is then rounded for alignment). Writing a value of zero frees the buffer
and tears down the memory window translation. The 'peer_mw*' file is
only created once the memory window translation is setup by the user.

Additionally, it was noticed that the read and write functions for the
'peer_mw*' files should have checked for a NULL pointer.

Signed-off-by: Logan Gunthorpe 
Acked-by: Allen Hubbe 
Signed-off-by: Jon Mason

ntb_perf: Wait for link before running test

2016-08-05T14:21:07+00:00

Instead of returning immediately with an error when the link is
down, wait for the link to come up (or the user sends a SIGINT).

This is to make scripting ntb_perf easier.

Signed-off-by: Logan Gunthorpe 
Acked-by: Dave Jiang 
Signed-off-by: Jon Mason

ntb_perf: Return results by reading the run file

2016-08-05T14:21:07+00:00

Instead of having to watch logs, allow the results to be retrieved
by reading back the run file. This file will return "running" when
the test is running and nothing if no tests have been run yet.
It returns 1 line per thread, and will display an error message if the
corresponding thread returns an error.

With the above change, the pr_info calls that returned the results are
then changed to pr_debug calls.

Signed-off-by: Logan Gunthorpe 
Acked-by: Dave Jiang 
Signed-off-by: Jon Mason