linux-toradex.git/drivers/ntb/test, branch v6.9-rc4

NTB: ntb_tool: Switch to memdup_user_nul() helper

2023-08-18T13:50:06+00:00

Use memdup_user_nul() helper instead of open-coding to simplify the code.

Signed-off-by: Ruan Jinjie 
Reviewed-by: Dave Jiang 
Reviewed-by: Dan Carpenter 
Reviewed-by: Serge Semin 
Signed-off-by: Jon Mason

dtivers: ntb: fix parameter check in perf_setup_dbgfs()

2023-08-18T13:50:06+00:00

Make IS_ERR() judge the debugfs_create_dir() function return
in perf_setup_dbgfs().

Signed-off-by: Minjie Du 
Reviewed-by: Serge Semin 
Signed-off-by: Jon Mason

ntb: Remove error checking for debugfs_create_dir()

2023-08-18T13:50:06+00:00

It is expected that most callers should _ignore_ the errors
return by debugfs_create_dir() in tool_setup_dbgfs()

Signed-off-by: Wang Ming 
Reviewed-by: Dave Jiang 
Reviewed-by: Dan Carpenter 
Reviewed-by: Serge Semin 
Signed-off-by: Jon Mason

NTB: ntb_tool: Add check for devm_kcalloc

2023-07-08T14:51:56+00:00

As the devm_kcalloc may return NULL pointer,
it should be better to add check for the return
value, as same as the others.

Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support")
Signed-off-by: Jiasheng Jiang 
Reviewed-by: Serge Semin 
Reviewed-by: Dave Jiang 
Signed-off-by: Jon Mason

NTB: ntb_tool: uninitialized heap data in tool_fn_write()

2022-08-09T15:54:41+00:00

The call to:

	ret = simple_write_to_buffer(buf, size, offp, ubuf, size);

will return success if it is able to write even one byte to "buf".
The value of "*offp" controls which byte.  This could result in
reading uninitialized data when we do the sscanf() on the next line.

This code is not really desigined to handle partial writes where
*offp is non-zero and the "buf" is preserved and re-used between writes.
Just ban partial writes and replace the simple_write_to_buffer() with
copy_from_user().

Fixes: 578b881ba9c4 ("NTB: Add tool test client")
Signed-off-by: Dan Carpenter 
Signed-off-by: Jon Mason

ntb: ntb_pingpong: remove redundant initialization of variables msg_data and spad_data

2021-09-05T22:04:46+00:00

The variables msg_data and spad_data are being initialized with values
that are never read, they are being updated later on. The initializations
are redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King 
Acked-by: Serge Semin 
Signed-off-by: Jon Mason

NTB: perf: Fix an error code in perf_setup_inbuf()

2021-09-04T22:36:04+00:00

When the function IS_ALIGNED() returns false, the value of ret is 0.
So, we set ret to -EINVAL to indicate this error.

Clean up smatch warning:
drivers/ntb/test/ntb_perf.c:602 perf_setup_inbuf() warn: missing error
code 'ret'.

Reported-by: Abaci Robot 
Signed-off-by: Yang Li 
Reviewed-by: Serge Semin 
Signed-off-by: Jon Mason

NTB: Fix an error code in ntb_msit_probe()

2021-09-04T22:36:04+00:00

When the value of nm->isr_ctx is false, the value of ret is 0.
So, we set ret to -ENOMEM to indicate this error.

Clean up smatch warning:
drivers/ntb/test/ntb_msi_test.c:373 ntb_msit_probe() warn: missing
error code 'ret'.

Reported-by: Abaci Robot 
Signed-off-by: Yang Li 
Reviewed-by: Logan Gunthorpe 
Signed-off-by: Jon Mason

NTB: Use struct_size() helper in devm_kzalloc()

2020-08-24T14:58:06+00:00

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes. Also, remove unnecessary
variable _struct_size_.

This code was detected with the help of Coccinelle and, audited and
fixed manually.

Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83
Signed-off-by: Gustavo A. R. Silva 
Reviewed-by: Logan Gunthorpe 
Signed-off-by: Jon Mason

NTB: perf: Fix race condition when run with ntb_test

2020-06-06T00:02:09+00:00

When running ntb_test, the script tries to run the ntb_perf test
immediately after probing the modules. Since adding multi-port support,
this fails seeing the new initialization procedure in ntb_perf
can not complete instantly.

To fix this we add a completion which is waited on when a test is
started. In this way, run can be written any time after the module is
loaded and it will wait for the initialization to complete instead of
sending an error.

Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support")
Signed-off-by: Logan Gunthorpe 
Acked-by: Allen Hubbe 
Tested-by: Alexander Fomichev 
Signed-off-by: Jon Mason