linux-toradex.git/drivers/ntb, branch v4.4.80

ntb_transport: Pick an unused queue

2017-02-23T16:43:10+00:00

commit 8fcd0950c021d7be8493280541332b924b9de962 upstream.

Fix typo causing ntb_transport_create_queue to select the first
queue every time, instead of using the next free queue.

Signed-off-by: Thomas VanSelus 
Signed-off-by: Aaron Sierra 
Acked-by: Allen Hubbe 
Fixes: fce8a7bb5 ("PCI-Express Non-Transparent Bridge Support")
Signed-off-by: Jon Mason 
Signed-off-by: Greg Kroah-Hartman

NTB: ntb_transport: fix debugfs_remove_recursive

2017-02-23T16:43:10+00:00

commit dd62245e73de9138333cb0e7a42c8bc1215c3ce6 upstream.

The call to debugfs_remove_recursive(qp->debugfs_dir) of the sub-level
directory must not be later than
debugfs_remove_recursive(nt_debugfs_dir) of the top-level directory.
Otherwise, the sub-level directory will not exist, and it would be
invalid (panic) to attempt to remove it.  This removes the top-level
directory last, after sub-level directories have been cleaned up.

Signed-off-by: Allen Hubbe 
Fixes: e26a5843f ("NTB: Split ntb_hw_intel and ntb_transport drivers")
Signed-off-by: Jon Mason 
Signed-off-by: Greg Kroah-Hartman

NTB: fix 32-bit compiler warning

2015-11-08T21:24:43+00:00

resource_size_t may be 32-bit wide on some architectures, which causes
this warning when building the NTB code:

drivers/ntb/ntb_transport.c: In function 'ntb_transport_link_work':
drivers/ntb/ntb_transport.c:828:46: warning: right shift count >= width of type [-Wshift-count-overflow]

The warning is harmless but can be avoided by using the upper_32_bits()
macro.

Signed-off-by: Arnd Bergmann 
Fixes: e26a5843f7f5 ("NTB: Split ntb_hw_intel and ntb_transport drivers")
Signed-off-by: Jon Mason

NTB: unify translation addresses

2015-11-08T21:11:21+00:00

There is no need for the upstream and downstream addresses to be different
for the NTB configs. Go to using a single set of address. It is still
possible to configure them differently using module parameter override
however.

Signed-off-by: Dave Jiang 
Acked and Tested-by: Allen Hubbe 
Signed-off-by: Jon Mason

NTB: invalid buf pointer in multi-MW setups

2015-11-08T21:11:21+00:00

Order of operations issue with the QP Num and MW count, which would
result in the receive buffer pointer being invalid if there are more
than 1 MW.  Corrected with parenthesis to enforce the proper order of
operations.

Reported-by: John I. Kading 
Signed-off-by: Jon Mason

NTB: remove unused variable

2015-11-08T21:11:21+00:00

These variables were not used anywhere. So remove them.

Signed-off-by: Sudip Mukherjee 
Signed-off-by: Jon Mason

NTB: fix access of free-ed pointer

2015-11-08T21:11:21+00:00

We were accessing nt->mw_vec after freeing it. Fix the error path so
that we free nt->mw_vec after we have finished using it.

Signed-off-by: Sudip Mukherjee 
Signed-off-by: Jon Mason

NTB: Fix issue where we may be accessing NULL ptr

2015-11-08T21:11:21+00:00

smatch detected an issue in the function ntb_transport_max_size() where
we could be dereferencing a dma channel pointer when it is NULL.

Reported-by: Dan Carpenter 
Signed-off-by: Dave Jiang 
Signed-off-by: Jon Mason

NTB: Fix range check on memory window index

2015-09-07T19:27:12+00:00

The range check must exclude the upper bound.

Signed-off-by: Allen Hubbe 
Signed-off-by: Jon Mason

NTB: Improve index handling in B2B MW workaround

2015-09-07T19:27:12+00:00

Check that b2b_mw_idx is in range of the number of memory windows when
initializing the device.  The workaround is considered to be in effect
only if the device b2b_idx is exactly UINT_MAX, instead of any index
past the last memory window.

Only print B2B MW workaround information in debugfs if the workaround is
in effect.

Signed-off-by: Allen Hubbe 
Signed-off-by: Jon Mason