linux-toradex.git/drivers/nvme/host, branch v4.10

nvme-fc: use blk_rq_nr_phys_segments

2017-01-26T15:49:14+00:00

Without this deallocate won't work properly due to the mismatch
of the bio/request size and the actual payload size.

Signed-off-by: Christoph Hellwig 
Reviewed-by: James Smart 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Sagi Grimberg

nvme: use blk_rq_payload_bytes

2017-01-13T22:17:04+00:00

The new blk_rq_payload_bytes generalizes the payload length hacks
that nvme_map_len did before.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Jens Axboe

nvme: apply DELAY_BEFORE_CHK_RDY quirk at probe time too

2017-01-11T16:21:35+00:00

Commit 54adc01055b7 ("nvme/quirk: Add a delay before checking for adapter
readiness") introduced a quirk to adapters that cannot read the bit
NVME_CSTS_RDY right after register NVME_REG_CC is set; these adapters
need a delay or else the action of reading the bit NVME_CSTS_RDY could
somehow corrupt adapter's registers state and it never recovers.

When this quirk was added, we checked ctrl->tagset in order to avoid
quirking in probe time, supposing we would never require such delay
during probe. Well, it was too optimistic; we in fact need this quirk
at probe time in some cases, like after a kexec.

In some experiments, after abnormal shutdown of machine (aka power cord
unplug), we booted into our bootloader in Power, which is a Linux kernel,
and kexec'ed into another distro. If this kexec is too quick, we end up
reaching the probe of NVMe adapter in that distro when adapter is in
bad state (not fully initialized on our bootloader). What happens next
is that nvme_wait_ready() is unable to complete, except if the quirk is
enabled.

So, this patch removes the original ctrl->tagset verification in order
to enable the quirk even on probe time.

Fixes: 54adc01055b7 ("nvme/quirk: Add a delay before checking for adapter readiness")
Reported-by: Andrew Byrne 
Reported-by: Jaime A. H. Gomez 
Reported-by: Zachary D. Myers 
Signed-off-by: Guilherme G. Piccoli 
Acked-by: Jeffrey Lien 
Signed-off-by: Christoph Hellwig

nvme-rdma: fix nvme_rdma_queue_is_ready

2017-01-11T16:20:39+00:00

Now that we don't abuse the cmd field in struct request for nvme command
passthrough this function needs to be converted to the proper accessor
as well.

Fixes: d49187e97e ("nvme: introduce struct nvme_request")
Signed-off-by: Christoph Hellwig 
Reviewed-by: Max Gurtovoy

Merge branch 'nvme-4.10' of git://git.infradead.org/nvme into for-linus

2016-12-22T18:54:46+00:00

Christoph writes:

The most significant one is that we've agreed on shared maintaince and
a common repository for the PCIe NVMe driver and NVMe over Fabrics.  The
target code still only has a subset of the maintainers but goes through
the same tree as well.  Keith, Sagi and me will take turns at collecting
patches and sending you pull requests.

nvme/fc: simplify error handling of nvme_fc_create_hw_io_queues

2016-12-21T10:34:25+00:00

Simplify the error handling of nvme_fc_create_hw_io_queues(), this saves us
one variable and one level of indentation.

Signed-off-by: Johannes Thumshirn 
Reviwed-by: James Smart 
Signed-off-by: Christoph Hellwig

nvme/fc: correct some printk information

2016-12-21T10:33:31+00:00

Dan Carpenters's tool caught a pointer reference - should have been
just ptr, not &ptr.

Don't bother. Remove the pointer value in the printf. Its irrelevant.

Signed-off-by: James Smart 
Reported-by: Dan Carpenter 
Signed-off-by: Christoph Hellwig

nvme/scsi: Remove START STOP emulation

2016-12-21T10:33:24+00:00

Now that the broken power state control is gone, it appears to serve
no purpose.  Just delete it.  NVME devices don't have a concept of
started vs stopped anyway.

Signed-off-by: Andy Lutomirski 
Reviewed-by: Keith Busch 
Signed-off-by: Christoph Hellwig

nvme/pci: Delete misleading queue-wrap comment

2016-12-21T10:33:23+00:00

It is not theoretically possible for this driver to wrap twice while
processing completions. The driver allocates only 'queue_depth - 1'
tags, so there can never be more than that to reap when processing a
completion queue. Removing this misleading comment makes it a little
less likely people with broken controllers will blame the driver for
their spurious interrupts.

Signed-off-by: Keith Busch 
Signed-off-by: Christoph Hellwig

nvme/pci: Fix whitespace problem

2016-12-21T10:33:18+00:00

Convert to tabs and remove unneeded whitespaces.

Signed-off-by: Max Gurtovoy 
Signed-off-by: Christoph Hellwig