linux-toradex.git/drivers/nvme/target, branch v5.0

nvmet-rdma: fix null dereference under heavy load

2019-01-24T00:16:59+00:00

Under heavy load if we don't have any pre-allocated rsps left, we
dynamically allocate a rsp, but we are not actually allocating memory
for nvme_completion (rsp->req.rsp). In such a case, accessing pointer
fields (req->rsp->status) in nvmet_req_init() will result in crash.

To fix this, allocate the memory for nvme_completion by calling
nvmet_rdma_alloc_rsp()

Fixes: 8407879c("nvmet-rdma:fix possible bogus dereference under heavy load")

Cc: 
Reviewed-by: Max Gurtovoy 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Raju Rangoju 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Jens Axboe

nvmet-tcp: fix uninitialized variable access

2019-01-16T16:44:20+00:00

If we end up in nvmet_tcp_try_recv_one with a bogus state
queue receive state we will access result which is uninitialized.

Initialize restult to 0 which will be considered as if no data
was received by the tcp socket.

Fixes: 872d26a391da ("nvmet-tcp: add NVMe over TCP target driver")
Reported-by: Dan Carpenter 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvme-fabrics: allow nvmf_connect_io_queue to poll

2018-12-18T16:50:48+00:00

Preparation for polling support for fabrics. Polling support
means that our completion queues are not generating any interrupts
which means we need to poll for the nvmf io queue connect as well.

Reviewed by Steve Wise 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig

nvmet-tcp: fix endianess annotations

2018-12-18T16:50:45+00:00

Signed-off-by: Christoph Hellwig 
Acked-by: Sagi Grimberg

nvmet: use a macro for default error location

2018-12-18T16:50:44+00:00

This patch defines a new macro NVMET_NO_ERROR_LOC to represent the
default error location value in the nvme-error-log-page.
This is a pure cleanup patch and it does not change any functionality.

Signed-off-by: Chaitanya Kulkarni 
Signed-off-by: Christoph Hellwig

nvmet: fix comparison of a u16 with -1

2018-12-18T16:50:43+00:00

Currently the u16 req->error_loc is being compared to -1 which
will always be false.  Fix this by casting -1 to u16 to fix this.

Detected by clang:
  warning: result of comparison of constant -1 with expression of
  type 'u16' (aka 'unsigned short') is always false
  [-Wtautological-constant-out-of-range-compare]

Fixes: 76574f37bf4c ("nvmet: add interface to update error-log page")
Signed-off-by: Colin Ian King 
Signed-off-by: Christoph Hellwig

nvmet: update smart log with num err log entries

2018-12-13T08:59:07+00:00

Now that we have error log page implementation update smart log command
handler to provide number of error log entries in the lifetime of the
controller field.

Signed-off-by: Chaitanya Kulkarni 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig

nvmet: add error log page cmd handler

2018-12-13T08:59:06+00:00

Now that we have support for all the major parts of the target we add
a NVMe error log page handler so that host can read the log page.

Signed-off-by: Chaitanya Kulkarni 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig

nvmet: add error log support for file backend

2018-12-13T08:59:06+00:00

This patch adds support for the file backend to populate the
error log entries. Here we map the errno to the NVMe status codes.

Signed-off-by: Chaitanya Kulkarni 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig

nvmet: add error log support for bdev backend

2018-12-13T08:59:05+00:00

This patch adds the support for the block device backend to populate the
error log entries. Here we map the blk_status_t to the NVMe status.

Signed-off-by: Chaitanya Kulkarni 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig