linux-toradex.git/drivers/nvme, branch v4.14-rc3

nvme-fcloop: fix port deletes and callbacks

2017-09-25T18:42:11+00:00

Now that there are potentially long delays between when a remoteport or
targetport delete calls is made and when the callback occurs (dev_loss_tmo
timeout), no longer block in the delete routines and move the final nport
puts to the callbacks.

Moved the fcloop_nport_get/put/free routines to avoid forward declarations.

Ensure port_info structs used in registrations are nulled in case fields
are not set (ex: devloss_tmo values).

Signed-off-by: James Smart 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvmet-fc: ensure target queue id within range.

2017-09-25T18:42:11+00:00

When searching for queue id's ensure they are within the expected range.

Signed-off-by: James Smart 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvmet-fc: on port remove call put outside lock

2017-09-25T18:42:11+00:00

Avoid calling the put routine, as it may traverse to free routines while
holding the target lock.

Signed-off-by: James Smart 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvme-rdma: don't fully stop the controller in error recovery

2017-09-25T18:42:11+00:00

By calling nvme_stop_ctrl on a already failed controller will wait for the
scan work to complete (only by identify timeout expiration which is 60
seconds). This is unnecessary when we already know that the controller has
failed.

Reported-by: Yi Zhang 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvme-rdma: give up reconnect if state change fails

2017-09-25T18:42:11+00:00

If we failed to transition to state LIVE after a successful reconnect,
then controller deletion already started. In this case there is no
point moving forward with reconnect.

Reviewed-by: Johannes Thumshirn 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvme-core: Use nvme_wq to queue async events and fw activation

2017-09-25T18:42:11+00:00

async_event_work might race as it is executed from two different
workqueues at the moment.

Reviewed-by: Johannes Thumshirn 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvme: fix sqhd reference when admin queue connect fails

2017-09-25T18:42:11+00:00

Fix bug in sqhd patch.

It wasn't the sq that was at risk. In the case where the admin queue
connect command fails, the sq->size field is not set. Therefore, this
becomes a divide by zero error.

Add a quick check to bypass under this failure condition.

Signed-off-by: James Smart 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvmet: implement valid sqhd values in completions

2017-09-25T14:56:05+00:00

To support sqhd, for initiators that are following the spec and
paying attention to sqhd vs their sqtail values:

- add sqhd to struct nvmet_sq
- initialize sqhd to 0 in nvmet_sq_setup
- rather than propagate the 0's-based qsize value from the connect message
  which requires a +1 in every sqhd update, and as nothing else references
  it, convert to 1's-based value in nvmt_sq/cq_setup() calls.
- validate connect message sqsize being non-zero per spec.
- updated assign sqhd for every completion that goes back.

Also remove handling the NULL sq case in __nvmet_req_complete, as it can't
happen with the current code.

Signed-off-by: James Smart 
Reviewed-by: Sagi Grimberg 
Reviewed-by: Max Gurtovoy 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvme-fabrics: Allow 0 as KATO value

2017-09-25T14:56:05+00:00

Currently, driver code allows user to set 0 as KATO
(Keep Alive TimeOut), but this is not being respected.
This patch enforces the expected behavior.

Signed-off-by: Guilherme G. Piccoli 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvme: allow timed-out ios to retry

2017-09-25T14:56:05+00:00

Currently the nvme_req_needs_retry() applies several checks to see if
a retry is allowed. On of those is whether the current time has exceeded
the start time of the io plus the timeout length. This check, if an io
times out, means there is never a retry allowed for the io. Which means
applications see the io failure.

Remove this check and allow the io to timeout, like it does on other
protocols, and retries to be made.

On the FC transport, a frame can be lost for an individual io, and there
may be no other errors that escalate for the connection/association.
The io will timeout, which causes the transport to escalate into creating
a new association, but the io that timed out, due to this retry logic, has
already failed back to the application and things are hosed.

Signed-off-by: James Smart 
Reviewed-by: Keith Busch 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe