linux-toradex.git/drivers/nvme, branch v5.15-rc1

nvme: add error handling support for add_disk()

2021-09-06T08:08:09+00:00

We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

Signed-off-by: Luis Chamberlain 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Christoph Hellwig

nvme: only call synchronize_srcu when clearing current path

2021-09-06T08:03:11+00:00

The function nmve_mpath_clear_current_path returns true if the current
path has changed. In this case we have to wait for all concurrent
submissions to finish. But if we didn't change the current path, there
is no point in waiting for another RCU period to finish.

Signed-off-by: Daniel Wagner 
Signed-off-by: Christoph Hellwig

nvme: update keep alive interval when kato is modified

2021-09-06T08:03:11+00:00

Currently the connection between host and NVMe-oF target gets
disconnected by keep-alive timeout when a user connects to a target
with a relatively large kato value and then sets the smaller kato
with a set features command (e.g. connects with 60 seconds kato value
and then sets 10 seconds kato value).

The cause is that keep alive command interval on the host, which is
defined as unsigned int kato in nvme_ctrl structure, does not follow
the kato value changes.

This patch updates the keep alive interval in the following steps when
the kato is modified by a set features command: stops the keep alive
work queue, then sets the kato as new timer value and re-start the queue.

Signed-off-by: Tatsuya Sasaki 
Signed-off-by: Christoph Hellwig

nvme-tcp: Do not reset transport on data digest errors

2021-09-06T08:03:11+00:00

The spec says

  7.4.6.1 Digest Error handling

  When a host detects a data digest error in a C2HData PDU, that host
  shall continue processing C2HData PDUs associated with the command and
  when the command processing has completed, if a successful status was
  returned by the controller, the host shall fail the command with a
  non-fatal transport error.

Currently the transport is reseted when a data digest error is
detected. Instead, when a digest error is detected, mark the final
status as NVME_SC_DATA_XFER_ERROR and let the upper layer handle
the error.

In order to keep track of the final result maintain a status field in
nvme_tcp_request object and use it to overwrite the completion queue
status (which might be successful even though a digest error has been
detected) when completing the request.

Signed-off-by: Daniel Wagner 
Reviewed-by: Sagi Grimberg 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Christoph Hellwig

nvmet: fixup buffer overrun in nvmet_subsys_attr_serial()

2021-09-06T08:03:11+00:00

The serial number is copied into the buffer via memcpy_and_pad()
with the length NVMET_SN_MAX_SIZE. So when printing out we also
need to take just that length as anything beyond that will be
uninitialized.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Christoph Hellwig

nvmet: return bool from nvmet_passthru_ctrl and nvmet_is_passthru_req

2021-09-06T07:59:03+00:00

The target core code never needs the host-side nvme_ctrl structure.
Open code two uses of nvmet_is_passthru_req in passthru.c, and then
switch the helpers used by the core to return bool.  Also rename the
fuctions to better match their usage:

  nvmet_passthru_ctrl -> nvmet_is_passthru_subsys
  nvmet_req_passthru_ctrl -> nvmet_is_passthru_req

Signed-off-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg

nvmet: looks at the passthrough controller when initializing CAP

2021-09-06T07:59:03+00:00

For a passthru controller make cap initialization dependent on the cap of
the passthru controller, given that multiple Command Set support needs
to be supported by the underlying controller.  For that move the
initialization of CAP later so that it can use the fully initialized
nvmet_ctrl structure.

Fixes: ab5d0b38c047 (nvmet: add Command Set Identifier support)
Signed-off-by: Adam Manzanares 
Reviewed-by: Keith Busch 
[hch: refactored the code a bit to keep it more contained in passthru.c]
Signed-off-by: Christoph Hellwig

nvme: move nvme_multi_css into nvme.h

2021-09-06T07:59:02+00:00

Preparatory patch in order to reuse nvme_multi_css in the nvme target
code.

Signed-off-by: Adam Manzanares 
Reviewed-by: Keith Busch 
Signed-off-by: Christoph Hellwig

nvme-multipath: revalidate paths during rescan

2021-09-06T07:59:02+00:00

When triggering a rescan due to a namespace resize we will be
receiving AENs on every controller, triggering a rescan of all
attached namespaces. If multipath is active only the current path and
the ns_head disk will be updated, the other paths will still refer to
the old size until AENs for the remaining controllers are received.

If I/O comes in before that it might be routed to one of the old
paths, triggering an I/O failure with 'access beyond end of device'.
With this patch the old paths are skipped from multipath path
selection until the controller serving these paths has been rescanned.

Signed-off-by: Hannes Reinecke 
[dwagner: - introduce NVME_NS_READY flag instead of NVME_NS_INVALIDATE
          - use 'revalidate' instead of 'invalidate' which
	    follows the zoned device code path.
	  - clear NVME_NS_READY before clearing current_path]
Signed-off-by: Daniel Wagner 
Signed-off-by: Christoph Hellwig

nvme-multipath: set QUEUE_FLAG_NOWAIT

2021-09-06T07:59:02+00:00

The nvme multipathing code just dispatches bios to one of the blk-mq
based paths and never blocks on its own, so set QUEUE_FLAG_NOWAIT
to support REQ_NOWAIT bios.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg