linux-toradex.git/drivers/nvmem/sunxi_sid.c, branch v5.7-rc2

nvmem: sunxi_sid: fix A64 SID controller support

2019-08-18T10:56:52+00:00

Like in H3, A64 SID controller doesn't return correct data
when using direct access. It appears that on A64, SID needs
8 bytes of word_size.

Workaround is to enable read by registers.

Signed-off-by: Stefan Mavrodiev 
Acked-by: Chen-Yu Tsai 
Tested-by: Vasily Khoruzhick 
Signed-off-by: Srinivas Kandagatla 
Link: https://lore.kernel.org/r/20190818093345.29647-4-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman

nvmem: sunxi_sid: Support SID on H6

2019-04-25T17:43:13+00:00

Add support for H6's SID controller. It supports 4K-bit
EFUSE, bigger than before.

Signed-off-by: Yangtao Li 
Acked-by: Maxime Ripard 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman

nvmem: sunxi-sid: convert to SPDX license tags

2019-04-25T17:43:13+00:00

Updates license to use SPDX-License-Identifier.

Acked-by: Maxime Ripard 
Signed-off-by: Yangtao Li 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman

nvmem: sunxi_sid: Support SID on A83T and H5

2019-04-25T17:43:12+00:00

The device tree binding already lists compatible strings for these two
SoCs. They don't have the defect as seen on the H3, and the size and
register layout is the same as the A64. Furthermore, the driver does
not include nvmem cell definitions.

Add support for these two compatible strings, re-using the config for
the A64.

Signed-off-by: Chen-Yu Tsai 
Acked-by: Maxime Ripard 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman

nvmem: sunxi_sid: Read out data in native format

2019-04-25T17:43:11+00:00

Originally the SID e-fuses were thought to be in big-endian format.
Later sources show that they are in fact native or little-endian.
The most compelling evidence is the thermal sensor calibration data,
which is a set of one to three 16-bit values. In native-endian they
are in 16-bit cells with increasing offsets, whereas with big-endian
they are in the wrong order, and a gap with no data will show if there
are one or three cells.

Switch to a native endian representation for the nvmem device. For the
H3, the register read-out method was already returning data in native
endian. This only affects the other SoCs.

Signed-off-by: Chen-Yu Tsai 
Acked-by: Maxime Ripard 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman

nvmem: sunxi_sid: Dynamically allocate nvmem_config structure

2019-04-25T17:43:11+00:00

The sunxi_sid driver currently uses a statically allocated nvmem_config
structure that is updated at probe time. This is sub-optimal as it
limits the driver to one instance, and also takes up space even if the
device is not present.

Modify the driver to allocate the nvmem_config structure at probe time,
plugging in the desired parameters along the way.

Signed-off-by: Chen-Yu Tsai 
Acked-by: Maxime Ripard 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman

nvmem: sunxi_sid: Optimize register read-out method

2019-04-25T17:43:11+00:00

SID cells are 32-bit aligned, and a multiple of 32 bits in length. The
only outlier is the thermal sensor calibration data, which is 16 bits
per sensor. However a whole 64 bits is allocated for this purpose, so
we could consider it conforming to the rule above.

Also, the register read-out method assumes native endian, unlike the
direct MMIO method, which assumes big endian. Thus no endian conversion
is involved.

Under these assumptions, the register read-out method can be slightly
optimized. Instead of reading one word then discarding 3 bytes, read
the whole word directly into the buffer. However, for reads under 4
bytes or trailing bytes, we still use a scratch buffer to extract the
requested bytes.

We could go one step further if .word_size was 4, but changing that
would affect the sysfs interface's behavior.

Signed-off-by: Chen-Yu Tsai 
Acked-by: Maxime Ripard 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman

nvmem: sunxi_sid: Read out SID for randomness without looping

2019-04-25T17:43:11+00:00

Since the reg_read callbacks already support arbitrary, but 4-byte
aligned. offsets and lengths into the SID, there is no need for another
for loop just to use it to read 1 byte at a time.

Read out the whole SID block in one go.

Signed-off-by: Chen-Yu Tsai 
Acked-by: Maxime Ripard 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman

nvmem: sunxi_sid: remove unused variable in probe

2018-09-28T13:14:55+00:00

This patch fixes below warning:
sunxi_sid.c:157:6: warning: unused variable 'ret' [-Wunused-variable]

Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman

nvmem: sunxi_sid: use devm_nvmem_register()

2018-09-28T13:14:54+00:00

Use the resource managed variant of nvmem_register().

Signed-off-by: Bartosz Golaszewski 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman