linux-toradex.git/drivers/of/fdt.c, branch v3.10.78

of: fdt: fix memory initialization for expanded DT

2013-08-29T16:47:37+00:00

commit 9e40127526e857fa3f29d51e83277204fbdfc6ba upstream.

Already existing property flags are filled wrong for properties created from
initial FDT. This could cause problems if this DYNAMIC device-tree functions
are used later, i.e. properties are attached/detached/replaced. Simply dumping
flags from the running system show, that some initial static (not allocated via
kzmalloc()) nodes are marked as dynamic.

I putted some debug extensions to property_proc_show(..) :
..
+       if (OF_IS_DYNAMIC(pp))
+               pr_err("DEBUG: xxx : OF_IS_DYNAMIC\n");
+       if (OF_IS_DETACHED(pp))
+               pr_err("DEBUG: xxx : OF_IS_DETACHED\n");

when you operate on the nodes (e.g.: ~$ cat /proc/device-tree/*some_node*) you
will see that those flags are filled wrong, basically in most cases it will dump
a DYNAMIC or DETACHED status, which is in not true.
(BTW. this OF_IS_DETACHED is a own define for debug purposes which which just
make a test_bit(OF_DETACHED, &x->_flags)

If nodes are dynamic kernel is allowed to kfree() them. But it will crash
attempting to do so on the nodes from FDT -- they are not allocated via
kzmalloc().

Signed-off-by: Wladislav Wiebe 
Acked-by: Alexander Sverdlin 
Signed-off-by: Rob Herring 
Signed-off-by: Greg Kroah-Hartman

drivers/of/fdt.c: re-use kernel's kbasename()

2012-12-18T01:15:18+00:00

Signed-off-by: Andy Shevchenko 
Acked-by: Grant Likely 
Cc: Rob Herring 
Cc: Fabio Estevam 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Fix build when CONFIG_W1_MASTER_GPIO=m b exporting "allnodes"

2012-11-30T10:04:06+00:00

ERROR: "allnodes" [drivers/w1/masters/w1-gpio.ko] undefined!

Signed-off-by: Randy Dunlap 
[grant.likely: allnodes is too generic; rename to of_allnodes]
Signed-off-by: Grant Likely 
Cc: Ville Syrjala

of/fdt: NULL-terminate the root node path

2012-11-21T04:58:53+00:00

Commit 509b7455 (of/fdt: Don't copy garbage after "/" in root node path)
sets the path length to 0 to ignore any garbage after "/" in the root
node path. This has the side effect of also ignoring '\0' at the end of
the root node path. This patch sets the ignores the garbage by setting
the last character to '\0' and length to 1.

Signed-off-by: Catalin Marinas 
Cc: Benjamin Herrenschmidt 
Signed-off-by: Rob Herring

of: fdt: Constify 'pathp'

2012-11-21T04:57:40+00:00

Constify 'pathp' in order to get rid of the following warning:

drivers/of/fdt.c:491:10: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]

Signed-off-by: Fabio Estevam 
[Rob Herring: also constify np and lp]
Signed-off-by: Rob Herring

drivers/of: Constify device_node->name and ->path_component_name

2012-11-17T12:05:57+00:00

Neither of these should ever be changed once set. Make them const and
fix up the users that try to modify it in-place. In one case
kmalloc+memcpy is replaced with kstrdup() to avoid modifying the string.

Build tested with defconfigs on ARM, PowerPC, Sparc, MIPS, x86 among
others.

Signed-off-by: Grant Likely 
Acked-by: David S. Miller 
Cc: Benjamin Herrenschmidt 
Cc: Julian Calaby

of/fdt: Don't copy garbage after "/" in root node path

2012-11-11T03:53:04+00:00

The root node path must be internally converted to "/", or various
pieces of code looking for it that way will fail. The code to do
that however had a bug where we might incorrectly append pieces
of the original path from the fdt to the "/".

We should probably add a proper dedicated accessor for the root node
but in the meantime this patch should fix it.

Signed-off-by: Benjamin Herrenschmidt 
Signed-off-by: Rob Herring

of/fdt.c: asm/setup.h included twice

2012-02-27T16:09:25+00:00

drivers/of/fdt.c included 'asm/setup.h' twice, remove the duplicate.

Signed-off-by: Danny Kukawka 
Signed-off-by: Rob Herring

of: add include asm/setup.h in drivers/of/fdt.c

2012-01-10T02:29:41+00:00

In the file drivers/of/fdt.c, it uses the COMMAND_LINE_SIZE which is stated
in asm/setup.h, so asm/setup.h should be included in drivers/of/fdt.c.

Signed-off-by: Yu Yue 
Signed-off-by: Guan Xuetao 

Cc: Grant Likerly 
Cc: devicetree-discuss@lists.ozlabs.org
Cc: Arnd Bergmann

ARM: prom.h: Fix build error by removing unneeded header file

2012-01-05T06:47:52+00:00

Fix the following build error:

  CC [M]  fs/udf/balloc.o
In file included from /home/fabio/next/linux-next/arch/arm/include/asm/prom.h:16,
                 from include/linux/of.h:140,
                 from include/asm-generic/gpio.h:7,
                 from arch/arm/plat-mxc/include/mach/irqs.h:14,
                 from /home/fabio/next/linux-next/arch/arm/include/asm/irq.h:4,
                 from /home/fabio/next/linux-next/arch/arm/include/asm/hardirq.h:6,
                 from include/linux/hardirq.h:7,
                 from include/linux/highmem.h:8,
                 from include/linux/pagemap.h:10,
                 from include/linux/buffer_head.h:13,
                 from fs/udf/udfdecl.h:11,
                 from fs/udf/balloc.c:22:
/home/fabio/next/linux-next/arch/arm/include/asm/setup.h:146: error: redefinition of 'struct tag'

Signed-off-by: Fabio Estevam 
[grant.likely: fix build failure on drivers/of/fdt.c]
Signed-off-by: Grant Likely