linux-toradex.git/drivers/of/of_mdio.c, branch v4.0-rc1

net: phy: adjust fixed_phy_register() return value

2014-10-07T17:06:45+00:00

Adjust fixed_phy_register() to return struct phy_device *, so that
it becomes easy to use fixed PHYs without device tree support:

  phydev = fixed_phy_register(PHY_POLL, &fixed_phy_status, NULL);
  fixed_phy_set_link_update(phydev, fixed_phy_link_update);
  phy_connect_direct(netdev, phydev, handler_fn, phy_interface);

This change is a prerequisite for modifying bcmgenet driver to work
without a device tree on Broadcom's MIPS-based 7xxx platforms.

Signed-off-by: Petri Gynther 
Signed-off-by: David S. Miller

of: mdio: honor flags passed to of_phy_connect

2014-09-19T20:27:07+00:00

Commit f9a8f83b04e0 ("net: phy: remove flags argument from phy_{attach,
connect, connect_direct}") removed the flags argument to the PHY library
calls to: phy_{attach,connect,connect_direct}.

Most Device Tree aware drivers call of_phy_connect() with the flag
argument set to 0, but some of them might want to set a different value
there in order for the PHY driver to key a specific behavior based on
the phy_device::phy_flags value.

Allow such drivers to set custom phy_flags as part of the
of_phy_connect() call since of_phy_connect() does start the PHY state
machine, it will call into the PHY driver config_init() callback which
is usually where a specific phy_flags value is important.

Fixes: f9a8f83b04e0 ("net: phy: remove flags argument from phy_{attach, connect, connect_direct}")
Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: fix circular dependency in of_mdio code

2014-07-02T07:24:14+00:00

Commit 86f6cf4127 (net: of_mdio: add of_mdiobus_link_phydev()) introduced a
circular dependency between libphy and of_mdio.

depmod: ERROR: /kernel/drivers/net/phy/libphy.ko in
dependency cycle!
depmod: ERROR: /kernel/drivers/of/of_mdio.ko in dependency cycle!

The problem is that of_mdio.c references &mdio_bus_type and libphy now
references of_mdiobus_link_phydev.

Fix this by not exporting of_mdiobus_link_phydev() from of_mdio.ko.
Make it a static function in mdio_bus.c instead.

Signed-off-by: Daniel Mack 
Reported-by: Jeff Mahoney 
Fixes: 86f6cf4127 (net: of_mdio: add of_mdiobus_link_phydev())
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

of: mdio: fixup of_phy_register_fixed_link parsing of new bindings

2014-06-23T04:35:14+00:00

Fixes commit 3be2a49e5c08 ("of: provide a binding for fixed link PHYs")

Fix the parsing of the new fixed link dts bindings for duplex,
pause, and asym_pause by using the correct device node pointer.

Signed-off-by: Richard Retanubun 
Signed-off-by: David S. Miller

of: of_mdio: export symbol of_mdiobus_link_phydev

2014-06-02T17:43:07+00:00

Make of_mdiobus_link_phydev externally available.
This fixes CONFIG_OF_MDIO=m.

Signed-off-by: Daniel Mack 
Reported-by: Stephen Rothwell 
Fixes: 86f6cf41272 ("net: of_mdio: add of_mdiobus_link_phydev()")
Signed-off-by: David S. Miller

net: of_mdio: use int type for address variable

2014-06-02T17:43:07+00:00

Use int rather than u32 to fix the following warning:

drivers/of/of_mdio.c:147 of_mdiobus_register() warn: unsigned 'addr' is
never less than zero.

Signed-off-by: Daniel Mack 
Fixes: 8f8382888cba ("net: of_mdio: factor out code to parse a phy's 'reg' property")
Signed-off-by: David S. Miller

net: of_mdio: don't store the length of a property if we don't need to

2014-05-29T22:23:29+00:00

of_get_property() can be called with NULL as 2nd argument if the caller
is not interested in the length of a property. Use that here so we can
get rid of a variable.

Signed-off-by: Daniel Mack 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: of_mdio: add of_mdiobus_link_phydev()

2014-05-29T22:23:29+00:00

Add a function to walk the list of subnodes of a mdio bus and look for
a node that matches the phy's address with its 'reg' property. If found,
set the of_node pointer for the phy. This allows auto-probed pyh
devices to be augmented by information passed in via DT.

Signed-off-by: Daniel Mack 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: of_mdio: factor out code to parse a phy's 'reg' property

2014-05-29T22:23:18+00:00

Factor out some logic into of_mdio_parse_addr() so it can be reused
later. While at it, use of_property_read_u32() rather than open-coding
the same logic again.

Signed-off-by: Daniel Mack 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

of: mdio: fix compile warning in of_mdiobus_register_phy()

2014-05-26T04:32:37+00:00

Commit de906af1 (net: phy: make of_set_phy_supported work with genphy driver)
removed the last user of variable 'max_speed' in function
of_mdiobus_register_phy(), leading to compile warning "unused variable
‘max_speed’ [-Wunused-variable]". Thus remove it.

Signed-off-by: Christian Engelmayer 
Acked-by: Florian Fainelli 
Signed-off-by: David S. Miller