linux-toradex.git/drivers/of/of_mdio.c, branch v4.10

of_mdio: add helper to deregister fixed-link PHYs

2016-11-30T04:17:02+00:00

Add helper to deregister fixed-link PHYs registered using
of_phy_register_fixed_link().

Convert the two drivers that care to deregister their fixed-link PHYs to
use the new helper, but note that most drivers currently fail to do so.

Signed-off-by: Johan Hovold 
Signed-off-by: David S. Miller

of_mdio: fix device reference leak in of_phy_find_device

2016-11-17T17:05:04+00:00

Make sure to drop the reference taken by bus_find_device() before
returning NULL from of_phy_find_device() when the found device is not a
PHY.

Fixes: 6ed742363b9c ("of: of_mdio: Ensure mdio device is a PHY")
Signed-off-by: Johan Hovold 
Signed-off-by: David S. Miller

of_mdio: fix node leak in of_phy_register_fixed_link error path

2016-11-17T17:05:04+00:00

Make sure to drop the of_node reference also on failure to parse the
speed property in of_phy_register_fixed_link().

Fixes: 3be2a49e5c08 ("of: provide a binding for fixed link PHYs")
Signed-off-by: Johan Hovold 
Signed-off-by: David S. Miller

of_mdio: Abstract a general interface for phy connect

2016-07-17T04:32:58+00:00

Abstract a general interface "of_phy_get_and_connect"
for PHY connect. User will have no bother with getting
"phy-mode" and "phy-handle" any more.

Suggested-by: Arnd Bergmann 
Signed-off-by: Dongpo Li 
Reviewed-by: Jiancheng Xue 
Signed-off-by: David S. Miller

of_mdio: select fixed phy support unconditionally

2016-06-28T09:47:52+00:00

Calling the fixed-phy functions when CONFIG_FIXED_PHY=m as a previous
change tried cannot work if the caller is in built-in code:

drivers/of/built-in.o: In function `of_phy_register_fixed_link':
of_reserved_mem.c:(.text+0x85e0): undefined reference to `fixed_phy_register'

Making of_mdio depend on 'FIXED_PHY || !FIXED_PHY' would solve this
dependency by enforcing that OF_MDIO itself becomes a loadable module
when FIXED_PHY=y, but that creates a different dependency as it
breaks any built-in ethernet driver that uses of_mdio.

Making FIXED_PHY a bool option also cannot work, since it depends on
PHYLIB, which again is tristate.

This version now uses 'select FIXED_PHY' to ensure that the fixed-phy
portion of of_mdio is not optional. The main downside of this is
a small increase in code size for cases that do not need fixed phy
support, but it should avoid all of the link-time problems.

Signed-off-by: Arnd Bergmann 
Fixes: d1bd330a229f ("of_mdio: Enable fixed PHY support if driver is a module")
Acked-by: Randy Dunlap 
Signed-off-by: David S. Miller

of_mdio: Enable fixed PHY support if driver is a module

2016-06-23T19:12:21+00:00

The fixed_phy driver doesn't have to be built-in, and it's
important that of_mdio supports it even if it's a module.

Signed-off-by: Ben Hutchings 
Acked-by: Florian Fainelli 
Signed-off-by: David S. Miller

of: of_mdio: Check if MDIO bus controller is available

2016-05-01T23:34:29+00:00

Add a check whether the 'struct device_node' pointer passed to
of_mdiobus_register() is an available (aka enabled) node in the Device
Tree.

Rationale for doing this are cases where an Ethernet MAC provides a MDIO
bus controller and node, and an additional Ethernet MAC might be
connecting its PHY/switches to that first MDIO bus controller, while
still embedding one internally which is therefore marked as "disabled".

Instead of sprinkling checks like these in callers of
of_mdiobus_register(), do this in a central location.

Reviewed-by: Andrew Lunn 
Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

of_mdio: get_phy_device() doesn't return NULL anymore

2016-04-26T19:41:20+00:00

Now that get_phy_device() no longer returns NULL on error, we don't need
to check for it...

Signed-off-by: Sergei Shtylyov 
Reviewed-by: Florian Fainelli 
Signed-off-by: David S. Miller

of_mdio: make of_mdiobus_register_{device|phy}() void

2016-04-19T00:58:54+00:00

The results of of_mdiobus_register_{device|phy}() are never checked, so we
can make  both these functions *void*...

Signed-off-by: Sergei Shtylyov 
Signed-off-by: David S. Miller

of_mdio: use PTR_ERR_OR_ZERO()

2016-03-14T19:31:58+00:00

PTR_ERR_OR_ZERO() is open coded in of_phy_register_fixed_link(), so just
call it directly...

Signed-off-by: Sergei Shtylyov 
Reviewed-by: Florian Fainelli 
Reviewed-by: Vladimir Zapolskiy 
Signed-off-by: David S. Miller