linux-toradex.git/drivers/of/of_numa.c, branch v4.9.90

of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()

2017-05-25T13:44:37+00:00

commit b8475cbee5ab2eac05f9cd5dbcc94c453d3cbf10 upstream.

The call to of_find_node_by_path("/cpus") returns the cpus device_node
with its reference count incremented. There is no matching of_node_put()
call in of_numa_parse_cpu_nodes() which results in a leaked reference
to the "/cpus" node.

This patch adds an of_node_put() to release the reference.

fixes: 298535c00a2c ("of, numa: Add NUMA of binding implementation.")
Signed-off-by: Tyrel Datwyler 
Acked-by: David Daney 
Signed-off-by: Rob Herring 
Signed-off-by: Greg Kroah-Hartman

of, numa: Return NUMA_NO_NODE from disable of_node_to_nid() if nid not possible.

2017-01-09T07:32:25+00:00

commit b6cc9474e2dd9f0c19b694b40961d81117f1e918 upstream.

On arm64 NUMA kernels we can pass "numa=off" on the command line to
disable NUMA.  A side effect of this is that kmalloc_node() calls to
non-zero nodes will crash the system with an OOPS:

[    0.000000] ITS@0x0000901000020000: allocated 2097152 Devices @10002000000 (flat, esz 8, psz 64K, shr 1)
[    0.000000] Unable to handle kernel NULL pointer dereference at virtual address 00001680
[    0.000000] pgd = fffffc0009470000
[    0.000000] [00001680] *pgd=0000010ffff90003, *pud=0000010ffff90003, *pmd=0000010ffff90003, *pte=0000000000000000
[    0.000000] Internal error: Oops: 96000006 [#1] SMP
.
.
.
[    0.000000] [] __alloc_pages_nodemask+0xa4/0xe68
[    0.000000] [] new_slab+0xd0/0x564
[    0.000000] [] ___slab_alloc+0x2e4/0x514
[    0.000000] [] __slab_alloc+0x48/0x58
[    0.000000] [] __kmalloc_node+0xd0/0x2dc
[    0.000000] [] __irq_domain_add+0x7c/0x164
[    0.000000] [] its_probe+0x784/0x81c
[    0.000000] [] its_init+0x48/0x1b0
[    0.000000] [] gic_init_bases+0x228/0x360
[    0.000000] [] gic_of_init+0x148/0x1cc
[    0.000000] [] of_irq_init+0x184/0x298
[    0.000000] [] irqchip_init+0x14/0x38
[    0.000000] [] init_IRQ+0xc/0x30
[    0.000000] [] start_kernel+0x240/0x3b8
[    0.000000] [] __primary_switched+0x30/0x6c
[    0.000000] Code: 912ec2a0 b9403809 0a0902fb 37b007db (f9400300)
.
.
.

This is caused by code like this in kernel/irq/irqdomain.c

    domain = kzalloc_node(sizeof(*domain) + (sizeof(unsigned int) * size),
                  GFP_KERNEL, of_node_to_nid(of_node));

When NUMA is disabled, the concept of a node is really undefined, so
of_node_to_nid() should unconditionally return NUMA_NO_NODE.

Fix by returning NUMA_NO_NODE when the nid is not in the set of
possible nodes.

Reported-by: Gilbert Netzer 
Signed-off-by: David Daney 
Signed-off-by: Rob Herring 
Signed-off-by: Greg Kroah-Hartman

of_numa: Use pr_fmt()

2016-09-09T13:59:09+00:00

Use pr_fmt to prefix kernel output.

Signed-off-by: Kefeng Wang 
Acked-by: Rob Herring 
Signed-off-by: Will Deacon

of_numa: Use of_get_next_parent to simplify code

2016-09-09T13:59:08+00:00

Use of_get_next_parent() instead of open-code.

Signed-off-by: Kefeng Wang 
Acked-by: Rob Herring 
Signed-off-by: Will Deacon

of/numa: remove a duplicated warning

2016-09-09T13:59:08+00:00

This warning has been printed in of_numa_parse_cpu_nodes before.

Signed-off-by: Zhen Lei 
Acked-by: Rob Herring 
Signed-off-by: Will Deacon

of/numa: add nid check for memory block

2016-09-09T13:59:08+00:00

If the numa-id which was configured in memory@ devicetree node is greater
than MAX_NUMNODES, we should report a warning. We have done this for cpus
and distance-map dt nodes, this patch help them to be consistent.

Acked-by: Rob Herring 
Signed-off-by: Zhen Lei 
Signed-off-by: Will Deacon

of/numa: fix a memory@ node can only contains one memory block

2016-09-09T13:59:08+00:00

For a normal memory@ devicetree node, its reg property can contains more
memory blocks.

Because we don't known how many memory blocks maybe contained, so we try
from index=0, increase 1 until error returned(the end).

Signed-off-by: Zhen Lei 
Acked-by: Rob Herring 
Signed-off-by: Will Deacon

of/numa: remove a duplicated pr_debug information

2016-09-09T13:59:08+00:00

This information will be printed in the subfunction numa_add_memblk.
They are not the same, but very similar.

Signed-off-by: Zhen Lei 
Acked-by: Rob Herring 
Signed-off-by: Will Deacon

arm64, NUMA: rework numa_add_memblk()

2016-05-30T12:27:07+00:00

Rework numa_add_memblk() to update the parameter "u64 size" to "u64
end", this will make it consistent with x86 and simplifies the arm64
ACPI NUMA code to be added later.

Signed-off-by: Hanjun Guo 
Signed-off-by: Robert Richter 
Signed-off-by: David Daney 
Acked-by: Catalin Marinas 
Signed-off-by: Rafael J. Wysocki

of, numa: Add NUMA of binding implementation.

2016-04-15T17:06:08+00:00

Add device tree parsing for NUMA topology using device
"numa-node-id" property in distance-map and cpu nodes.

This is a complete rewrite of a previous patch by:
   Ganapatrao Kulkarni

Signed-off-by: David Daney 
Acked-by: Rob Herring 
Signed-off-by: Will Deacon