linux-toradex.git/drivers/of/selftest.c, branch v3.10.78

of: Fix overflow bug in string property parsing functions

2014-11-14T16:48:01+00:00

commit a87fa1d81a9fb5e9adca9820e16008c40ad09f33 upstream.

The string property read helpers will run off the end of the buffer if
it is handed a malformed string property. Rework the parsers to make
sure that doesn't happen. At the same time add new test cases to make
sure the functions behave themselves.

The original implementations of of_property_read_string_index() and
of_property_count_strings() both open-coded the same block of parsing
code, each with it's own subtly different bugs. The fix here merges
functions into a single helper and makes the original functions static
inline wrappers around the helper.

One non-bugfix aspect of this patch is the addition of a new wrapper,
of_property_read_string_array(). The new wrapper is needed by the
device_properties feature that Rafael is working on and planning to
merge for v3.19. The implementation is identical both with and without
the new static inline wrapper, so it just got left in to reduce the
churn on the header file.

Signed-off-by: Grant Likely 
Cc: Rafael J. Wysocki 
Cc: Mika Westerberg 
Cc: Rob Herring 
Cc: Arnd Bergmann 
Cc: Darren Hart 
Signed-off-by: Greg Kroah-Hartman

of: Create function for counting number of phandles in a property

2013-02-13T10:09:31+00:00

This patch creates of_count_phandle_with_args(), a new function for
counting the number of phandle+argument tuples in a given property. This
is better than the existing method of parsing each phandle individually
until parsing fails which is a horribly slow way to do the count.

Tested on ARM using the selftest code.

v3: - Rebased on top of selftest code cleanup patch
v2: - fix bug where of_parse_phandle_with_args() could behave like _count_.
    - made of_gpio_named_count() into a static inline regardless of CONFIG_OF_GPIO

Tested-by: Andreas Larsson 
Signed-off-by: Grant Likely 
Cc: Linus Walleij 
Cc: Rob Herring

of/selftest: Use selftest() macro throughout

2013-02-13T10:05:58+00:00

Some of the selftests are open-coded. Others use the selftest() macro
defined in drivers/of/selftest.c. The macro makes for cleaner selftest
code, so refactor the of_parse_phandle_with_args() tests to use it.

Cc: Rob Herring 
Signed-off-by: Grant Likely

of/selftest: Fix GPIOs selftest to cover the 7th case

2013-02-13T10:05:57+00:00

The of_gpio_named_count() self test doesn't hit the out-of-range
condition even though it is coded. Fix the bug by increasing the for
loop range by one.

Reported-by: Andreas Larsson 
Cc: Rob Herring 
Signed-off-by: Grant Likely

of: Add of_property_match_string() to find index into a string list

2012-01-28T17:29:20+00:00

Add a helper function for finding the index of a string in a string
list property.  This helper is useful for bindings that use a separate
*-name property for attaching names to tuples in another property such
as 'reg' or 'gpios'.

Signed-off-by: Grant Likely

of: Add device tree selftests

2011-12-12T20:40:16+00:00

Add some runtime test cases for the library of device tree parsing functions.

v2: - Add testcase for phandle with 0 args
    - Don't run testcases if testcase data isn't present in device tree

Signed-off-by: Grant Likely