linux-toradex.git/drivers/of, branch v4.9.97

OF: Prevent unaligned access in of_alias_scan()

2018-04-29T09:31:57+00:00

commit de96ec2a77c6d06a423c2c495bb4a2f4299f3d9e upstream.

When allocating a struct alias_prop, of_alias_scan() only requested that
it be aligned on a 4 byte boundary. The struct contains pointers which
leads to us attempting 64 bit writes on 64 bit systems, and if the CPU
doesn't support unaligned memory accesses then this causes problems -
for example on some MIPS64r2 CPUs including the "mips64r2-generic" QEMU
emulated CPU it will trigger an address error exception.

Fix this by requesting alignment for the struct alias_prop allocation
matching that which the compiler expects, using the __alignof__ keyword.

Signed-off-by: Paul Burton 
Acked-by: Rob Herring 
Reviewed-by: Grant Likely 
Cc: Frank Rowand 
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/14306/
Signed-off-by: Ralf Baechle 
Cc: Amit Pundir 
Signed-off-by: Greg Kroah-Hartman

of: fix of_device_get_modalias returned length when truncating buffers

2018-03-22T08:17:41+00:00

[ Upstream commit bcf54d5385abaea9c8026aae6f4eeb348671a52d ]

If the length of the modalias is greater than the buffer size, then the
modalias is truncated. However the untruncated length is returned which
will cause an error. Fix this to return the truncated length. If an error
in the case was desired, then then we should just return -ENOMEM.

The reality is no device will ever have 4KB of compatible strings to hit
this case.

Signed-off-by: Rob Herring 
Cc: Frank Rowand 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2017-07-27T22:08:08+00:00

commit 7a3b7cd332db08546f3cdd984f11773e0d1999e7 upstream.

The ULPI bus can be built as a module, and it will soon be
calling these functions when it supports probing devices from DT.
Export them so they can be used by the ULPI module.

Acked-by: Rob Herring 
Cc: 
Signed-off-by: Stephen Boyd 
Signed-off-by: Peter Chen 
Signed-off-by: Greg Kroah-Hartman

of: Add check to of_scan_flat_dt() before accessing initial_boot_params

2017-06-29T11:00:31+00:00

commit 3ec754410cb3e931a6c4920b1a150f21a94a2bf4 upstream.

An empty __dtb_start to __dtb_end section might result in
initial_boot_params being null for arch/mips/ralink. This showed that the
boot process hangs indefinitely in of_scan_flat_dt().

Signed-off-by: Tobias Wolf 
Cc: Sergei Shtylyov 
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/14605/
Signed-off-by: Ralf Baechle 
Signed-off-by: Amit Pundir 
Signed-off-by: Greg Kroah-Hartman

of: fdt: add missing allocation-failure check

2017-05-25T13:44:37+00:00

commit 49e67dd17649b60b4d54966e18ec9c80198227f0 upstream.

The memory allocator passed to __unflatten_device_tree() (e.g. a wrapped
kzalloc) can fail so add the missing sanity check to avoid dereferencing
a NULL pointer.

Fixes: fe14042358fa ("of/flattree: Refactor unflatten_device_tree and add fdt_unflatten_tree")
Signed-off-by: Johan Hovold 
Signed-off-by: Rob Herring 
Signed-off-by: Greg Kroah-Hartman

of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()

2017-05-25T13:44:37+00:00

commit b8475cbee5ab2eac05f9cd5dbcc94c453d3cbf10 upstream.

The call to of_find_node_by_path("/cpus") returns the cpus device_node
with its reference count incremented. There is no matching of_node_put()
call in of_numa_parse_cpu_nodes() which results in a leaked reference
to the "/cpus" node.

This patch adds an of_node_put() to release the reference.

fixes: 298535c00a2c ("of, numa: Add NUMA of binding implementation.")
Signed-off-by: Tyrel Datwyler 
Acked-by: David Daney 
Signed-off-by: Rob Herring 
Signed-off-by: Greg Kroah-Hartman

of: fix sparse warning in of_pci_range_parser_one

2017-05-25T13:44:37+00:00

commit eb3100365791b06242b8bb5c3c2854ba41dabfbc upstream.

sparse gives the following warning for 'pci_space':

../drivers/of/address.c:266:26: warning: incorrect type in assignment (different base types)
../drivers/of/address.c:266:26:    expected unsigned int [unsigned] [usertype] pci_space
../drivers/of/address.c:266:26:    got restricted __be32 const [usertype] 

It appears that pci_space is only ever accessed on powerpc, so the endian
swap is often not needed.

Signed-off-by: Rob Herring 
Signed-off-by: Greg Kroah-Hartman

of, numa: Return NUMA_NO_NODE from disable of_node_to_nid() if nid not possible.

2017-01-09T07:32:25+00:00

commit b6cc9474e2dd9f0c19b694b40961d81117f1e918 upstream.

On arm64 NUMA kernels we can pass "numa=off" on the command line to
disable NUMA.  A side effect of this is that kmalloc_node() calls to
non-zero nodes will crash the system with an OOPS:

[    0.000000] ITS@0x0000901000020000: allocated 2097152 Devices @10002000000 (flat, esz 8, psz 64K, shr 1)
[    0.000000] Unable to handle kernel NULL pointer dereference at virtual address 00001680
[    0.000000] pgd = fffffc0009470000
[    0.000000] [00001680] *pgd=0000010ffff90003, *pud=0000010ffff90003, *pmd=0000010ffff90003, *pte=0000000000000000
[    0.000000] Internal error: Oops: 96000006 [#1] SMP
.
.
.
[    0.000000] [] __alloc_pages_nodemask+0xa4/0xe68
[    0.000000] [] new_slab+0xd0/0x564
[    0.000000] [] ___slab_alloc+0x2e4/0x514
[    0.000000] [] __slab_alloc+0x48/0x58
[    0.000000] [] __kmalloc_node+0xd0/0x2dc
[    0.000000] [] __irq_domain_add+0x7c/0x164
[    0.000000] [] its_probe+0x784/0x81c
[    0.000000] [] its_init+0x48/0x1b0
[    0.000000] [] gic_init_bases+0x228/0x360
[    0.000000] [] gic_of_init+0x148/0x1cc
[    0.000000] [] of_irq_init+0x184/0x298
[    0.000000] [] irqchip_init+0x14/0x38
[    0.000000] [] init_IRQ+0xc/0x30
[    0.000000] [] start_kernel+0x240/0x3b8
[    0.000000] [] __primary_switched+0x30/0x6c
[    0.000000] Code: 912ec2a0 b9403809 0a0902fb 37b007db (f9400300)
.
.
.

This is caused by code like this in kernel/irq/irqdomain.c

    domain = kzalloc_node(sizeof(*domain) + (sizeof(unsigned int) * size),
                  GFP_KERNEL, of_node_to_nid(of_node));

When NUMA is disabled, the concept of a node is really undefined, so
of_node_to_nid() should unconditionally return NUMA_NO_NODE.

Fix by returning NUMA_NO_NODE when the nid is not in the set of
possible nodes.

Reported-by: Gilbert Netzer 
Signed-off-by: David Daney 
Signed-off-by: Rob Herring 
Signed-off-by: Greg Kroah-Hartman

of_mdio: add helper to deregister fixed-link PHYs

2016-11-30T04:17:02+00:00

Add helper to deregister fixed-link PHYs registered using
of_phy_register_fixed_link().

Convert the two drivers that care to deregister their fixed-link PHYs to
use the new helper, but note that most drivers currently fail to do so.

Signed-off-by: Johan Hovold 
Signed-off-by: David S. Miller

of_mdio: fix device reference leak in of_phy_find_device

2016-11-17T17:05:04+00:00

Make sure to drop the reference taken by bus_find_device() before
returning NULL from of_phy_find_device() when the found device is not a
PHY.

Fixes: 6ed742363b9c ("of: of_mdio: Ensure mdio device is a PHY")
Signed-off-by: Johan Hovold 
Signed-off-by: David S. Miller