linux-toradex.git/drivers/opp/core.c, branch v6.3-rc3

OPP: Fix an un-initialized variable usage

2022-08-16T05:18:08+00:00

smatch complains that 'ret' may be returned un-initialized.

Explicitly return 0 if we reach the end of the function (should
'opp_table->clk_count' be 0).

Fixes: 8174a3a613af ("OPP: Provide a simple implementation to configure multiple clocks")
Signed-off-by: Christophe JAILLET 
Signed-off-by: Viresh Kumar

OPP: Don't drop opp->np reference while it is still in use

2022-07-19T05:37:02+00:00

The struct dev_pm_opp contains a reference of the DT node, opp->np,
throughout its lifetime. We should increase the refcount for the same
from _opp_add_static_v2(), and drop it while removing the OPP finally.

Signed-off-by: Liang He 
[ Viresh: Updated subject / commit log, create _of_clear_opp() and drop
	  reference from it]
Signed-off-by: Viresh Kumar

OPP: Allow config_clks helper for single clk case

2022-07-12T15:05:21+00:00

There is a corner case with Tegra30, where we want to skip clk
configuration via dev_pm_opp_set_opp(), but still want the OPP core to
read the "opp-hz" property so we can find the right OPP via freq finding
helpers.

This is the easiest of the ways to make it work, without any special
hacks in the OPP core. Allow config_clks to be passed for single clk
case.

Tested-by: Dmitry Osipenko 
Signed-off-by: Viresh Kumar

OPP: Provide a simple implementation to configure multiple clocks

2022-07-12T15:05:21+00:00

This provides a simple implementation to configure multiple clocks for a
device.

Tested-by: Dmitry Osipenko 
Signed-off-by: Viresh Kumar

OPP: Assert clk_count == 1 for single clk helpers

2022-07-12T15:05:20+00:00

Many helpers can be safely called only for devices that have a single
clk associated with them. Assert the same for those routines.

Tested-by: Dmitry Osipenko 
Signed-off-by: Viresh Kumar

OPP: Add key specific assert() method to key finding helpers

2022-07-12T15:05:20+00:00

The helpers for the clock key, at least, would need to assert that the
helpers are called only for single clock case. Prepare for that by
adding an argument to the key finding helpers.

Tested-by: Dmitry Osipenko 
Signed-off-by: Viresh Kumar

OPP: Compare bandwidths for all paths in _opp_compare_key()

2022-07-12T15:05:20+00:00

Replicate the same behavior as "rates" here and compare all values
instead of relying on the first entry alone.

Signed-off-by: Viresh Kumar

OPP: Allow multiple clocks for a device

2022-07-12T15:05:20+00:00

This patch adds support to allow multiple clocks for a device.

The design is pretty much similar to how this is done for regulators,
and platforms can supply their own version of the config_clks() callback
if they have multiple clocks for their device. The core manages the
calls via opp_table->config_clks() eventually.

We have kept both "clk" and "clks" fields in the OPP table structure and
the reason is provided as a comment in _opp_set_clknames(). The same
isn't done for "rates" though and we use rates[0] at most of the places
now.

Co-developed-by: Krzysztof Kozlowski 
Signed-off-by: Krzysztof Kozlowski 
Tested-by: Jon Hunter 
Tested-by: Dmitry Osipenko 
Tested-by: Manivannan Sadhasivam 
Signed-off-by: Viresh Kumar

OPP: Make dev_pm_opp_set_opp() independent of frequency

2022-07-08T05:57:51+00:00

dev_pm_opp_set_opp() can be called for any device, it may or may not
have a frequency value associated with it.

If a frequency value isn't available, we pass 0 to _set_opp(). Make it
optional instead by making _set_opp() accept a pointer instead, as the
frequency value is anyway available in the OPP. This makes
dev_pm_opp_set_opp() and _set_opp() completely independent of any
special key value.

Tested-by: Dmitry Osipenko 
Signed-off-by: Viresh Kumar

OPP: Reuse _opp_compare_key() in _opp_add_static_v2()

2022-07-08T05:57:51+00:00

Reuse _opp_compare_key() in _opp_add_static_v2() instead of just
comparing frequency while finding suspend frequency. Also add a comment
over _opp_compare_key() explaining its return values.

Tested-by: Dmitry Osipenko 
Signed-off-by: Viresh Kumar