linux-toradex.git/drivers/parisc/pdc_stable.c, branch v2.6.33.12

tree-wide: convert open calls to remove spaces to skip_spaces() lib function

2009-12-15T16:53:32+00:00

Makes use of skip_spaces() defined in lib/string.c for removing leading
spaces from strings all over the tree.

It decreases lib.a code size by 47 bytes and reuses the function tree-wide:
   text    data     bss     dec     hex filename
  64688     584     592   65864   10148 (TOTALS-BEFORE)
  64641     584     592   65817   10119 (TOTALS-AFTER)

Also, while at it, if we see (*str && isspace(*str)), we can be sure to
remove the first condition (*str) as the second one (isspace(*str)) also
evaluates to 0 whenever *str == 0, making it redundant. In other words,
"a char equals zero is never a space".

Julia Lawall tried the semantic patch (http://coccinelle.lip6.fr) below,
and found occurrences of this pattern on 3 more files:
    drivers/leds/led-class.c
    drivers/leds/ledtrig-timer.c
    drivers/video/output.c

@@
expression str;
@@

( // ignore skip_spaces cases
while (*str &&  isspace(*str)) { \(str++;\|++str;\) }
|
- *str &&
isspace(*str)
)

Signed-off-by: André Goddard Rosa 
Cc: Julia Lawall 
Cc: Martin Schwidefsky 
Cc: Jeff Dike 
Cc: Ingo Molnar 
Cc: Thomas Gleixner 
Cc: "H. Peter Anvin" 
Cc: Richard Purdie 
Cc: Neil Brown 
Cc: Kyle McMartin 
Cc: Henrique de Moraes Holschuh 
Cc: David Howells 
Cc: 
Cc: Samuel Ortiz 
Cc: Patrick McHardy 
Cc: Takashi Iwai 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

parisc: Fix read buffer overflow in pdc_stable driver

2009-08-02T10:35:28+00:00

Check whether index is within bounds before testing the element.

Signed-off-by: Roel Kluin 
Signed-off-by: Helge Deller

[PARISC] pdc_stable: fix compile errors

2008-03-16T02:11:59+00:00

Signed-off-by: Joel Soete 
Signed-off-by: Kyle McMartin

Kobject: convert drivers/* from kobject_unregister() to kobject_put()

2008-01-25T04:40:40+00:00

There is no need for kobject_unregister() anymore, thanks to Kay's
kobject cleanup changes, so replace all instances of it with
kobject_put().


Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

Kobject: change drivers/parisc/pdc_stable.c to use kobject_init_and_add

2008-01-25T04:40:29+00:00

Stop using kobject_register, as this way we can control the sending of
the uevent properly, after everything is properly initialized.

Cc: Kyle McMartin 
Cc: Matthew Wilcox 
Cc: Grant Grundler 
Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

kobject: convert parisc/pdc_stable to use kobject_create

2008-01-25T04:40:25+00:00

Using a kset for this simple directory is an overkill.

Cc: Kay Sievers 
Cc: Thibaut VARENE 
Cc: Matthew Wilcox 
Cc: Grant Grundler 
Cc: Kyle McMartin 
Signed-off-by: Greg Kroah-Hartman

firmware: change firmware_kset to firmware_kobj

2008-01-25T04:40:23+00:00

There is no firmware "subsystem" it's just a directory in /sys that
other portions of the kernel want to hook into.  So make it a kobject
not a kset to help alivate anyone who tries to do some odd kset-like
things with this.

Cc: Kay Sievers 
Cc: Cornelia Huck 
Signed-off-by: Greg Kroah-Hartman

kset: convert parisc/pdc_stable.c to use kset_create

2008-01-25T04:40:21+00:00

Dynamically create the kset instead of declaring it statically.
This makes the kobject attributes now work properly that I broke in the
previous patch.

Cc: Kay Sievers 
Cc: Thibaut VARENE 
Cc: Matthew Wilcox 
Cc: Grant Grundler 
Cc: Kyle McMartin 
Signed-off-by: Greg Kroah-Hartman

kobject: convert parisc/pdc_stable to kobj_attr interface

2008-01-25T04:40:21+00:00

This makes the code a bit simpler and and gets us one step closer to
deleting the deprecated subsys_attr code.

NOTE, this needs the next patch in the series in order to work properly.
This will build, but the sysfs files will not properly operate.

Cc: Kay Sievers 
Cc: Thibaut VARENE 
Cc: Matthew Wilcox 
Cc: Grant Grundler 
Cc: Kyle McMartin 
Signed-off-by: Greg Kroah-Hartman

kobject: remove struct kobj_type from struct kset

2008-01-25T04:40:10+00:00

We don't need a "default" ktype for a kset.  We should set this
explicitly every time for each kset.  This change is needed so that we
can make ksets dynamic, and cleans up one of the odd, undocumented
assumption that the kset/kobject/ktype model has.

This patch is based on a lot of help from Kay Sievers.

Nasty bug in the block code was found by Dave Young


Cc: Kay Sievers 
Cc: Dave Young 
Signed-off-by: Greg Kroah-Hartman