linux-toradex.git/drivers/pci/hotplug/ibmphp_ebda.c, branch tegra-T30.ER5

PCI hotplug: check ioremap() return value in ibmphp_ebda.c

2010-02-23T00:17:19+00:00

check ioremap() return value.

Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Jesse Barnes

PCI hotplug: ibmphp: read the length of ebda and map entire ebda region

2010-02-23T00:16:58+00:00

ibmphp driver currently maps only 1KB of ebda memory area into kernel address
space during driver initialization. This causes kernel oops when the driver is
modprobe'd and it accesses memory beyond 1KB within ebda segment. The first
byte of ebda segment actually stores the length of the ebda region in
Kilobytes. Hence make use of the length parameter and map the entire ebda
region.

Signed-off-by: Chandru Siddalingappa 
Signed-off-by: Jesse Barnes

PCI: ibmphp: stop managing hotplug_slot->name

2008-10-22T23:42:41+00:00

We no longer need to manage our version of hotplug_slot->name
since the PCI and hotplug core manage it on our behalf.

Now, we simply advise the PCI core of the name that we would
like, and let the core take care of the rest.

Additionally, slightly rearrange the members of struct slot
so they are naturally aligned to eliminate holes.

Cc: jbarnes@virtuousgeek.org
Cc: kristen.c.accardi@intel.com
Acked-by: Kenji Kaneshige 
Signed-off-by: Alex Chiang 
Signed-off-by: Jesse Barnes

PCI Hotplug core: add 'name' param pci_hp_register interface

2008-10-22T23:42:37+00:00

Update pci_hp_register() to take a const char *name parameter.

The motivation for this is to clean up the individual hotplug
drivers so that each one does not have to manage its own name.
The PCI core should be the place where we manage the name.

We update the interface and all callsites first, in a
"no functional change" manner, and clean up the drivers later.

Cc: kristen.c.accardi@intel.com
Acked-by: Kenji Kaneshige 
Reviewed-by: Matthew Wilcox 
Signed-off-by: Alex Chiang 
Signed-off-by: Jesse Barnes

PCI: ibmphp: list_for_each to list_for_each_entry-checkpatch cleanups

2008-10-20T17:53:45+00:00

Please run checkpatch prior to sending patches, this one fixes several style
issues with the list_for_each conversion patch.

Cc: Cordelia Sam 
Cc: Cordelia Sam 
Cc: Kristen Carlson Accardi 
Signed-off-by: Andrew Morton 
Signed-off-by: Jesse Barnes

PCI: ibmphp: list_for_each to list_for_each_entry

2008-10-20T17:53:44+00:00

Make code more readable with list_for_each_entry().

Signed-off-by: Cordelia Sam 
Cc: Kristen Carlson Accardi 
Signed-off-by: Andrew Morton 
Signed-off-by: Jesse Barnes

x86, pci-hotplug, calgary / rio: fix EBDA ioremap()

2008-09-26T11:25:04+00:00

IO resource and ioremap debugging uncovered this ioremap() done
by drivers/pci/hotplug/ibmphp_ebda.c:

initcall pci_hotplug_init+0x0/0x41 returned 0 after 3 msecs
calling  ibmphp_init+0x0/0x360 @ 1
ibmphpd: IBM Hot Plug PCI Controller Driver version: 0.6
resource map sanity check conflict: 0x9f800 0xaf5e7 0x9f800 0x9ffff reserved
------------[ cut here ]------------
WARNING: at arch/x86/mm/ioremap.c:175 __ioremap_caller+0x5c/0x226()
Pid: 1, comm: swapper Not tainted 2.6.27-rc7-tip-00914-g347b10f-dirty #36038
 [] warn_on_slowpath+0x41/0x68
 [] ? __lock_acquire+0x9ba/0xa7f
 [] ? do_flush_tlb_all+0x0/0x59
 [] ? smp_call_function_mask+0x74/0x17d
 [] ? do_flush_tlb_all+0x0/0x59
 [] ? printk+0x1a/0x1c
 [] ? iomem_map_sanity_check+0x82/0x8c
 [] ? _read_unlock+0x22/0x25
 [] ? iomem_map_sanity_check+0x82/0x8c
 [] ? trace_hardirqs_off+0xb/0xd
 [] __ioremap_caller+0x5c/0x226
 [] ? trace_hardirqs_on+0xb/0xd
 [] ? iounmap+0x9d/0xa5
 [] ioremap_nocache+0x15/0x17
 [] ? ioremap+0xd/0xf
 [] ioremap+0xd/0xf
 [] ibmphp_access_ebda+0x60/0xa0e
 [] ibmphp_init+0xb5/0x360
 [] do_one_initcall+0x57/0x138
 [] ? ibmphp_init+0x0/0x360
 [] ? trace_hardirqs_on+0xb/0xd
 [] ? __queue_work+0x2b/0x30
 [] ? ibmphp_init+0x0/0x360
 [] kernel_init+0x17b/0x1e2
 [] ? kernel_init+0x0/0x1e2
 [] kernel_thread_helper+0x7/0x10
 =======================
---[ end trace a7919e7f17c0a725 ]---
initcall ibmphp_init+0x0/0x360 returned -19 after 144 msecs
calling  zt5550_init+0x0/0x6a @ 1

the problem is this code:

        io_mem = ioremap (ebda_seg<<4, 65000);

it assumes that the EBDA is 65000 bytes. But BIOS EBDA pointers are
at most 1K large.

_if_ the Rio code truly extends upon the customary EBDA size it needs
to iounmap() this memory and ioremap() it larger, once it knows it from
the generic descriptors that a Rio system is around.

Signed-off-by: Ingo Molnar

PCI: introduce pci_slot

2008-06-10T21:37:03+00:00

Currently, /sys/bus/pci/slots/ only exposes hotplug attributes when a
hotplug driver is loaded, but PCI slots have attributes such as address,
speed, width, etc.  that are not related to hotplug at all.

Introduce pci_slot as the primary data structure and kobject model.
Hotplug attributes described in hotplug_slot become a secondary
structure associated with the pci_slot.

This patch only creates the infrastructure that allows the separation of
PCI slot attributes and hotplug attributes.  In this patch, the PCI
hotplug core remains the only user of this infrastructure, and thus,
/sys/bus/pci/slots/ will still only become populated when a hotplug
driver is loaded.

A later patch in this series will add a second user of this new
infrastructure and demonstrate splitting the task of exposing pci_slot
attributes from hotplug_slot attributes.

  - Make pci_slot the primary sysfs entity. hotplug_slot becomes a
    subsidiary structure.
    o pci_create_slot() creates and registers a slot with the PCI core
    o pci_slot_add_hotplug() gives it hotplug capability

  - Change the prototype of pci_hp_register() to take the bus and
    slot number (on parent bus) as parameters.

  - Remove all the ->get_address methods since this functionality is
    now handled by pci_slot directly.

[achiang@hp.com: rpaphp-correctly-pci_hp_register-for-empty-pci-slots]
Tested-by: Badari Pulavarty 
Acked-by: Benjamin Herrenschmidt 
[akpm@linux-foundation.org: build fix]
[akpm@linux-foundation.org: make headers_check happy]
[akpm@linux-foundation.org: nuther build fix]
[akpm@linux-foundation.org: fix typo in #include]
Signed-off-by: Alex Chiang 
Signed-off-by: Matthew Wilcox 
Cc: Greg KH 
Cc: Kristen Carlson Accardi 
Cc: Len Brown 
Acked-by: Kenji Kaneshige 
Signed-off-by: Andrew Morton 
Signed-off-by: Jesse Barnes

PCI: replace remaining FUNCTION occurrences

2008-04-21T04:47:09+00:00

__FUNCTION__ is gcc-specific, use __func__

Signed-off-by: Harvey Harrison 
Signed-off-by: Greg Kroah-Hartman

PCI Hotplug: Fix small mem leak in IBM Hot Plug Controller Driver

2008-03-10T23:38:02+00:00

In drivers/pci/hotplug/ibmphp_ebda.c::ebda_rsrc_controller(), storage is
allocated with kzalloc() and assigned to 'tmp_slot'.  Then lots of
stuff, like ->flag, ->supported_speed etc is set in tmp_slot.  A bit
further down there's then this test :

  if (!bus_info_ptr1) {
    rc = -ENODEV;
    goto error;
  }

At this point, tmp_slot has not been assigned to anything, so when
erroring-out we want to free it, but nothing at the 'error:' label
free's 'tmp_slot' - and we can't really free 'tmp_slot' at 'error:'
since we may jump to that label later when 'tmp_slot' *has* been used
and we do not want it freed. So, the only sane option left seems to be
to kfree(tmp_slot) just before jumping to the 'error:' label in the one
place where this is what actually makes sense. The following patch does
just that and thus kills off a tiny potential memory leak.


Signed-off-by: Jesper Juhl 
Signed-off-by: Greg Kroah-Hartman