linux-toradex.git/drivers/pci/hotplug/pciehp_core.c, branch v2.6.32.45

PCI: pciehp: remove number field

2009-09-17T17:06:36+00:00

Since slot_cap field in struct controller contains physical slot
number informationq, we don't need number field in struct slot.

Acked-by: Alex Chiang 
Signed-off-by: Kenji Kaneshige 
Signed-off-by: Jesse Barnes

PCI: pciehp: remove hpc_ops

2009-09-17T17:06:31+00:00

The struct hpc_ops seems a set of hooks to controller specific
routines. But, it is meaningless because no hotplug controller driver
follows this framework.

Acked-by: Alex Chiang 
Signed-off-by: Kenji Kaneshige 
Signed-off-by: Jesse Barnes

PCI: pciehp: remove pci_dev field

2009-09-17T17:06:25+00:00

Since we have a pointer to pcie_device in struct controller, we don't
need a pointer to pci_dev.

Acked-by: Alex Chiang 
Signed-off-by: Kenji Kaneshige 
Signed-off-by: Jesse Barnes

PCI: pciehp: remove slot_device_offset field

2009-09-17T17:06:02+00:00

Since the device number of the hot-slot under the PCIe downstream port
is always 0, the slot_device_offset field in the slot is meaningless
and we don't need it.

Acked-by: Alex Chiang 
Signed-off-by: Kenji Kaneshige 
Signed-off-by: Jesse Barnes

PCI: pciehp: remove hp_slot field

2009-09-17T17:05:58+00:00

The hp_slot field is to identify the slot under the same
controller. But, since PCIe downstream port has only one slot at most,
it is meaningless and we don't need it.

Acked-by: Alex Chiang 
Signed-off-by: Kenji Kaneshige 
Signed-off-by: Jesse Barnes

PCI: pciehp: remove device field

2009-09-17T17:05:51+00:00

The device field in the struct slot is not necessary because it is
always 0 in pciehp driver.

Acked-by: Alex Chiang 
Signed-off-by: Kenji Kaneshige 
Signed-off-by: Jesse Barnes

PCI: pciehp: remove bus field

2009-09-17T17:05:46+00:00

The bus field in struct slot is not necessary.

Acked-by: Alex Chiang 
Signed-off-by: Kenji Kaneshige 
Signed-off-by: Jesse Barnes

PCI: pciehp: remove slot_list field

2009-09-17T17:05:31+00:00

Since PCIe downstream port has only one slot at most, we don't need
'slot_list' linked list to manage multiple slots under the port.

Acked-by: Alex Chiang 
Signed-off-by: Kenji Kaneshige 
Signed-off-by: Jesse Barnes

PCI hotplug: remove redundant .owner initializations

2009-06-16T21:30:12+00:00

The "owner" field in struct hotplug_slot_ops is initialized by PCI
hotplug core. So each hotplug controller driver doesn't need to
initialize it.

Signed-off-by: Kenji Kaneshige 
Reviewed-by: Alex Chiang 
Signed-off-by: Jesse Barnes

PCI: Remove untested Electromechanical Interlock (EMI) support in pciehp.

2009-06-16T21:30:10+00:00

The EMI support in pciehp is obviously broken. It is implemented using
struct hotplug_slot_attribute, but sysfs_ops for pci_slot_ktype is NOT
for struct hotplug_slot_attribute, but for struct pci_slot_attribute.
This bug had been there for a long time, maybe it was introduced when
PCI slot framework was introduced. The reason why this bug didn't
cause any problem is maybe the EMI support is not tested at all
because of lack of test environment.

As described above, the EMI support in pciehp seems not to be tested
at all. So this patch removes EMI support from pciehp, instead of
fixing the bug.

Signed-off-by: Kenji Kaneshige 
Signed-off-by: Jesse Barnes