linux-toradex.git/drivers/pci/msi.c, branch v3.4.2

x86/PCI: Expand the x86_msi_ops to have a restore MSIs.

2012-01-06T22:02:26+00:00

The MSI restore function will become a function pointer in an
x86_msi_ops struct. It defaults to the implementation in the
io_apic.c and msi.c. We piggyback on the indirection mechanism
introduced by "x86: Introduce x86_msi_ops".

Cc: x86@kernel.org
Cc: Thomas Gleixner 
Cc: "H. Peter Anvin" 
Cc: linux-pci@vger.kernel.org
Signed-off-by: Konrad Rzeszutek Wilk 
Signed-off-by: Jesse Barnes

PCI: msi: fix imbalanced refcount of msi irq sysfs objects

2012-01-06T20:11:17+00:00

This warning was recently reported to me:

------------[ cut here ]------------
WARNING: at lib/kobject.c:595 kobject_put+0x50/0x60()
Hardware name: VMware Virtual Platform
kobject: '(null)' (ffff880027b0df40): is not initialized, yet kobject_put() is
being called.
Modules linked in: vmxnet3(+) vmw_balloon i2c_piix4 i2c_core shpchp raid10
vmw_pvscsi
Pid: 630, comm: modprobe Tainted: G        W   3.1.6-1.fc16.x86_64 #1
Call Trace:
 [] warn_slowpath_common+0x7f/0xc0
 [] warn_slowpath_fmt+0x46/0x50
 [] ? free_desc+0x63/0x70
 [] kobject_put+0x50/0x60
 [] free_msi_irqs+0xd5/0x120
 [] pci_enable_msi_block+0x24c/0x2c0
 [] vmxnet3_alloc_intr_resources+0x173/0x240 [vmxnet3]
 [] vmxnet3_probe_device+0x615/0x834 [vmxnet3]
 [] local_pci_probe+0x5c/0xd0
 [] pci_device_probe+0x109/0x130
 [] driver_probe_device+0x9c/0x2b0
 [] __driver_attach+0xab/0xb0
 [] ? driver_probe_device+0x2b0/0x2b0
 [] ? driver_probe_device+0x2b0/0x2b0
 [] bus_for_each_dev+0x5c/0x90
 [] driver_attach+0x1e/0x20
 [] bus_add_driver+0x1b0/0x2a0
 [] ? 0xffffffffa0187fff
 [] driver_register+0x76/0x140
 [] ? printk+0x51/0x53
 [] ? 0xffffffffa0187fff
 [] __pci_register_driver+0x56/0xd0
 [] vmxnet3_init_module+0x3a/0x3c [vmxnet3]
 [] do_one_initcall+0x42/0x180
 [] sys_init_module+0x91/0x200
 [] system_call_fastpath+0x16/0x1b
---[ end trace 44593438a59a9558 ]---
Using INTx interrupt, #Rx queues: 1.

It occurs when populate_msi_sysfs fails, which in turn causes free_msi_irqs to
be called.  Because populate_msi_sysfs fails, we never registered any of the
msi irq sysfs objects, but free_msi_irqs still calls kobject_del and kobject_put
on each of them, which gets flagged in the above stack trace.

The fix is pretty straightforward.  We can key of the parent pointer in the
kobject.  It is only set if the kobject_init_and_add succededs in
populate_msi_sysfs.  If anything fails there, each kobject has its parent reset
to NULL

Signed-off-by: Neil Horman 
CC: Bjorn Helgaas 
CC: Greg Kroah-Hartman 
CC: linux-pci@vger.kernel.org
Signed-off-by: Jesse Barnes

PCI: msi: Disable msi interrupts when we initialize a pci device

2012-01-06T20:10:29+00:00

I traced a nasty kexec on panic boot failure to the fact that we had
screaming msi interrupts and we were not disabling the msi messages at
kernel startup.  The booting kernel had not enabled those interupts so
was not prepared to handle them.

I can see no reason why we would ever want to leave the msi interrupts
enabled at boot if something else has enabled those interrupts.  The pci
spec specifies that msi interrupts should be off by default.  Drivers
are expected to enable the msi interrupts if they want to use them.  Our
interrupt handling code reprograms the interrupt handlers at boot and
will not be be able to do anything useful with an unexpected interrupt.

This patch applies cleanly all of the way back to 2.6.32 where I noticed
the problem.

Cc: stable@kernel.org
Signed-off-by: Eric W. Biederman 
Signed-off-by: Jesse Barnes

PCI/sysfs: add per pci device msi[x] irq listing (v5)

2012-01-06T20:10:25+00:00

This patch adds a per-pci-device subdirectory in sysfs called:
/sys/bus/pci/devices//msi_irqs

This sub-directory exports the set of msi vectors allocated by a given
pci device, by creating a numbered sub-directory for each vector beneath
msi_irqs.  For each vector various attributes can be exported.
Currently the only attribute is called mode, which tracks the
operational mode of that vector (msi vs. msix)

Acked-by: Greg Kroah-Hartman 
Signed-off-by: Jesse Barnes

pci: Fix files needing export.h for EXPORT_SYMBOL/THIS_MODULE

2011-10-31T23:31:22+00:00

They were implicitly getting it from device.h --> module.h but
we want to clean that up.  So add the minimal header for these
macros.

Signed-off-by: Paul Gortmaker

drivers: Final irq namespace conversion

2011-03-29T12:48:19+00:00

Scripted with coccinelle.

Signed-off-by: Thomas Gleixner

PCI: Add mask bit definition for MSI-X table

2010-12-23T20:53:08+00:00

Then we can use it instead of magic number 1.

Reviewed-by: Hidetoshi Seto 
Cc: Matthew Wilcox 
Signed-off-by: Sheng Yang 
Signed-off-by: Jesse Barnes

msi: Introduce default_[teardown|setup]_msi_irqs with fallback.

2010-10-18T14:49:33+00:00

Introduce an override for the arch_[teardown|setup]_msi_irqs
that can be utilized to fallback to the default arch_* code.

If a platform wants to utilize the code paths defined
in driver/pci/msi.c it has to define HAVE_DEFAULT_MSI_TEARDOWN_IRQS
or HAVE_DEFAULT_MSI_SETUP_IRQS. Otherwise the old mechanism
of over-ridding the arch_* works fine.

Signed-off-by: Konrad Rzeszutek Wilk 
Cc: x86@kernel.org

pci: Cleanup the irq_desc mess in msi

2010-10-12T14:53:34+00:00

Handing down irq_desc to msi just so that msi can access
irq_desc.irq_data.msi_desc is a pretty stupid idea. The calling code
can hand down a pointer to msi_desc so msi code does not need to know
about the irq descriptor at all.

Signed-off-by: Thomas Gleixner 
Reviewed-by: Ingo Molnar 
Acked-by: Jesse Barnes

pci: Convert msi to new irq_chip functions

2010-10-12T14:53:34+00:00

Signed-off-by: Thomas Gleixner 
Reviewed-by: Ingo Molnar 
Acked-by: Jesse Barnes 
Cc: Benjamin Herrenschmidt 
Cc: "David S. Miller" 
Cc: Tony Luck 
Cc: Russell King