linux-toradex.git/drivers/pci/pcie, branch v2.6.27.25

PCIe: portdrv: call pci_disable_device during remove

2009-03-17T00:52:56+00:00

commit d89987193631bf23d1735c55d13a06d4b8d0e9bd upstream.

The PCIe port driver calls pci_enable_device() during probe but
never calls pci_disable_device() during remove.

Signed-off-by: Alex Chiang 
Signed-off-by: Matthew Wilcox 
Signed-off-by: Greg Kroah-Hartman

PCI: Enable PCIe AER only after checking firmware support

2009-03-17T00:52:56+00:00

commit 1f9f13c8d59c1d8da1a602b71d1ab96d1d37d69e upstream.

The PCIe port driver currently sets the PCIe AER error reporting bits for
any root or switch port without first checking to see if firmware will grant
control. This patch moves setting these bits to the AER service driver
aer_enable_port routine.  The bits are then set for the root port and any
downstream switch ports after the check for firmware support (aer_osc_setup)
is made. The patch also unsets the bits in a similar fashion when the AER
service driver is unloaded.

Reviewed-by: Alex Chiang 
Signed-off-by: Andrew Patterson 
Signed-off-by: Jesse Barnes 
Signed-off-by: Greg Kroah-Hartman

PCI: properly clean up ASPM link state on device remove

2009-02-12T17:31:10+00:00

commit 3419c75e15f82c3ab09bd944fddbde72c9e4b3ea upstream.

We only want to disable ASPM when the last function is removed from
the parent's device list. We determine this by checking to see if
the parent's device list is completely empty.

Unfortunately, we never hit that code because the parent is considered
an upstream port, and never had an ASPM link_state associated with it.

The early check for !link_state causes us to return early, we never
discover that our device list is empty, and thus we never remove the
downstream ports' link_state nodes.

Instead of checking to see if the parent's device list is empty, we can
check to see if we are the last device on the list, and if so, then we
know that we can clean up properly.

Cc: Shaohua Li 
Signed-off-by: Alex Chiang 
Signed-off-by: Jesse Barnes 
Signed-off-by: Greg Kroah-Hartman

PCI: keep ASPM link state consistent throughout PCIe hierarchy

2009-01-25T00:36:24+00:00

commit 46bbdfa44cfc0d352148a0dc33ba9f6db02ccdf0 upstream.

In a PCIe hierarchy with a switch present, if the link state of an
endpoint device is changed, we must check the whole hierarchy from the
endpoint device to root port, and for each link in the hierarchy, the new
link state should be configured. Previously, the implementation checked
the state but forgot to configure the links between root port to switch.
Fixes Novell bz #448987.

Signed-off-by: Shaohua Li 
Tested-by: Andrew Patterson 
Signed-off-by: Jesse Barnes 
Signed-off-by: Greg Kroah-Hartman

PCI PM: Split PCI Express port suspend-resume

2009-01-18T18:35:46+00:00

commit a79d682f789730dfabaebbb507c87a90c0671a62 upstream

Suspend-resume of PCI Express ports has recently been moved into
_suspend_late() and _resume_early() callbacks, but some functions
executed from there should not be called with interrupts disabled,
eg. pci_enable_device().  For this reason, split the suspend-resume
of PCI Express ports into parts to be executed with interrupts
disabled and with interrupts enabled.

Signed-off-by: Rafael J. Wysocki 
Signed-off-by: Jesse Barnes 
Signed-off-by: Greg Kroah-Hartman

PCI: Suspend and resume PCI Express ports with interrupts disabled

2009-01-18T18:35:45+00:00

commit 90d25f246ddefbb743764f8d45ae97e545a6ee86 upstream

I don't see why the suspend and resume of PCI Express ports should be
handled with interrupts enabled and it may even lead to problems in
some situations.  For this reason, move the suspending and resuming
of PCI Express ports into ->suspend_late() and ->resume_early()
callbacks executed with interrupts disabled.

This patch addresses the regression from 2.6.26 tracked as
http://bugzilla.kernel.org/show_bug.cgi?id=12121 .

Acked-by: Linus Torvalds 
Signed-off-by: Rafael J. Wysocki 
Signed-off-by: Jesse Barnes 
Signed-off-by: Greg Kroah-Hartman

PCIe: ASPM: Break out of endless loop waiting for PCI config bits to switch

2008-12-13T23:29:32+00:00

commit 2a42d9dba7842422ffb2c02e75288a8bc2fd5065 upstream.

Makes a Compaq 6735s boot reliably again.  It used to hang in the loop
on some boots.  Give the link one second to train, otherwise break out
of the loop and reset the previously set clock bits.

Signed-off-by: Thomas Renninger 
Signed-off-by: Shaohua Li 
Signed-off-by: Matthew Garrett 
Signed-off-by: Jesse Barnes 
Signed-off-by: Greg Kroah-Hartman

PCI: Fix pcie_aspm=force

2008-09-16T16:09:56+00:00

pcie_aspm=force did not work because aspm_force was being double negated
leading to the sanity check failing. Moving a bracket should fix this.

Acked-by: Alan Cox 
Signed-off-by: Sitsofe Wheeler 
Signed-off-by: Jesse Barnes

PCI: add acpi_find_root_bridge_handle

2008-08-18T20:48:04+00:00

Consolidate finding of a root bridge and getting its handle to the one
inline function. It's cut & pasted on multiple places. Use this new
inline in those.

Cc: kristen.c.accardi@intel.com
Acked-by: Alex Chiang 
Signed-off-by: Jiri Slaby 
Signed-off-by: Jesse Barnes

PCI: add an option to allow ASPM enabled forcibly

2008-07-28T21:57:30+00:00

A new option, pcie_aspm=force, will force ASPM to be enabled, even on system
with PCIe 1.0 devices.

Signed-off-by: Shaohua Li 
Signed-off-by: Jesse Barnes