linux-toradex.git/drivers/pci/probe.c, branch v3.4.2

PCI: fix bridge I/O window bus-to-resource conversion

2012-03-20T17:41:27+00:00

In 5bfa14ed9f3c, I forgot to initialize res2.flags before calling
pcibios_bus_to_resource(), which depends on the resource type to locate the
correct aperture.  This bug won't hurt x86, which currently never has an
offset between bus and CPU addresses, but will affect other architectures.

Signed-off-by: Bjorn Helgaas 
Signed-off-by: Jesse Barnes

PCI: Move "pci reassigndev resource alignment" out of quirks.c

2012-02-24T22:37:26+00:00

This isn't really a quirk; calling it directly from pci_add_device makes
more sense.

Signed-off-by: Yinghai Lu 
Signed-off-by: Jesse Barnes

PCI: collapse pcibios_resource_to_bus

2012-02-24T03:19:04+00:00

Everybody uses the generic pcibios_resource_to_bus() supplied by the core
now, so remove the ARCH_HAS_GENERIC_PCI_OFFSETS used during conversion.

Signed-off-by: Bjorn Helgaas

PCI: add generic pcibios_resource_to_bus()

2012-02-24T03:19:00+00:00

This replaces the generic versions of pcibios_resource_to_bus() and
pcibios_bus_to_resource() in asm-generic/pci.h with versions that use
pci_resource_to_bus() and pci_bus_to_resource().

The replacements are equivalent except that they can apply host
bridge window offsets when the arch has supplied them by using
pci_add_resource_offset().

Each arch can convert to using pci_add_resource_offset() individually by
removing its device resource fixups from pcibios_fixup_bus() and supplying
ARCH_HAS_GENERIC_PCI_OFFSETS.  ARCH_HAS_GENERIC_PCI_OFFSETS can be removed
after all have converted.

Signed-off-by: Bjorn Helgaas

PCI: convert bus addresses to resource when reading BARs

2012-02-24T03:19:00+00:00

Some PCI host bridges translate CPU addresses to PCI bus addresses.
Previously, we initialized pci_dev resources with PCI bus addresses,
then converted them to CPU addresses later in arch-specific code
(pcibios_fixup_resources()), which leaves a window of time where the
pci_dev resources are incorrect.

This patch adds support in the core for this address translation.
When the arch creates the root bus, it can supply the host bridge
address translation information, and the core can use it to set the
pci_dev resources correctly from the beginning.

This gives us a way to fix the problem that quirks that run between device
discovery and pcibios_fixup_resources() fail because they use pci_dev
resources that haven't been converted.  The reference below is to one
such problem that affected ARM and ia64.

Note that this patch has no effect until an arch starts using
pci_add_resource_offset() with a non-zero offset: before that, all
all host bridge windows have a zero offset and pci_bus_to_resource()
copies the pci_bus_region directly to the struct resource.

Reference: https://lkml.org/lkml/2009/10/12/405
Signed-off-by: Bjorn Helgaas

PCI: add struct pci_host_bridge_window with CPU/bus address offset

2012-02-24T03:19:00+00:00

Some PCI host bridges apply an address offset, so bus addresses on PCI are
different from CPU addresses.  This patch adds a way for architectures to
tell the PCI core about this offset.  For example:

    LIST_HEAD(resources);
    pci_add_resource_offset(&resources, host->io_space, host->io_offset);
    pci_add_resource_offset(&resources, host->mem_space, host->mem_offset);
    pci_scan_root_bus(parent, bus, ops, sysdata, &resources);

Signed-off-by: Bjorn Helgaas

PCI: add struct pci_host_bridge and a list of all bridges found

2012-02-24T03:18:59+00:00

This adds a list of all PCI host bridges we find and a way to look up
the host bridge from a pci_dev.

Signed-off-by: Bjorn Helgaas

PCI: don't publish new root bus until it's fully initialized

2012-02-24T03:18:59+00:00

When pci_create_root_bus() adds the new struct pci_bus to the global
pci_root_buses list, the bus becomes visible to other parts of the
kernel, so it should be fully initialized.

This patch delays adding the bus to the pci_root_buses list until after
all the struct pci_bus initialization is finished.

Signed-off-by: Bjorn Helgaas

PCI: fix memleak for pci dev removing during hotplug

2012-02-23T20:08:53+00:00

unreferenced object 0xffff880276d17700 (size 64):
  comm "swapper/0", pid 1, jiffies 4294897182 (age 3976.028s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 18 f9 de 76 02 88 ff ff  ...........v....
    10 00 00 00 0e 00 00 00 0f 28 40 00 00 00 00 00  .........(@.....
  backtrace:
    [] kmemleak_alloc+0x26/0x43
    [] __kmalloc+0x121/0x183
    [] pci_add_cap_save_buffer+0x35/0x7c
    [] pci_allocate_cap_save_buffers+0x1d/0x65
    [] pci_device_add+0x92/0xf1
    [] pci_scan_single_device+0x9f/0xa1
    [] pci_scan_slot.part.20+0x21/0x106
    [] pci_scan_slot+0x2b/0x35
    [] __pci_scan_child_bus+0x51/0x107
    [] pci_scan_bridge+0x376/0x6ae
    [] __pci_scan_child_bus+0xcd/0x107
    [] pci_scan_child_bus+0x11/0x2a
    [] pci_acpi_scan_root+0x18b/0x21c
    [] acpi_pci_root_add+0x1e1/0x42a
    [] acpi_device_probe+0x50/0x190
    [] really_probe+0x99/0x126

Need to free saved_buffer for capabilities.

Signed-off-by: Yinghai Lu 
Signed-off-by: Jesse Barnes

PCI: Fix device class print out

2012-02-23T20:05:59+00:00

Found debug print of class is shifted.

| pci 0000:f8:15.2: [8086:2b56] type 0 class 0x000600

Code is trying to print class with 6 digits, but use shifted class with
4 digits valid value as variable.

Change to original dev->class directly.

Also remove not needed calculating of local variable class, because it
will be updated after pci_fixup_device(pci_fixup_early...)

Also unify type print out when class and header is not matched.

Signed-off-by: Yinghai Lu 
Signed-off-by: Jesse Barnes