linux-toradex.git/drivers/pci/rom.c, branch v3.11

PCI: Add PCI ROM helper for platform-provided ROM images

2013-03-26T23:19:41+00:00

It turns out that some UEFI systems provide apparently an apparently valid
PCI ROM BAR that turns out to contain garbage, so the attempt in 547b52463
to prefer the ROM from the BAR actually breaks a different set of machines.
As Linus pointed out, the graphics drivers are probably in the best
position to make this judgement, so this basically reverts 547b52463 and
f9a37be0f and adds a new helper function. Followup patches will add support
to nouveau and radeon for probing this ROM source if they can't find a ROM
from some other source.

[bhelgaas: added reporter and bugzilla pointers, s/f4eb5ff05/547b52463]
Reference: https://bugzilla.redhat.com/show_bug.cgi?id=927451
Reference: http://lkml.kernel.org/r/kg69ef$vdb$1@ger.gmane.org
Reported-by: Mantas Mikulėnas 
Reported-by: Chris Murphy 
Signed-off-by: Matthew Garrett 
Signed-off-by: Bjorn Helgaas

PCI: Use ROM images from firmware only if no other ROM source available

2013-03-19T21:51:14+00:00

Mantas Mikulėnas reported that his graphics hardware failed to
initialise after commit f9a37be0f02a ("x86: Use PCI setup data").

The aim of this commit was to ensure that ROM images were available on
some Apple systems that don't expose the GPU ROM via any other source.
In this case, UEFI appears to have provided a broken ROM image that we
were using even though there was a perfectly valid ROM available via
other sources.  The simplest way to handle this seems to be to just
re-order pci_map_rom() and leave any firmare-supplied ROM to last.

Signed-off-by: Matthew Garrett 
Tested-by: Mantas Mikulėnas 
Signed-off-by: Linus Torvalds

PCI: Use phys_addr_t for physical ROM address

2012-12-10T18:24:42+00:00

Use phys_addr_t rather than "void *" for physical memory address.
This removes casts and fixes a "cast from pointer to integer of different
size" warning on ppc44x_defconfig.

Signed-off-by: Bjorn Helgaas

PCI: Add support for non-BAR ROMs

2012-12-05T21:38:26+00:00

Platforms may provide their own mechanisms for obtaining ROMs. Add support
for using data provided by the platform in that case.

Signed-off-by: Matthew Garrett 
Signed-off-by: Bjorn Helgaas 
Tested-by: Seth Forshee

PCI: Remove unused, commented-out, code

2012-08-22T17:31:53+00:00

This removes unused code that was already commented out.

Tested-by: Yijing Wang 
Signed-off-by: Bjorn Helgaas 
Acked-by: Yinghai Lu

pci: Fix files needing export.h for EXPORT_SYMBOL/THIS_MODULE

2011-10-31T23:31:22+00:00

They were implicitly getting it from device.h --> module.h but
we want to clean that up.  So add the minimal header for these
macros.

Signed-off-by: Paul Gortmaker

PCI: fix rom.c kernel-doc warning

2009-02-13T20:01:56+00:00

Fix PCI kernel-doc warning:

Warning(linux-2.6.29-rc4-git1/drivers/pci/rom.c:67): No description found for parameter 'pdev'

Signed-off-by: Randy Dunlap 
cc: Jesse Barnes 
Signed-off-by: Jesse Barnes

PCI: return error on failure to read PCI ROMs

2009-02-05T00:58:41+00:00

This patch makes the ROM reading code return an error to user space if
the size of the ROM read is equal to 0.

The patch also emits a warnings if the contents of the ROM are invalid,
and documents the effects of the "enable" file on ROM reading.

Signed-off-by: Timothy S. Nelson 
Acked-by: Alex Villacis-Lasso 
Signed-off-by: Jesse Barnes

PCI: remove excess kernel-doc notation

2008-11-03T22:32:46+00:00

Fix pci/rom.c kernel-doc function notation:

Warning(drivers/pci/rom.c:110): Excess function parameter or struct member 'return' description in 'pci_map_rom'
Warning(drivers/pci/rom.c:177): Excess function parameter or struct member 'return' description in 'pci_map_rom_copy'

Signed-off-by: Randy Dunlap 
Signed-off-by: Jesse Barnes

Export the ROM enable/disable helpers

2008-09-27T00:59:05+00:00

.... so that they can be used by MTD map drivers. Lets us close #9420

Signed-off-by: Alan Cox 
Signed-off-by: David Woodhouse