linux-toradex.git/drivers/pci/setup-res.c, branch imx-android-r13.2

PCI: fix message typo

2010-10-18T03:03:05+00:00

I missed the closing parenthesis on "(PCI address ...)".

Acked-by: Arnd Bergmann 
Reported-by: Peter Maydell 
Signed-off-by: Bjorn Helgaas 
Signed-off-by: Jesse Barnes

PCI: fall back to original BIOS BAR addresses

2010-07-16T18:39:48+00:00

If we fail to assign resources to a PCI BAR, this patch makes us try the
original address from BIOS rather than leaving it disabled.

Linux tries to make sure all PCI device BARs are inside the upstream
PCI host bridge or P2P bridge apertures, reassigning BARs if necessary.
Windows does similar reassignment.

Before this patch, if we could not move a BAR into an aperture, we left
the resource unassigned, i.e., at address zero.  Windows leaves such BARs
at the original BIOS addresses, and this patch makes Linux do the same.

This is a bit ugly because we disable the resource long before we try to
reassign it, so we have to keep track of the BIOS BAR address somewhere.
For lack of a better place, I put it in the struct pci_dev.

I think it would be cleaner to attempt the assignment immediately when the
claim fails, so we could easily remember the original address.  But we
currently claim motherboard resources in the middle, after attempting to
claim PCI resources and before assigning new PCI resources, and changing
that is a fairly big job.

Addresses https://bugzilla.kernel.org/show_bug.cgi?id=16263

Reported-by: Andrew 
Tested-by: Andrew 
Signed-off-by: Bjorn Helgaas 
Signed-off-by: Jesse Barnes

PCI: change resource collision messages from KERN_ERR to KERN_INFO

2010-06-11T20:08:14+00:00

We can often deal with PCI resource issues by moving devices around.  In
that case, there's no point in alarming the user with messages like these.
There are many bug reports where the message itself is the only problem,
e.g., https://bugs.launchpad.net/ubuntu/+source/linux/+bug/413419 .

Signed-off-by: Bjorn Helgaas 
Signed-off-by: Jesse Barnes

PCI: for address space collisions, show conflicting resource

2010-03-24T20:21:34+00:00

With request_resource_conflict(), we can learn what the actual conflict is,
so print that info for debugging purposes.

Signed-off-by: Bjorn Helgaas 
Signed-off-by: Jesse Barnes

PCI: improve discovery/configuration messages

2009-11-04T21:06:44+00:00

This makes PCI resource management messages more consistent and adds a few
new messages to aid debugging.

Whenever we assign resources to a device, update a BAR, or change a
bridge aperture, it's worth noting it.

Signed-off-by: Bjorn Helgaas 
Signed-off-by: Jesse Barnes

vsprintf: use %pR, %pr instead of %pRt, %pRf

2009-11-04T21:06:41+00:00

Jesse accidentally applied v1 [1] of the patchset instead of v2 [2].  This
is the diff between v1 and v2.

The changes in this patch are:
    - tidied vsprintf stack buffer to shrink and compute size more
      accurately
    - use %pR for decoding and %pr for "raw" (with type and flags) instead
      of adding %pRt and %pRf

[1] http://lkml.org/lkml/2009/10/6/491
[2] http://lkml.org/lkml/2009/10/13/441

Signed-off-by: Bjorn Helgaas 
Signed-off-by: Jesse Barnes

PCI: print resources consistently with %pRt

2009-11-04T16:47:18+00:00

This uses %pRt to print additional resource information (type, size,
prefetchability, etc.) consistently.

Signed-off-by: Bjorn Helgaas 
Signed-off-by: Jesse Barnes

PCI: remove pci_assign_resource_fixed()

2009-10-06T16:42:04+00:00

Adrian commented out this function in 2baad5f96b49, but I don't think
it's even worth cluttering the file with the unused code.

Signed-off-by: Bjorn Helgaas 
Signed-off-by: Jesse Barnes

PCI: export pci_claim_resource for driver use

2009-09-09T20:29:20+00:00

yenta needs this for example.

Acked-by: Matthew Wilcox 
Reported-by: Stephen Rothwell 
Signed-off-by: Jesse Barnes

PCI SR-IOV: correct broken resource alignment calculations

2009-08-30T15:37:25+00:00

An SR-IOV capable device includes an SR-IOV PCIe capability which
describes the Virtual Function (VF) BAR requirements.  A typical SR-IOV
device can support multiple VFs whose BARs must be in a contiguous region,
effectively an array of VF BARs.  The BAR reports the size requirement
for a single VF.  We calculate the full range needed by simply multiplying
the VF BAR size with the number of possible VFs and create a resource
spanning the full range.

This all seems sane enough except it artificially inflates the alignment
requirement for the VF BAR.  The VF BAR need only be aligned to the size
of a single BAR not the contiguous range of VF BARs.  This can cause us
to fail to allocate resources for the BAR despite the fact that we
actually have enough space.

This patch adds a thin PCI specific layer over the generic
resource_alignment() function which is aware of the special nature of
VF BARs and does sorting and allocation based on the smaller alignment
requirement.

I recognize that while resource_alignment is generic, it's basically a
PCI helper.  An alternative to this patch is to add PCI VF BAR specific
information to struct resource.  I opted for the extra layer rather than
adding such PCI specific information to struct resource.  This does
have the slight downside that we don't cache the BAR size and re-read
for each alignment query (happens a small handful of times during boot
for each VF BAR).

Signed-off-by: Chris Wright 
Cc: Ivan Kokshaysky 
Cc: Linus Torvalds 
Cc: Matthew Wilcox 
Cc: Yu Zhao 
Cc: stable@kernel.org
Signed-off-by: Jesse Barnes