linux-toradex.git/drivers/phy/broadcom/phy-brcm-usb.c, branch v5.18-rc6

phy: phy-brcm-usb: fixup BCM4908 support

2022-02-25T09:02:37+00:00

Just like every other family BCM4908 should get its own enum value. That
is required to properly handle it in chipset conditional code.

The real change is excluding BCM4908 from the PLL reprogramming code
(see brcmusb_usb3_pll_54mhz()). I'm not sure what's the BCM4908
reference clock frequency but:
1. BCM4908 custom driver from Broadcom's SDK doesn't reprogram PLL
2. Doing that in Linux driver stopped PHY handling some USB 3.0 devices

This change makes USB 3.0 PHY recognize e.g.:
1. 04e8:6860 - Samsung Electronics Co., Ltd Galaxy series, misc. (MTP mode)
2. 1058:259f - Western Digital My Passport 259F

Broadcom's STB SoCs come with a set of SUN_TOP_CTRL_* registers that
allow reading chip family and product ids. Such a block & register is
missing on BCM4908 so this commit introduces "compatible" string
specific binding.

Fixes: 4b402fa8e0b7 ("phy: phy-brcm-usb: support PHY on the BCM4908")
Signed-off-by: Rafał Miłecki 
Reviewed-by: Florian Fainelli 
Link: https://lore.kernel.org/r/20220218172459.10431-1-zajec5@gmail.com
Signed-off-by: Vinod Koul

phy: usb: Leave some clocks running during suspend

2022-01-23T14:03:15+00:00

The PHY client driver does a phy_exit() call on suspend or rmmod and
the PHY driver needs to know the difference because some clocks need
to be kept running for suspend but can be shutdown on unbind/rmmod
(or if there are no PHY clients at all).

The fix is to use a PM notifier so the driver can tell if a PHY
client is calling exit() because of a system suspend or a driver
unbind/rmmod.

Signed-off-by: Al Cooper 
Acked-by: Florian Fainelli 
Link: https://lore.kernel.org/r/20211201180653.35097-2-alcooperx@gmail.com
Signed-off-by: Vinod Koul

phy: phy-brcm-usb: support PHY on the BCM4908

2021-01-13T14:15:40+00:00

BCM4908 seems to have slightly different registers but works when
programmed just like the STB one.

Signed-off-by: Rafał Miłecki 
Acked-by: Florian Fainelli 
Link: https://lore.kernel.org/r/20210106205838.10964-3-zajec5@gmail.com
Signed-off-by: Vinod Koul

phy: phy-brcm-usb: specify init function format at struct level

2021-01-13T11:58:58+00:00

This is slightly cleaner solution that assures noone assings a wrong
function to the pointer.

Signed-off-by: Rafał Miłecki 
Acked-by: Florian Fainelli 
Link: https://lore.kernel.org/r/20201216143305.12179-2-zajec5@gmail.com
Signed-off-by: Vinod Koul

phy: phy-brcm-usb: improve getting OF matching data

2021-01-13T11:58:58+00:00

1. Use of_device_get_match_data() helper to simplify the code
2. Check for NULL as a good practice

Signed-off-by: Rafał Miłecki 
Acked-by: Florian Fainelli 
Link: https://lore.kernel.org/r/20201216143305.12179-1-zajec5@gmail.com
Signed-off-by: Vinod Koul

phy: phy-brcm-usb: Constify static structs

2020-05-18T14:00:56+00:00

A number of structs were not modified and can therefore be made const
to allow the compiler to put them in read-only memory.

In order to do so, update a few functions that don't modify there input
to take pointers to const.

Before:
   text    data     bss     dec     hex filename
  15511    6448      64   22023    5607 drivers/phy/broadcom/phy-brcm-usb.o

After:
   text    data     bss     dec     hex filename
  16058    5936      64   22058    562a drivers/phy/broadcom/phy-brcm-usb.o

Signed-off-by: Rikard Falkeborn 
Link: https://lore.kernel.org/r/20200516120441.7627-4-rikard.falkeborn@gmail.com
Signed-off-by: Kishon Vijay Abraham I

phy: usb: Add support for wake and USB low power mode for 7211 S2/S5

2020-01-08T07:28:06+00:00

Add support for 7211 USB wake. Disable all possible 7211 USB logic
for S2/S5 if USB wake is not enabled.

On the 7211, the XHCI wake signal was not connected properly and
only goes to the USB1_USB1_CTRL_TP_DIAG1 diagonstic register.
The workaround is to have VPU code running that polls for the
proper bit in the DIAG register and to wake the system when
the bit is asserted.

Signed-off-by: Al Cooper 
Reviewed-by: Florian Fainelli 
Signed-off-by: Kishon Vijay Abraham I

phy: usb: USB driver is crashing during S3 resume on 7216

2020-01-08T07:28:06+00:00

This is a result of the USB 2.0 clocks not being disabled/enabled
during suspend/resume on XHCI only systems.

Signed-off-by: Al Cooper 
Reviewed-by: Florian Fainelli 
Signed-off-by: Kishon Vijay Abraham I

phy: usb: bdc: Fix occasional failure with BDC on 7211

2020-01-08T07:28:06+00:00

The BDC "Read Transaction Size" needs to be changed from 1024
bytes to 256 bytes to prevent occasional transaction failures.

Signed-off-by: Al Cooper 
Reviewed-by: Florian Fainelli 
Signed-off-by: Kishon Vijay Abraham I

phy: usb: fix driver to defer on clk_get defer

2020-01-08T07:28:06+00:00

Handle defer on clk_get because the new SCMI clock driver comes
up after this driver.

Signed-off-by: Al Cooper 
Reviewed-by: Florian Fainelli 
Signed-off-by: Kishon Vijay Abraham I