linux-toradex.git/drivers/phy/phy-sun4i-usb.c, branch v4.9.74

phy: sun4i: check PMU presence when poking unknown bit of pmu

2016-11-05T08:15:02+00:00

Allwinner SoC's PHY 0, when used as OTG controller, have no pmu part.
The code that poke some unknown bit of PMU for H3/A64 didn't check
the PHY, and will cause kernel oops when PHY 0 is used.

This patch will check whether the pmu is not NULL before poking.

Fixes: b3e0d141ca9f (phy: sun4i: add support for A64 usb phy)

Signed-off-by: Icenowy Zheng 
Acked-by: Maxime Ripard 
Reviewed-by: Hans de Goede 
Signed-off-by: Kishon Vijay Abraham I

phy: sun4i-usb: Use spinlock to guard phyctl register access

2016-09-10T12:13:38+00:00

The musb driver calls into this phy driver to disable/enable squelch
detection. This function was introduced in 24fe86a617c5 ("phy: sun4i-usb:
Add a sunxi specific function for setting squelch-detect"). This
function in turn calls sun4i_usb_phy_write, which uses a mutex to
guard the common access register. Unfortunately musb does this
in atomic context, which results in the following warning with lock
debugging enabled:

BUG: sleeping function called from invalid context at kernel/locking/mutex.c:97
in_atomic(): 1, irqs_disabled(): 128, pid: 96, name: kworker/0:2
CPU: 0 PID: 96 Comm: kworker/0:2 Not tainted 4.8.0-rc4-00181-gd502f8ad1c3e #13
Hardware name: Allwinner sun8i Family
Workqueue: events musb_deassert_reset
[] (unwind_backtrace) from [] (show_stack+0xb/0xc)
[] (show_stack) from [] (dump_stack+0x67/0x74)
[] (dump_stack) from [] (mutex_lock+0x15/0x2c)
[] (mutex_lock) from [] (sun4i_usb_phy_write+0x39/0xec)
[] (sun4i_usb_phy_write) from [] (musb_port_reset+0xfb/0x184)
[] (musb_port_reset) from [] (musb_deassert_reset+0x1f/0x2c)
[] (musb_deassert_reset) from [] (process_one_work+0x129/0x2b8)
[] (process_one_work) from [] (worker_thread+0xf3/0x424)
[] (worker_thread) from [] (kthread+0xa1/0xb8)
[] (kthread) from [] (ret_from_fork+0x11/0x20)

Since the register access is mmio, we can use a spinlock to guard this
specific access, rather than the mutex that guards the entire phy.

Fixes: ba4bdc9e1dc0 ("PHY: sunxi: Add driver for sunxi usb phy")
Cc: Hans de Goede 
Cc: stable@vger.kernel.org
Signed-off-by: Chen-Yu Tsai 
Reviewed-by: Hans de Goede 
Signed-off-by: Kishon Vijay Abraham I

phy-sun4i-usb: Warn when external vbus is detected

2016-09-10T11:45:19+00:00

Warn when external vbus is detected when we're trying to enable our
own vbus.

Signed-off-by: Hans de Goede 
Signed-off-by: Kishon Vijay Abraham I

phy-sun4i-usb: Add support for phy_set_mode

2016-09-10T11:45:19+00:00

Together with some musb sunxi glue changes this allows run-time dr_mode
switching support via the "mode" musb sysfs attribute.

Signed-off-by: Hans de Goede 
Signed-off-by: Kishon Vijay Abraham I

phy-sun4i-usb: Simplify missing dr_mode handling

2016-09-10T11:45:19+00:00

If we cannot get dr_mode or no id gpio is specified simply assume
peripheral mode, as this is always safe.

Signed-off-by: Hans de Goede 
Signed-off-by: Kishon Vijay Abraham I

phy-sun4i-usb: Refactor forced session ending

2016-09-10T11:45:19+00:00

The phy-sun4i-usb code supports forced ending a session on systems
which lack Vbus detection, to allow switching between host and peripheral
mode on such systems.

Role switching via the musb driver "mode" sysfs attribute requires force
ending the session too. This commit refactors the code to allow other
parts of the phy-sun4i-usb code to request a forced session end.

Signed-off-by: Hans de Goede 
Signed-off-by: Kishon Vijay Abraham I

phy-sun4i-usb: Use bool where appropriate

2016-09-10T11:45:19+00:00

We're using bool as true/false type in most places in phy-sun4i-usb.c
for consistency fixup the remaining uses of ints which are ever only
0 or 1 to be bools too.

Signed-off-by: Hans de Goede 
Signed-off-by: Kishon Vijay Abraham I

phy: sun4i: add support for A64 usb phy

2016-09-10T11:18:27+00:00

There's something unknown in the pmu part that shared with H3.
It's renamed as PMU_UNK1 from PMU_UNK_H3.

Signed-off-by: Icenowy Zheng 
Signed-off-by: Kishon Vijay Abraham I

phy-sun4i-usb: Add support for peripheral-only mode

2016-08-12T09:29:10+00:00

Use the new of_usb_get_dr_mode_by_phy() function to get the dr_mode
from the musb controller node instead of assuming that having an id_det
gpio means otg mode, and not having one means host mode.

Implement peripheral-only mode by adding a sun4i_usb_phy0_get_id_det
helper which looks at the dr_mode, always registering our extcon and
always monitoring vbus.

If dr_mode is not specified in the dts, do not register phy0 as we then
do not know how to treat it. This is actually a good thing as this means
we will not be registering phy0 on devices where the otg controller is
not enabled in the devicetree.

Signed-off-by: Hans de Goede 
Acked-by: Kishon Vijay Abraham I 
Signed-off-by: Kishon Vijay Abraham I

phy-sun4i-usb: Add workaround for missing Vbus det interrupts on A31

2016-07-04T12:37:39+00:00

The A31 companion pmic (axp221) does not generate vbus change interrupts
when the board is driving vbus, so we must poll when using the pmic for
vbus-det _and_ we're driving vbus.

Signed-off-by: Hans de Goede 
Acked-by: Kishon Vijay Abraham I 
Signed-off-by: Kishon Vijay Abraham I